PdfFontFactory font embedding strategy

DEVSIX-5043

Autoported commit.
Original commit hash: [c06740ee9]

Author: BezrukovM

itext.tests/itext.forms.tests/itext/forms/PdfFormFieldMultilineTextTest.cs

@@ -180,7 +180,7 @@ public virtual void FormFieldFilledWithStringTest() {
             String value = "12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890";
             PdfDocument pdfDoc = new PdfDocument(new PdfWriter(destinationFolder + "formFieldWithStringTest.pdf"));
             PdfFont font = PdfFontFactory.CreateFont(sourceFolder + "NotoSansCJKtc-Light.otf", PdfEncodings.IDENTITY_H
-                , true);
+                );
             PdfAcroForm acroForm = PdfAcroForm.GetAcroForm(pdfDoc, true);
             PdfFormField form = PdfTextFormField.CreateMultilineText(pdfDoc, new Rectangle(59, 715, 127, 69), "field", 
                 "", font, 10f);

itext.tests/itext.forms.tests/itext/forms/PdfFormFieldTest.cs

@@ -531,9 +531,9 @@ public virtual void FillFieldWithHebrewCase1() {
             PdfDocument pdfDoc = new PdfDocument(writer);
             Document document = new Document(pdfDoc);
             PdfFont hebrew = PdfFontFactory.CreateFont(sourceFolder + "OpenSansHebrew-Regular.ttf", PdfEncodings.IDENTITY_H
-                , true);
+                );
             hebrew.SetSubset(false);
-            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H, true);
+            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H);
             sileot.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, true);
             String text = "שלום וברכה";
@@ -557,9 +557,9 @@ public virtual void FillFieldWithHebrewCase2() {
             PdfDocument pdfDoc = new PdfDocument(writer);
             Document document = new Document(pdfDoc);
             PdfFont hebrew = PdfFontFactory.CreateFont(sourceFolder + "OpenSansHebrew-Regular.ttf", PdfEncodings.IDENTITY_H
-                , true);
+                );
             hebrew.SetSubset(false);
-            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H, true);
+            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H);
             sileot.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, true);
             CreateAcroForm(pdfDoc, form, hebrew, null, 0);
@@ -585,9 +585,9 @@ public virtual void FillFieldWithHebrewCase3() {
             PdfWriter writer = new PdfWriter(outPdf);
             PdfDocument pdfDoc = new PdfDocument(writer);
             PdfFont hebrew = PdfFontFactory.CreateFont(sourceFolder + "OpenSansHebrew-Regular.ttf", PdfEncodings.IDENTITY_H
-                , true);
+                );
             hebrew.SetSubset(false);
-            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H, true);
+            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H);
             sileot.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, true);
             String text = "שלום וברכה";
@@ -608,9 +608,9 @@ public virtual void FillFieldWithHebrewCase4() {
             PdfWriter writer = new PdfWriter(baos);
             PdfDocument pdfDoc = new PdfDocument(writer);
             PdfFont hebrew = PdfFontFactory.CreateFont(sourceFolder + "OpenSansHebrew-Regular.ttf", PdfEncodings.IDENTITY_H
-                , true);
+                );
             hebrew.SetSubset(false);
-            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H, true);
+            PdfFont sileot = PdfFontFactory.CreateFont(sourceFolder + "SILEOT.ttf", PdfEncodings.IDENTITY_H);
             sileot.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, true);
             CreateAcroForm(pdfDoc, form, hebrew, null, 0);

itext.tests/itext.forms.tests/itext/forms/PdfFormFieldTextTest.cs

@@ -80,8 +80,7 @@ public virtual void FontsResourcesHelvFontTest() {
             String filename = "fontsResourcesHelvFontTest.pdf";
             PdfDocument pdfDoc = new PdfDocument(new PdfReader(sourceFolder + "drWithHelv.pdf"), new PdfWriter(destinationFolder
                  + filename));
-            PdfFont font = PdfFontFactory.CreateFont(sourceFolder + "NotoSans-Regular.ttf", PdfEncodings.IDENTITY_H, true
-                );
+            PdfFont font = PdfFontFactory.CreateFont(sourceFolder + "NotoSans-Regular.ttf", PdfEncodings.IDENTITY_H);
             font.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, false);
             form.GetField("description").SetValue(TEXT, font, 12f);
@@ -108,8 +107,7 @@ public virtual void FontsResourcesHelvCourierNotoFontTest() {
             String filename = "fontsResourcesHelvCourierNotoFontTest.pdf";
             PdfDocument pdfDoc = new PdfDocument(new PdfReader(sourceFolder + "drWithHelvAndCourier.pdf"), new PdfWriter
                 (destinationFolder + filename));
-            PdfFont font = PdfFontFactory.CreateFont(sourceFolder + "NotoSans-Regular.ttf", PdfEncodings.IDENTITY_H, true
-                );
+            PdfFont font = PdfFontFactory.CreateFont(sourceFolder + "NotoSans-Regular.ttf", PdfEncodings.IDENTITY_H);
             font.SetSubset(false);
             PdfAcroForm form = PdfAcroForm.GetAcroForm(pdfDoc, false);
             form.GetField("description").SetFont(font);