Skip to content

Commit 4081707

Browse files
ars18wrwiText-CI
authored andcommitted
Improve TODOs of OCSPVerifier
Provide the tickets unders which the TODOs should be resolved DEVSIX-5141 Autoported commit. Original commit hash: [48b3b3d4b]
1 parent 7bc2097 commit 4081707

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

itext/itext.sign/itext/signatures/OCSPVerifier.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ public virtual void IsValidResponse(BasicOcspResp ocspResp, X509Certificate issu
253253
if (responderCert.GetExtensionValue(OcspObjectIdentifiers.PkixOcspNocheck.Id) == null) {
254254
X509Crl crl;
255255
try {
256-
// TODO should also check for Authority Information Access according to RFC6960 4.2.2.2.1. "Revocation Checking of an Authorized Responder"
257-
// TODO should also respect onlineCheckingAllowed property?
256+
// TODO DEVSIX-5210 Implement a check heck for Authority Information Access according to
257+
// RFC6960 4.2.2.2.1. "Revocation Checking of an Authorized Responder"
258258
crl = CertificateUtil.GetCRL(responderCert);
259259
}
260260
catch (Exception) {
@@ -275,8 +275,8 @@ public virtual void IsValidResponse(BasicOcspResp ocspResp, X509Certificate issu
275275
}
276276
}
277277
else {
278-
// TODO throw exception starting from iText version 7.2, but only after OCSPVerifier would allow explicit setting revocation check end points/provide revocation data
279-
// throw new VerificationException(issuerCert, "Authorized OCSP responder certificate revocation status cannot be checked.");
278+
// TODO DEVSIX-5207 throw exception starting from iText version 7.2, but only after OCSPVerifier
279+
// would allow explicit setting revocation check end points/provide revocation data
280280
// certificate chain is not present in response received
281281
// try to verify using rootStore according to RFC 6960 2.2. Response:
282282
// "The key used to sign the response MUST belong to one of the following:

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ff08e8fdea70e17ac8b6294045d8c23209f42a63
1+
48b3b3d4b12ada7dea41291ad1919a375a7c4554

0 commit comments

Comments
 (0)