Skip to content

Commit 63aea5e

Browse files
yulian-gaponenkoitext-teamcity
authored andcommitted
Document that the range of pages for copying in PdfDocument methods is inclusive
Autoported commit. Original commit hash: [ba3c8ebcb]
1 parent 5ade4ed commit 63aea5e

File tree

3 files changed

+29
-12
lines changed

3 files changed

+29
-12
lines changed

itext/itext.kernel/itext/kernel/pdf/PdfDocument.cs

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -951,12 +951,17 @@ public virtual IList<PdfPage> CopyPagesTo(int pageFrom, int pageTo, iText.Kernel
951951
/// <summary>
952952
/// Copies a range of pages from current document to
953953
/// <paramref name="toDocument"/>
954-
/// .
954+
/// . This range is inclusive, both
955+
/// <c>page</c>
956+
/// and
957+
/// <paramref name="pageTo"/>
958+
/// are included in list of copied pages.
955959
/// Use this method if you want to copy pages across tagged documents.
956960
/// This will keep resultant PDF structure consistent.
957961
/// </summary>
958962
/// <param name="pageFrom">1-based start of the range of pages to be copied.</param>
959-
/// <param name="pageTo">1-based end of the range of pages to be copied.</param>
963+
/// <param name="pageTo">1-based end (inclusive) of the range of pages to be copied. This page is included in list of copied pages.
964+
/// </param>
960965
/// <param name="toDocument">a document to copy pages to.</param>
961966
/// <param name="insertBeforePage">a position where to insert copied pages.</param>
962967
/// <param name="copier">
@@ -978,12 +983,18 @@ public virtual IList<PdfPage> CopyPagesTo(int pageFrom, int pageTo, iText.Kernel
978983
/// <summary>
979984
/// Copies a range of pages from current document to
980985
/// <paramref name="toDocument"/>
981-
/// appending copied pages to the end.
986+
/// appending copied pages to the end. This range
987+
/// is inclusive, both
988+
/// <c>page</c>
989+
/// and
990+
/// <paramref name="pageTo"/>
991+
/// are included in list of copied pages.
982992
/// Use this method if you want to copy pages across tagged documents.
983993
/// This will keep resultant PDF structure consistent.
984994
/// </summary>
985995
/// <param name="pageFrom">1-based start of the range of pages to be copied.</param>
986-
/// <param name="pageTo">1-based end of the range of pages to be copied.</param>
996+
/// <param name="pageTo">1-based end (inclusive) of the range of pages to be copied. This page is included in list of copied pages.
997+
/// </param>
987998
/// <param name="toDocument">a document to copy pages to.</param>
988999
/// <returns>list of new copied pages</returns>
9891000
public virtual IList<PdfPage> CopyPagesTo(int pageFrom, int pageTo, iText.Kernel.Pdf.PdfDocument toDocument
@@ -994,12 +1005,18 @@ public virtual IList<PdfPage> CopyPagesTo(int pageFrom, int pageTo, iText.Kernel
9941005
/// <summary>
9951006
/// Copies a range of pages from current document to
9961007
/// <paramref name="toDocument"/>
997-
/// appending copied pages to the end.
1008+
/// appending copied pages to the end. This range
1009+
/// is inclusive, both
1010+
/// <c>page</c>
1011+
/// and
1012+
/// <paramref name="pageTo"/>
1013+
/// are included in list of copied pages.
9981014
/// Use this method if you want to copy pages across tagged documents.
9991015
/// This will keep resultant PDF structure consistent.
10001016
/// </summary>
10011017
/// <param name="pageFrom">1-based start of the range of pages to be copied.</param>
1002-
/// <param name="pageTo">1-based end of the range of pages to be copied.</param>
1018+
/// <param name="pageTo">1-based end (inclusive) of the range of pages to be copied. This page is included in list of copied pages.
1019+
/// </param>
10031020
/// <param name="toDocument">a document to copy pages to.</param>
10041021
/// <param name="copier">
10051022
/// a copier which bears a special copy logic. May be null.
@@ -1020,7 +1037,7 @@ public virtual IList<PdfPage> CopyPagesTo(int pageFrom, int pageTo, iText.Kernel
10201037
/// Use this method if you want to copy pages across tagged documents.
10211038
/// This will keep resultant PDF structure consistent.
10221039
/// </summary>
1023-
/// <param name="pagesToCopy">list of pages to be copied. TreeSet for the order of the pages to be natural.</param>
1040+
/// <param name="pagesToCopy">list of pages to be copied.</param>
10241041
/// <param name="toDocument">a document to copy pages to.</param>
10251042
/// <param name="insertBeforePage">a position where to insert copied pages.</param>
10261043
/// <returns>list of new copied pages</returns>
@@ -1036,7 +1053,7 @@ public virtual IList<PdfPage> CopyPagesTo(IList<int> pagesToCopy, iText.Kernel.P
10361053
/// Use this method if you want to copy pages across tagged documents.
10371054
/// This will keep resultant PDF structure consistent.
10381055
/// </summary>
1039-
/// <param name="pagesToCopy">list of pages to be copied. TreeSet for the order of the pages to be natural.</param>
1056+
/// <param name="pagesToCopy">list of pages to be copied.</param>
10401057
/// <param name="toDocument">a document to copy pages to.</param>
10411058
/// <param name="insertBeforePage">a position where to insert copied pages.</param>
10421059
/// <param name="copier">
@@ -1126,7 +1143,7 @@ public virtual IList<PdfPage> CopyPagesTo(IList<int> pagesToCopy, iText.Kernel.P
11261143
/// Use this method if you want to copy pages across tagged documents.
11271144
/// This will keep resultant PDF structure consistent.
11281145
/// </summary>
1129-
/// <param name="pagesToCopy">list of pages to be copied. TreeSet for the order of the pages to be natural.</param>
1146+
/// <param name="pagesToCopy">list of pages to be copied.</param>
11301147
/// <param name="toDocument">a document to copy pages to.</param>
11311148
/// <returns>list of copied pages</returns>
11321149
public virtual IList<PdfPage> CopyPagesTo(IList<int> pagesToCopy, iText.Kernel.Pdf.PdfDocument toDocument) {
@@ -1140,7 +1157,7 @@ public virtual IList<PdfPage> CopyPagesTo(IList<int> pagesToCopy, iText.Kernel.P
11401157
/// Use this method if you want to copy pages across tagged documents.
11411158
/// This will keep resultant PDF structure consistent.
11421159
/// </summary>
1143-
/// <param name="pagesToCopy">list of pages to be copied. TreeSet for the order of the pages to be natural.</param>
1160+
/// <param name="pagesToCopy">list of pages to be copied.</param>
11441161
/// <param name="toDocument">a document to copy pages to.</param>
11451162
/// <param name="copier">
11461163
/// a copier which bears a special copy logic. May be null.

itext/itext.kernel/itext/kernel/utils/PdfMerger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public virtual iText.Kernel.Utils.PdfMerger SetCloseSourceDocuments(bool closeSo
117117
/// </remarks>
118118
/// <param name="from">- document, from which pages will be copied.</param>
119119
/// <param name="fromPage">- start page in the range of pages to be copied.</param>
120-
/// <param name="toPage">- end page in the range to be copied.</param>
120+
/// <param name="toPage">- end (inclusive) page in the range to be copied</param>
121121
/// <returns>
122122
/// this
123123
/// <c>PdfMerger</c>

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ffcefc4e29a27d1159a48db20c6145b467445df2
1+
ba3c8ebcb58056b8458840ab1190aa9e03f9deb8

0 commit comments

Comments
 (0)