If one glyph is substituted to many glyphs, actual text should be distributed

DEVSIX-4529

Autoported commit.
Original commit hash: [99260f10c]

Author: ars18wrw

itext.tests/itext.io.tests/itext/io/font/otf/GlyphLineTest.cs

@@ -175,5 +175,54 @@ public virtual void TestContentReplacingWithNullActualText() {
             // Test that no exception has been thrown. Also check the content.
             NUnit.Framework.Assert.AreEqual("Belarus", lineToBeReplaced.ToString());
         }
+
+        [NUnit.Framework.Test]
+        public virtual void TestActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany01() {
+            String expectedActualTextForFirstGlyph = "0";
+            String expectedActualTextForSecondGlyph = "A";
+            byte[] ttf = StreamUtil.InputStreamToArray(new FileStream(iText.Test.TestUtil.GetParentProjectDirectory(NUnit.Framework.TestContext
+                .CurrentContext.TestDirectory) + "/resources/itext/io/font/otf/FreeSans.ttf", FileMode.Open, FileAccess.Read
+                ));
+            TrueTypeFont font = new TrueTypeFont(ttf);
+            // no actual text for the second glyph is set - it should be created during substitution
+            GlyphLine line = new GlyphLine(ConstructGlyphListFromString("AA", font));
+            line.SetActualText(0, 1, expectedActualTextForFirstGlyph);
+            line.idx = 1;
+            line.SubstituteOneToMany(font.GetGsubTable(), new int[] { 39, 40 });
+            NUnit.Framework.Assert.IsNotNull(line.actualText);
+            NUnit.Framework.Assert.AreEqual(3, line.actualText.Count);
+            NUnit.Framework.Assert.AreSame(line.actualText[1], line.actualText[2]);
+            NUnit.Framework.Assert.AreEqual(expectedActualTextForSecondGlyph, line.actualText[1].value);
+            // check that it hasn't been corrupted
+            NUnit.Framework.Assert.AreEqual(expectedActualTextForFirstGlyph, line.actualText[0].value);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void TestActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany02() {
+            String expectedActualTextForFirstGlyph = "A";
+            byte[] ttf = StreamUtil.InputStreamToArray(new FileStream(iText.Test.TestUtil.GetParentProjectDirectory(NUnit.Framework.TestContext
+                .CurrentContext.TestDirectory) + "/resources/itext/io/font/otf/FreeSans.ttf", FileMode.Open, FileAccess.Read
+                ));
+            TrueTypeFont font = new TrueTypeFont(ttf);
+            GlyphLine line = new GlyphLine(ConstructGlyphListFromString("A", font));
+            line.SetActualText(0, 1, expectedActualTextForFirstGlyph);
+            line.SubstituteOneToMany(font.GetGsubTable(), new int[] { 39, 40 });
+            NUnit.Framework.Assert.IsNotNull(line.actualText);
+            NUnit.Framework.Assert.AreEqual(2, line.actualText.Count);
+            NUnit.Framework.Assert.AreSame(line.actualText[0], line.actualText[1]);
+            NUnit.Framework.Assert.AreEqual(expectedActualTextForFirstGlyph, line.actualText[0].value);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void TestActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany03() {
+            byte[] ttf = StreamUtil.InputStreamToArray(new FileStream(iText.Test.TestUtil.GetParentProjectDirectory(NUnit.Framework.TestContext
+                .CurrentContext.TestDirectory) + "/resources/itext/io/font/otf/FreeSans.ttf", FileMode.Open, FileAccess.Read
+                ));
+            TrueTypeFont font = new TrueTypeFont(ttf);
+            // no actual text is set
+            GlyphLine line = new GlyphLine(ConstructGlyphListFromString("A", font));
+            line.SubstituteOneToMany(font.GetGsubTable(), new int[] { 39, 40 });
+            NUnit.Framework.Assert.IsNull(line.actualText);
+        }
     }
 }

itext.tests/itext.io.tests/resources/itext/io/font/otf/NOTICE.txt

@@ -0,0 +1,3 @@
+This software uses the following test resources under the following licenses:
+| FreeSans | GPL | https://www.gnu.org/licenses |
+| FreeSansBold | GPL | https://www.gnu.org/licenses |

itext/itext.io/itext/io/font/otf/GlyphLine.cs

@@ -290,6 +290,7 @@ public virtual void SubstituteOneToOne(OpenTypeFontTableReader tableReader, int
         public virtual void SubstituteOneToMany(OpenTypeFontTableReader tableReader, int[] substGlyphIds) {
             //sequence length shall be at least 1
             int substCode = substGlyphIds[0];
+            Glyph oldGlyph = glyphs[idx];
             Glyph glyph = tableReader.GetGlyph(substCode);
             glyphs[idx] = glyph;
             if (substGlyphIds.Length > 1) {
@@ -300,6 +301,14 @@ public virtual void SubstituteOneToMany(OpenTypeFontTableReader tableReader, int
                     additionalGlyphs.Add(glyph);
                 }
                 AddAllGlyphs(idx + 1, additionalGlyphs);
+                if (null != actualText) {
+                    if (null == actualText[idx]) {
+                        actualText[idx] = new GlyphLine.ActualText(oldGlyph.GetUnicodeString());
+                    }
+                    for (int i = 0; i < additionalGlyphs.Count; i++) {
+                        this.actualText[idx + 1 + i] = actualText[idx];
+                    }
+                }
                 idx += substGlyphIds.Length - 1;
                 end += substGlyphIds.Length - 1;
             }

port-hash

@@ -1 +1 @@
-1d721562c3563cdc12b0e86d75878c5f7e75acd1
+99260f10c6c7948795869681f085f9f5f9871784