Apply text chunk's characteristics to a line only if the chunk is going to be drawn inside that line.

Add some new tests to demonstrate the issue.

DEVSIX-2552

Autoported commit.
Original commit hash: [d9f7ccd1f]

Author: ars18wrw

itext.tests/itext.layout.tests/itext/layout/ParagraphTest.cs

@@ -0,0 +1,79 @@
+using System;
+using iText.Kernel.Colors;
+using iText.Kernel.Pdf;
+using iText.Kernel.Utils;
+using iText.Layout.Borders;
+using iText.Layout.Element;
+using iText.Layout.Properties;
+using iText.Test;
+
+namespace iText.Layout {
+    public class ParagraphTest : ExtendedITextTest {
+        public static readonly String destinationFolder = NUnit.Framework.TestContext.CurrentContext.TestDirectory
+             + "/test/itext/layout/ParagraphTest/";
+
+        public static readonly String sourceFolder = iText.Test.TestUtil.GetParentProjectDirectory(NUnit.Framework.TestContext
+            .CurrentContext.TestDirectory) + "/resources/itext/layout/ParagraphTest/";
+
+        [NUnit.Framework.OneTimeSetUp]
+        public static void BeforeClass() {
+            CreateDestinationFolder(destinationFolder);
+        }
+
+        /// <exception cref="System.IO.IOException"/>
+        /// <exception cref="System.Exception"/>
+        [NUnit.Framework.Test]
+        public virtual void CannotPlaceABigChunkOnALineTest01() {
+            String outFileName = destinationFolder + "cannotPlaceABigChunkOnALineTest01.pdf";
+            String cmpFileName = sourceFolder + "cmp_cannotPlaceABigChunkOnALineTest01.pdf";
+            PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+            Document doc = new Document(pdfDocument);
+            Paragraph p = new Paragraph().SetBorder(new SolidBorder(ColorConstants.YELLOW, 0));
+            p.Add(new Text("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa").SetBorder
+                (new SolidBorder(ColorConstants.RED, 0)));
+            p.Add(new Text("b").SetFontSize(100).SetBorder(new SolidBorder(ColorConstants.BLUE, 0)));
+            doc.Add(p);
+            doc.Close();
+            NUnit.Framework.Assert.IsNull(new CompareTool().CompareByContent(outFileName, cmpFileName, destinationFolder
+                , "diff"));
+        }
+
+        /// <exception cref="System.IO.IOException"/>
+        /// <exception cref="System.Exception"/>
+        [NUnit.Framework.Test]
+        public virtual void CannotPlaceABigChunkOnALineTest02() {
+            String outFileName = destinationFolder + "cannotPlaceABigChunkOnALineTest02.pdf";
+            String cmpFileName = sourceFolder + "cmp_cannotPlaceABigChunkOnALineTest02.pdf";
+            PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+            Document doc = new Document(pdfDocument);
+            Paragraph p = new Paragraph().SetBorder(new SolidBorder(ColorConstants.YELLOW, 0));
+            p.Add(new Text("smaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaall").SetFontSize(5).SetBorder
+                (new SolidBorder(ColorConstants.RED, 0)));
+            p.Add(new Text("biiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiig"
+                ).SetFontSize(20).SetBorder(new SolidBorder(ColorConstants.BLUE, 0)));
+            doc.Add(p);
+            doc.Close();
+            NUnit.Framework.Assert.IsNull(new CompareTool().CompareByContent(outFileName, cmpFileName, destinationFolder
+                , "diff"));
+        }
+
+        /// <exception cref="System.IO.IOException"/>
+        /// <exception cref="System.Exception"/>
+        [NUnit.Framework.Test]
+        public virtual void WordWasSplitAndItWillFitOntoNextLineTest01() {
+            String outFileName = destinationFolder + "wordWasSplitAndItWillFitOntoNextLineTest01.pdf";
+            String cmpFileName = sourceFolder + "cmp_wordWasSplitAndItWillFitOntoNextLineTest01.pdf";
+            PdfDocument pdfDocument = new PdfDocument(new PdfWriter(outFileName));
+            Document doc = new Document(pdfDocument);
+            Paragraph p = new Paragraph().SetBorder(new SolidBorder(ColorConstants.YELLOW, 0)).SetTextAlignment(TextAlignment
+                .RIGHT);
+            for (int i = 0; i < 5; i++) {
+                p.Add(new Text("aaaaaaaaaaaaaaaaaaaaa" + i).SetBorder(new SolidBorder(ColorConstants.BLUE, 0)));
+            }
+            doc.Add(p);
+            doc.Close();
+            NUnit.Framework.Assert.IsNull(new CompareTool().CompareByContent(outFileName, cmpFileName, destinationFolder
+                , "diff"));
+        }
+    }
+}

itext.tests/itext.layout.tests/resources/itext/layout/ParagraphTest/cmp_cannotPlaceABigChunkOnALineTest01.pdf

@@ -55,14 +55,14 @@ source product.
 
 namespace iText.Layout.Renderer {
     public class LineRenderer : AbstractRenderer {
+        private const float MIN_MAX_WIDTH_CORRECTION_EPS = 0.001f;
+
         protected internal float maxAscent;
 
         protected internal float maxDescent;
 
         protected internal byte[] levels;
 
-        private const float MIN_MAX_WIDTH_CORRECTION_EPS = 0.001f;
-
         private float maxTextAscent;
 
         private float maxTextDescent;
@@ -71,8 +71,8 @@ public class LineRenderer : AbstractRenderer {
 
         private float maxBlockDescent;
 
-        // bidi levels
         // AbstractRenderer.EPS is not enough here
+        // bidi levels
         public override LayoutResult Layout(LayoutContext layoutContext) {
             Rectangle layoutBox = layoutContext.GetArea().GetBBox().Clone();
             bool wasParentsHeightClipped = layoutContext.IsClippedHeight();
@@ -375,28 +375,45 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
                         }
                     }
                 }
-                maxAscent = Math.Max(maxAscent, childAscent);
-                if (childRenderer is TextRenderer) {
-                    maxTextAscent = Math.Max(maxTextAscent, childAscent);
-                }
-                else {
-                    if (!isChildFloating) {
-                        maxBlockAscent = Math.Max(maxBlockAscent, childAscent);
+                bool newLineOccurred = (childResult is TextLayoutResult && ((TextLayoutResult)childResult).IsSplitForcedByNewline
+                    ());
+                bool shouldBreakLayouting = childResult.GetStatus() != LayoutResult.FULL || newLineOccurred;
+                bool wordWasSplitAndItWillFitOntoNextLine = false;
+                if (shouldBreakLayouting && childResult is TextLayoutResult && ((TextLayoutResult)childResult).IsWordHasBeenSplit
+                    ()) {
+                    if (wasXOverflowChanged) {
+                        SetProperty(Property.OVERFLOW_X, oldXOverflow);
+                    }
+                    LayoutResult newLayoutResult = childRenderer.Layout(new LayoutContext(new LayoutArea(layoutContext.GetArea
+                        ().GetPageNumber(), layoutBox), wasParentsHeightClipped));
+                    if (wasXOverflowChanged) {
+                        SetProperty(Property.OVERFLOW_X, OverflowPropertyValue.FIT);
+                    }
+                    if (newLayoutResult is TextLayoutResult && !((TextLayoutResult)newLayoutResult).IsWordHasBeenSplit()) {
+                        wordWasSplitAndItWillFitOntoNextLine = true;
                     }
                 }
-                maxDescent = Math.Min(maxDescent, childDescent);
-                if (childRenderer is TextRenderer) {
-                    maxTextDescent = Math.Min(maxTextDescent, childDescent);
-                }
-                else {
-                    if (!isChildFloating) {
-                        maxBlockDescent = Math.Min(maxBlockDescent, childDescent);
+                if (!wordWasSplitAndItWillFitOntoNextLine) {
+                    maxAscent = Math.Max(maxAscent, childAscent);
+                    if (childRenderer is TextRenderer) {
+                        maxTextAscent = Math.Max(maxTextAscent, childAscent);
+                    }
+                    else {
+                        if (!isChildFloating) {
+                            maxBlockAscent = Math.Max(maxBlockAscent, childAscent);
+                        }
+                    }
+                    maxDescent = Math.Min(maxDescent, childDescent);
+                    if (childRenderer is TextRenderer) {
+                        maxTextDescent = Math.Min(maxTextDescent, childDescent);
+                    }
+                    else {
+                        if (!isChildFloating) {
+                            maxBlockDescent = Math.Min(maxBlockDescent, childDescent);
+                        }
                     }
                 }
                 float maxHeight = maxAscent - maxDescent;
-                bool newLineOccurred = (childResult is TextLayoutResult && ((TextLayoutResult)childResult).IsSplitForcedByNewline
-                    ());
-                bool shouldBreakLayouting = childResult.GetStatus() != LayoutResult.FULL || newLineOccurred;
                 float currChildTextIndent = anythingPlaced ? 0 : lineLayoutContext.GetTextIndent();
                 if (hangingTabStop != null && (TabAlignment.LEFT == hangingTabStop.GetTabAlignment() || shouldBreakLayouting
                      || childRenderers.Count - 1 == childPos || childRenderers[childPos + 1] is TabRenderer)) {
@@ -436,25 +453,13 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
                         widthHandler.UpdateMaxChildWidth(maxChildWidth_1 + currChildTextIndent);
                     }
                 }
-                occupiedArea.SetBBox(new Rectangle(layoutBox.GetX(), layoutBox.GetY() + layoutBox.GetHeight() - maxHeight, 
-                    curWidth, maxHeight));
+                if (!wordWasSplitAndItWillFitOntoNextLine) {
+                    occupiedArea.SetBBox(new Rectangle(layoutBox.GetX(), layoutBox.GetY() + layoutBox.GetHeight() - maxHeight, 
+                        curWidth, maxHeight));
+                }
                 if (shouldBreakLayouting) {
                     LineRenderer[] split = Split();
                     split[0].childRenderers = new List<IRenderer>(childRenderers.SubList(0, childPos));
-                    bool wordWasSplitAndItWillFitOntoNextLine = false;
-                    if (childResult is TextLayoutResult && ((TextLayoutResult)childResult).IsWordHasBeenSplit()) {
-                        if (wasXOverflowChanged) {
-                            SetProperty(Property.OVERFLOW_X, oldXOverflow);
-                        }
-                        LayoutResult newLayoutResult = childRenderer.Layout(new LayoutContext(new LayoutArea(layoutContext.GetArea
-                            ().GetPageNumber(), layoutBox), wasParentsHeightClipped));
-                        if (wasXOverflowChanged) {
-                            SetProperty(Property.OVERFLOW_X, OverflowPropertyValue.FIT);
-                        }
-                        if (newLayoutResult is TextLayoutResult && !((TextLayoutResult)newLayoutResult).IsWordHasBeenSplit()) {
-                            wordWasSplitAndItWillFitOntoNextLine = true;
-                        }
-                    }
                     if (wordWasSplitAndItWillFitOntoNextLine) {
                         split[1].childRenderers.Add(childRenderer);
                         split[1].childRenderers.AddAll(childRenderers.SubList(childPos + 1, childRenderers.Count));
@@ -1288,14 +1293,14 @@ private bool IsInlineBlockChild(IRenderer child) {
         }
 
         internal class RendererGlyph {
+            public Glyph glyph;
+
+            public TextRenderer renderer;
+
             public RendererGlyph(Glyph glyph, TextRenderer textRenderer) {
                 this.glyph = glyph;
                 this.renderer = textRenderer;
             }
-
-            public Glyph glyph;
-
-            public TextRenderer renderer;
         }
     }
 }

itext.tests/itext.layout.tests/resources/itext/layout/ParagraphTest/cmp_cannotPlaceABigChunkOnALineTest02.pdf

@@ -1 +1 @@
-ef19e7b3ccbf8d37a7f84b3a149a8a32bb2f84e4
+d9f7ccd1f52be146f3cb22d7d96fa1d062df30df