Add color spots number check

BlackEgoist · iText-CI · commit 728b461df9ce · 2020-06-30T14:24:28.000+02:00
DEVSIX-4049

Autoported commit.
Original commit hash: [d6ef46467]
diff --git a/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA1ImplementationLimitsCheckerTest.cs b/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA1ImplementationLimitsCheckerTest.cs
@@ -41,10 +41,12 @@ source product.
 address: sales@itextpdf.com
 */
 using System;
+using System.Collections.Generic;
 using iText.Kernel.Colors;
 using iText.Kernel.Font;
 using iText.Kernel.Pdf;
 using iText.Kernel.Pdf.Colorspace;
+using iText.Kernel.Pdf.Function;
 using iText.Kernel.Pdf.Xobject;
 using iText.Pdfa;
 using iText.Test;
@@ -405,6 +407,25 @@ public virtual void LongStringInType3FontTest() {
 ;
         }
 
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWithMoreThan8Components() {
+            NUnit.Framework.Assert.That(() =>  {
+                CheckColorspace(BuildDeviceNColorspace(10));
+            }
+            , NUnit.Framework.Throws.InstanceOf<PdfAConformanceException>().With.Message.EqualTo(PdfAConformanceException.THE_NUMBER_OF_COLOR_COMPONENTS_IN_DEVICE_N_COLORSPACE_SHOULD_NOT_EXCEED))
+;
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWith8Components() {
+            CheckColorspace(BuildDeviceNColorspace(8));
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWithLessThan8Components() {
+            CheckColorspace(BuildDeviceNColorspace(2));
+        }
+
         private PdfString BuildLongString() {
             int maxAllowedLength = pdfA1Checker.GetMaxStringLength();
             int testLength = maxAllowedLength + 1;
@@ -512,5 +533,23 @@ private void CheckInType3Font(PdfObject @object) {
             dictionary.Put(PdfName.CharProcs, charProcs);
             pdfA1Checker.CheckFont(font);
         }
+
+        private void CheckColorspace(PdfColorSpace colorSpace) {
+            PdfDictionary currentColorSpaces = new PdfDictionary();
+            pdfA1Checker.CheckColorSpace(colorSpace, currentColorSpaces, false, false);
+        }
+
+        private PdfColorSpace BuildDeviceNColorspace(int numberOfComponents) {
+            IList<String> tmpArray = new List<String>(numberOfComponents);
+            float[] transformArray = new float[numberOfComponents * 2];
+            for (int i = 0; i < numberOfComponents; i++) {
+                tmpArray.Add("MyColor" + i + 1);
+                transformArray[i * 2] = 0;
+                transformArray[i * 2 + 1] = 1;
+            }
+            PdfFunction.Type4 function = new PdfFunction.Type4(new PdfArray(transformArray), new PdfArray(new float[] 
+                { 0, 1, 0, 1, 0, 1 }), "{0}".GetBytes(iText.IO.Util.EncodingUtil.ISO_8859_1));
+            return new PdfSpecialCs.DeviceN(tmpArray, new PdfDeviceCs.Rgb(), function);
+        }
     }
 }
diff --git a/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA2CheckerTest.cs b/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA2CheckerTest.cs
@@ -40,7 +40,11 @@ source product.
 For more information, please contact iText Software Corp. at this
 address: sales@itextpdf.com
 */
+using System;
+using System.Collections.Generic;
 using iText.Kernel.Pdf;
+using iText.Kernel.Pdf.Colorspace;
+using iText.Kernel.Pdf.Function;
 using iText.Pdfa;
 using iText.Test;
 
@@ -277,6 +281,30 @@ public virtual void CheckCatalogDictionaryWithoutRequirements() {
                 pdfA2Checker.CheckCatalogValidEntries(catalog);
             }
             , NUnit.Framework.Throws.InstanceOf<PdfAConformanceException>().With.Message.EqualTo(PdfAConformanceException.A_CATALOG_DICTIONARY_SHALL_NOT_CONTAIN_REQUIREMENTS_ENTRY))
+;
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceNoAttributesDictionary() {
+            NUnit.Framework.Assert.That(() =>  {
+                //TODO DEVSIX-4203 should not cause an IndexOutOfBoundException.
+                // Should throw PdfAConformanceException as Colorants dictionary always must be present
+                // for Pdf/A-2
+                int numberOfComponents = 2;
+                IList<String> tmpArray = new List<String>(numberOfComponents);
+                float[] transformArray = new float[numberOfComponents * 2];
+                for (int i = 0; i < numberOfComponents; i++) {
+                    tmpArray.Add("MyColor" + i + 1);
+                    transformArray[i * 2] = 0;
+                    transformArray[i * 2 + 1] = 1;
+                }
+                PdfFunction.Type4 function = new PdfFunction.Type4(new PdfArray(transformArray), new PdfArray(new float[] 
+                    { 0, 1, 0, 1, 0, 1 }), "{0}".GetBytes(iText.IO.Util.EncodingUtil.ISO_8859_1));
+                PdfDictionary currentColorSpaces = new PdfDictionary();
+                pdfA2Checker.CheckColorSpace(new PdfSpecialCs.DeviceN(tmpArray, new PdfDeviceCs.Rgb(), function), currentColorSpaces
+                    , true, false);
+            }
+            , NUnit.Framework.Throws.InstanceOf<Exception>())
 ;
         }
     }
diff --git a/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA2ImplementationLimitsCheckerTest.cs b/itext.tests/itext.pdfa.tests/itext/pdfa/checker/PdfA2ImplementationLimitsCheckerTest.cs
@@ -41,7 +41,10 @@ source product.
 address: sales@itextpdf.com
 */
 using System;
+using System.Collections.Generic;
 using iText.Kernel.Pdf;
+using iText.Kernel.Pdf.Colorspace;
+using iText.Kernel.Pdf.Function;
 using iText.Pdfa;
 using iText.Test;
 
@@ -119,5 +122,47 @@ public virtual void IndependentLargeRealTest() {
             , NUnit.Framework.Throws.InstanceOf<PdfAConformanceException>().With.Message.EqualTo(PdfAConformanceException.INTEGER_NUMBER_IS_OUT_OF_RANGE))
 ;
         }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWithMoreThan32Components() {
+            NUnit.Framework.Assert.That(() =>  {
+                CheckColorspace(BuildDeviceNColorspace(34));
+            }
+            , NUnit.Framework.Throws.InstanceOf<PdfAConformanceException>().With.Message.EqualTo(PdfAConformanceException.THE_NUMBER_OF_COLOR_COMPONENTS_IN_DEVICE_N_COLORSPACE_SHOULD_NOT_EXCEED))
+;
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWithLessThan32Components() {
+            CheckColorspace(BuildDeviceNColorspace(16));
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void DeviceNColorspaceWith32Components() {
+            CheckColorspace(BuildDeviceNColorspace(32));
+        }
+
+        private void CheckColorspace(PdfColorSpace colorSpace) {
+            PdfDictionary currentColorSpaces = new PdfDictionary();
+            pdfA2Checker.CheckColorSpace(colorSpace, currentColorSpaces, true, false);
+        }
+
+        private PdfColorSpace BuildDeviceNColorspace(int numberOfComponents) {
+            IList<String> tmpArray = new List<String>(numberOfComponents);
+            float[] transformArray = new float[numberOfComponents * 2];
+            for (int i = 0; i < numberOfComponents; i++) {
+                tmpArray.Add("MyColor" + i + 1);
+                transformArray[i * 2] = 0;
+                transformArray[i * 2 + 1] = 1;
+            }
+            PdfFunction.Type4 function = new PdfFunction.Type4(new PdfArray(transformArray), new PdfArray(new float[] 
+                { 0, 1, 0, 1, 0, 1 }), "{0}".GetBytes(iText.IO.Util.EncodingUtil.ISO_8859_1));
+            //TODO DEVSIX-4205 Replace with a constructor with 4 parameters or use a setter for attributes dictionary
+            PdfArray deviceNAsArray = ((PdfArray)(new PdfSpecialCs.DeviceN(tmpArray, new PdfDeviceCs.Rgb(), function))
+                .GetPdfObject());
+            PdfDictionary attributes = new PdfDictionary();
+            deviceNAsArray.Add(attributes);
+            return new PdfSpecialCs.DeviceN(deviceNAsArray);
+        }
     }
 }
diff --git a/itext/itext.kernel/itext/kernel/pdf/colorspace/PdfColorSpace.cs b/itext/itext.kernel/itext/kernel/pdf/colorspace/PdfColorSpace.cs
@@ -108,6 +108,7 @@ public static iText.Kernel.Pdf.Colorspace.PdfColorSpace MakeColorSpace(PdfObject
                                                     }
                                                     else {
                                                         if (PdfName.DeviceN.Equals(csType)) {
+                                                            //TODO DEVSIX-4205 Fix colorspace creation
                                                             return array.Size() == 4 ? new PdfSpecialCs.DeviceN(array) : new PdfSpecialCs.NChannel(array);
                                                         }
                                                         else {
diff --git a/itext/itext.pdfa/itext/pdfa/PdfAConformanceException.cs b/itext/itext.pdfa/itext/pdfa/PdfAConformanceException.cs
@@ -243,6 +243,8 @@ public const String THE_F_KEYS_PRINT_FLAG_BIT_SHALL_BE_SET_TO_1_AND_ITS_HIDDEN_I
 
         public const String THE_INTERACTIVE_FORM_DICTIONARY_SHALL_NOT_CONTAIN_THE_XFA_KEY = "The interactive form dictionary shall not contain the xfa key";
 
+        public const String THE_NUMBER_OF_COLOR_COMPONENTS_IN_DEVICE_N_COLORSPACE_SHOULD_NOT_EXCEED = "The number of color components in DeviceN colorspace should not exceed {0}";
+
         public const String THE_NUMBER_OF_COLOUR_CHANNELS_IN_THE_JPEG2000_DATA_SHALL_BE_1_3_OR_4 = "The number of colour channels in the jpeg2000 data shall be 1, 3 or 4";
 
         public const String THE_PAGE_DICTIONARY_SHALL_NOT_CONTAIN_AA_ENTRY = "The page dictionary shall not contain aa entry";
diff --git a/itext/itext.pdfa/itext/pdfa/checker/PdfA1Checker.cs b/itext/itext.pdfa/itext/pdfa/checker/PdfA1Checker.cs
@@ -90,6 +90,8 @@ public class PdfA1Checker : PdfAChecker {
         protected internal static readonly ICollection<PdfName> allowedRenderingIntents = new HashSet<PdfName>(JavaUtil.ArraysAsList
             (PdfName.RelativeColorimetric, PdfName.AbsoluteColorimetric, PdfName.Perceptual, PdfName.Saturation));
 
+        private const int MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS = 8;
+
         /// <summary>Creates a PdfA1Checker with the required conformance level</summary>
         /// <param name="conformanceLevel">
         /// the required conformance level, <c>a</c> or
@@ -154,7 +156,12 @@ public override void CheckColorSpace(PdfColorSpace colorSpace, PdfDictionary cur
             }
             else {
                 if (colorSpace is PdfSpecialCs.DeviceN) {
-                    colorSpace = ((PdfSpecialCs.DeviceN)colorSpace).GetBaseCs();
+                    PdfSpecialCs.DeviceN deviceNColorspace = (PdfSpecialCs.DeviceN)colorSpace;
+                    if (deviceNColorspace.GetNumberOfComponents() > MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS) {
+                        throw new PdfAConformanceException(PdfAConformanceException.THE_NUMBER_OF_COLOR_COMPONENTS_IN_DEVICE_N_COLORSPACE_SHOULD_NOT_EXCEED
+                            , MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS);
+                    }
+                    colorSpace = deviceNColorspace.GetBaseCs();
                 }
             }
             if (colorSpace is PdfDeviceCs.Rgb) {
diff --git a/itext/itext.pdfa/itext/pdfa/checker/PdfA2Checker.cs b/itext/itext.pdfa/itext/pdfa/checker/PdfA2Checker.cs
@@ -88,6 +88,8 @@ public class PdfA2Checker : PdfA1Checker {
 
         internal const int MIN_PAGE_SIZE = 3;
 
+        private const int MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS = 32;
+
         private bool currentFillCsIsIccBasedCMYK = false;
 
         private bool currentStrokeCsIsIccBasedCMYK = false;
@@ -146,7 +148,7 @@ public override void CheckColor(Color color, PdfDictionary currentColorSpaces, b
                     PdfObject colorSpace = shadingDictionary.Get(PdfName.ColorSpace);
                     CheckColorSpace(PdfColorSpace.MakeColorSpace(colorSpace), currentColorSpaces, true, true);
                     PdfDictionary extGStateDict = ((PdfDictionary)pattern.GetPdfObject()).GetAsDictionary(PdfName.ExtGState);
-                    CanvasGraphicsState gState = new _CanvasGraphicsState_164(extGStateDict);
+                    CanvasGraphicsState gState = new _CanvasGraphicsState_165(extGStateDict);
                     CheckExtGState(gState, contentStream);
                 }
                 else {
@@ -158,8 +160,8 @@ public override void CheckColor(Color color, PdfDictionary currentColorSpaces, b
             base.CheckColor(color, currentColorSpaces, fill, contentStream);
         }
 
-        private sealed class _CanvasGraphicsState_164 : CanvasGraphicsState {
-            public _CanvasGraphicsState_164(PdfDictionary extGStateDict) {
+        private sealed class _CanvasGraphicsState_165 : CanvasGraphicsState {
+            public _CanvasGraphicsState_165(PdfDictionary extGStateDict) {
                 this.extGStateDict = extGStateDict;
  {
                     this.UpdateFromExtGState(new PdfExtGState(extGStateDict));
@@ -189,8 +191,16 @@ public override void CheckColorSpace(PdfColorSpace colorSpace, PdfDictionary cur
             else {
                 if (colorSpace is PdfSpecialCs.DeviceN) {
                     PdfSpecialCs.DeviceN deviceN = (PdfSpecialCs.DeviceN)colorSpace;
+                    if (deviceN.GetNumberOfComponents() > MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS) {
+                        throw new PdfAConformanceException(PdfAConformanceException.THE_NUMBER_OF_COLOR_COMPONENTS_IN_DEVICE_N_COLORSPACE_SHOULD_NOT_EXCEED
+                            , MAX_NUMBER_OF_DEVICEN_COLOR_COMPONENTS);
+                    }
+                    //TODO DEVSIX-4203 Fix IndexOutOfBounds exception being thrown for DeviceN (not NChannel) colorspace without
+                    // attributes. According to the spec PdfAConformanceException should be thrown.
                     PdfDictionary attributes = ((PdfArray)deviceN.GetPdfObject()).GetAsDictionary(4);
                     PdfDictionary colorants = attributes.GetAsDictionary(PdfName.Colorants);
+                    //TODO DEVSIX-4203 Colorants dictionary is mandatory in PDF/A-2 spec. Need to throw an appropriate exception
+                    // if it is not present.
                     if (colorants != null) {
                         foreach (KeyValuePair<PdfName, PdfObject> entry in colorants.EntrySet()) {
                             PdfArray separation = (PdfArray)entry.Value;
diff --git a/port-hash b/port-hash
@@ -1 +1 @@
-cf313e7603fc7e749a4dba5d4cfd0ae04a280d92
+d6ef464670794641e575d3c84d24e7b79c0aa42e

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ public static iText.Kernel.Pdf.Colorspace.PdfColorSpace MakeColorSpace(PdfObject`
`108`	`108`	`}`
`109`	`109`	`else {`
`110`	`110`	`if (PdfName.DeviceN.Equals(csType)) {`
	`111`	`+ //TODO DEVSIX-4205 Fix colorspace creation`
`111`	`112`	`return array.Size() == 4 ? new PdfSpecialCs.DeviceN(array) : new PdfSpecialCs.NChannel(array);`
`112`	`113`	`}`
`113`	`114`	`else {`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-cf313e7603fc7e749a4dba5d4cfd0ae04a280d92`
	`1`	`+d6ef464670794641e575d3c84d24e7b79c0aa42e`