Skip to content

Commit 736d760

Browse files
committed
Fix NPE in collapse margin logic.
DEVSIX-1195 Autoported commit. Original commit hash: [6050baf43]
1 parent 196fdd0 commit 736d760

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

itext/itext.layout/itext/layout/margincollapse/MarginsCollapseHandler.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,9 @@ public virtual void EndMarginsCollapse(Rectangle layoutBox) {
225225
else {
226226
ownCollapseAfter = new MarginsCollapse();
227227
}
228-
ownCollapseAfter.JoinMargin(GetModelBottomMargin(renderer));
228+
if (ownCollapseAfter != null) {
229+
ownCollapseAfter.JoinMargin(GetModelBottomMargin(renderer));
230+
}
229231
collapseInfo.SetOwnCollapseAfter(ownCollapseAfter);
230232
if (collapseInfo.IsSelfCollapsing()) {
231233
if (prevChildMarginInfo != null) {
@@ -268,7 +270,8 @@ public virtual void EndMarginsCollapse(Rectangle layoutBox) {
268270
}
269271

270272
private void UpdateCollapseBeforeIfPrevKidIsFirstAndSelfCollapsed(MarginsCollapse collapseAfter) {
271-
if (prevChildMarginInfo.IsSelfCollapsing() && prevChildMarginInfo.IsIgnoreOwnMarginTop()) {
273+
if (prevChildMarginInfo.IsSelfCollapsing() && prevChildMarginInfo.IsIgnoreOwnMarginTop() && collapseAfter
274+
!= null) {
272275
// prevChildMarginInfo.isIgnoreOwnMarginTop() is true only if it's the first kid and is adjoined to parent margin
273276
collapseInfo.GetCollapseBefore().JoinMargin(collapseAfter);
274277
}

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
da5798b5cf162be5c1dd163f02f530299b6e46e3
1+
6050baf43726dc4ce3100fd436758dce7eaa63e2

0 commit comments

Comments
 (0)