If anchor delta is not zero, follow special xPlacement logic even if it's 0

DEVSIX-4472
DEVSIX-4473

Autoported commit.
Original commit hash: [d9124554d]

Author: ars18wrw

itext.tests/itext.io.tests/itext/io/font/otf/GlyphTest.cs

@@ -0,0 +1,53 @@
+/*
+This file is part of the iText (R) project.
+Copyright (c) 1998-2020 iText Group NV
+Authors: iText Software.
+
+This program is offered under a commercial and under the AGPL license.
+For commercial licensing, contact us at https://itextpdf.com/sales.  For AGPL licensing, see below.
+
+AGPL licensing:
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU Affero General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Affero General Public License for more details.
+
+You should have received a copy of the GNU Affero General Public License
+along with this program.  If not, see <https://www.gnu.org/licenses/>.
+*/
+using iText.Test;
+
+namespace iText.IO.Font.Otf {
+    public class GlyphTest : ExtendedITextTest {
+        [NUnit.Framework.Test]
+        public virtual void HasPlacementIfAnchorDeltaNonZeroTest() {
+            Glyph glyph = CreateDummyGlyph();
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetXPlacement());
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetYPlacement());
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetAnchorDelta());
+            NUnit.Framework.Assert.IsFalse(glyph.HasPlacement());
+            glyph.SetAnchorDelta((short)10);
+            NUnit.Framework.Assert.IsTrue(glyph.HasPlacement());
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void HasOffsetsIfAnchorDeltaNonZeroTest() {
+            Glyph glyph = CreateDummyGlyph();
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetXPlacement());
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetYPlacement());
+            NUnit.Framework.Assert.AreEqual(0, glyph.GetAnchorDelta());
+            NUnit.Framework.Assert.IsFalse(glyph.HasOffsets());
+            glyph.SetAnchorDelta((short)10);
+            NUnit.Framework.Assert.IsTrue(glyph.HasOffsets());
+        }
+
+        private static Glyph CreateDummyGlyph() {
+            return new Glyph(0, 0, 0);
+        }
+    }
+}

itext.tests/itext.kernel.tests/resources/itext/kernel/pdf/canvas/PdfCanvasGlyphlineShowTextTest/cmp_notoSerifWithInvalidXYPlacementAnchorDeltaTest.pdf

@@ -252,11 +252,12 @@ public virtual void SetAnchorDelta(short anchorDelta) {
         }
 
         public virtual bool HasOffsets() {
-            return xPlacement != 0 || yPlacement != 0 || xAdvance != 0 || yAdvance != 0;
+            return HasAdvance() || HasPlacement();
         }
 
+        // In case some of placement values are not zero we always expect anchorDelta to be non-zero
         public virtual bool HasPlacement() {
-            return xPlacement != 0 || yPlacement != 0;
+            return anchorDelta != 0;
         }
 
         public virtual bool HasAdvance() {

itext/itext.io/itext/io/font/otf/Glyph.cs

@@ -678,7 +678,8 @@ public virtual iText.Kernel.Pdf.Canvas.PdfCanvas ShowText(GlyphLine text, IEnume
                                 float xPlacementAddition = 0;
                                 int currentGlyphIndex = i;
                                 Glyph currentGlyph = text.Get(i);
-                                while (currentGlyph != null && currentGlyph.GetXPlacement() != 0) {
+                                // if xPlacement is not zero, anchorDelta is expected to be non-zero as well
+                                while (currentGlyph != null && (currentGlyph.GetAnchorDelta() != 0)) {
                                     xPlacementAddition += currentGlyph.GetXPlacement();
                                     if (currentGlyph.GetAnchorDelta() == 0) {
                                         break;

itext/itext.kernel/itext/kernel/pdf/canvas/PdfCanvas.cs

@@ -1 +1 @@
-0422805c51ffab04203f1d95e8ceb947396b92ab
+d9124554d47651e9e06599badc036bb2d359921e