Skip to content

Commit 918cc99

Browse files
yulian-gaponenkoiText-CI
yulian-gaponenko
authored and
iText-CI
committed
Rename #createDocument to #createDummyDocument in RendererUnitTest
DEVSIX-3958 Autoported commit. Original commit hash: [d3b399801]
1 parent c70cbbb commit 918cc99

File tree

4 files changed

+27
-54
lines changed

4 files changed

+27
-54
lines changed

‎itext.tests/itext.layout.tests/itext/layout/renderer/LineRendererUnitTest.cs

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,11 @@ source product.
4141
address: [email protected]
4242
*/
4343
using System.Collections.Generic;
44-
using System.IO;
4544
using iText.IO.Font.Constants;
4645
using iText.IO.Font.Otf;
4746
using iText.IO.Util;
4847
using iText.Kernel.Font;
4948
using iText.Kernel.Geom;
50-
using iText.Kernel.Pdf;
5149
using iText.Kernel.Pdf.Xobject;
5250
using iText.Layout;
5351
using iText.Layout.Borders;
@@ -62,7 +60,7 @@ public class LineRendererUnitTest : RendererUnitTest {
6260

6361
[NUnit.Framework.Test]
6462
public virtual void AdjustChildPositionsAfterReorderingSimpleTest01() {
65-
Document dummyDocument = CreateDocument();
63+
Document dummyDocument = CreateDummyDocument();
6664
IRenderer dummy1 = CreateLayoutedTextRenderer("Hello", dummyDocument);
6765
IRenderer dummy2 = CreateLayoutedTextRenderer("world", dummyDocument);
6866
IRenderer dummyImage = CreateLayoutedImageRenderer(100, 100, dummyDocument);
@@ -78,7 +76,7 @@ public virtual void AdjustChildPositionsAfterReorderingSimpleTest01() {
7876
[NUnit.Framework.Test]
7977
[LogMessage(iText.IO.LogMessageConstant.PROPERTY_IN_PERCENTS_NOT_SUPPORTED, Count = 4)]
8078
public virtual void AdjustChildPositionsAfterReorderingTestWithPercentMargins01() {
81-
Document dummyDocument = CreateDocument();
79+
Document dummyDocument = CreateDummyDocument();
8280
IRenderer dummy1 = CreateLayoutedTextRenderer("Hello", dummyDocument);
8381
dummy1.SetProperty(Property.MARGIN_LEFT, UnitValue.CreatePercentValue(10));
8482
dummy1.SetProperty(Property.MARGIN_RIGHT, UnitValue.CreatePercentValue(10));
@@ -95,7 +93,7 @@ public virtual void AdjustChildPositionsAfterReorderingTestWithPercentMargins01(
9593

9694
[NUnit.Framework.Test]
9795
public virtual void AdjustChildPositionsAfterReorderingTestWithFloats01() {
98-
Document dummyDocument = CreateDocument();
96+
Document dummyDocument = CreateDummyDocument();
9997
IRenderer dummy1 = CreateLayoutedTextRenderer("Hello", dummyDocument);
10098
IRenderer dummy2 = CreateLayoutedTextRenderer("world", dummyDocument);
10199
IRenderer dummyImage = CreateLayoutedImageRenderer(100, 100, dummyDocument);
@@ -113,7 +111,7 @@ public virtual void AdjustChildPositionsAfterReorderingTestWithFloats01() {
113111
[NUnit.Framework.Test]
114112
[LogMessage(iText.IO.LogMessageConstant.INLINE_BLOCK_ELEMENT_WILL_BE_CLIPPED)]
115113
public virtual void InlineBlockWithBigMinWidth01() {
116-
Document dummyDocument = CreateDocument();
114+
Document dummyDocument = CreateDummyDocument();
117115
LineRenderer lineRenderer = (LineRenderer)new LineRenderer().SetParent(dummyDocument.GetRenderer());
118116
Div div = new Div().SetMinWidth(2000).SetHeight(100);
119117
DivRenderer inlineBlockRenderer = (DivRenderer)div.CreateRendererSubTree();
@@ -127,7 +125,7 @@ public virtual void InlineBlockWithBigMinWidth01() {
127125

128126
[NUnit.Framework.Test]
129127
public virtual void AdjustChildrenYLineTextChildHtmlModeTest() {
130-
Document document = CreateDocument();
128+
Document document = CreateDummyDocument();
131129
LineRenderer lineRenderer = new LineRenderer();
132130
lineRenderer.SetParent(document.GetRenderer());
133131
lineRenderer.occupiedArea = new LayoutArea(1, new Rectangle(100, 100, 200, 200));
@@ -145,7 +143,7 @@ public virtual void AdjustChildrenYLineTextChildHtmlModeTest() {
145143

146144
[NUnit.Framework.Test]
147145
public virtual void AdjustChildrenYLineImageChildHtmlModeTest() {
148-
Document document = CreateDocument();
146+
Document document = CreateDummyDocument();
149147
LineRenderer lineRenderer = new LineRenderer();
150148
lineRenderer.SetParent(document.GetRenderer());
151149
lineRenderer.occupiedArea = new LayoutArea(1, new Rectangle(50, 50, 200, 200));
@@ -191,7 +189,7 @@ public virtual void HasChildRendererInHtmlModeNoChildrenTest() {
191189

192190
[NUnit.Framework.Test]
193191
public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndNoChildrenTest() {
194-
Document document = CreateDocument();
192+
Document document = CreateDummyDocument();
195193
LineRenderer lineRenderer = new LineRenderer();
196194
lineRenderer.SetParent(document.GetRenderer());
197195
lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
@@ -203,7 +201,7 @@ public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndNoChildrenTest(
203201

204202
[NUnit.Framework.Test]
205203
public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildrenInDefaultModeTest() {
206-
Document document = CreateDocument();
204+
Document document = CreateDummyDocument();
207205
LineRenderer lineRenderer = new LineRenderer();
208206
lineRenderer.SetParent(document.GetRenderer());
209207
lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
@@ -221,7 +219,7 @@ public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildrenInDefau
221219

222220
[NUnit.Framework.Test]
223221
public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlModeTest() {
224-
Document document = CreateDocument();
222+
Document document = CreateDummyDocument();
225223
LineRenderer lineRenderer = new LineRenderer();
226224
lineRenderer.SetParent(document.GetRenderer());
227225
lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
@@ -239,7 +237,7 @@ public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlMode
239237
[NUnit.Framework.Test]
240238
public virtual void LineRendererLayoutInHtmlModeWithLineHeightPropertyNotSet() {
241239
LineRenderer lineRenderer = new LineRenderer();
242-
lineRenderer.SetParent(CreateDocument().GetRenderer());
240+
lineRenderer.SetParent(CreateDummyDocument().GetRenderer());
243241
lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
244242
// Set fonts with different ascent/descent to line and text
245243
lineRenderer.SetProperty(Property.FONT, PdfFontFactory.CreateFont(StandardFonts.HELVETICA));
@@ -258,8 +256,6 @@ public virtual void LineRendererLayoutInHtmlModeWithLineHeightPropertyNotSet() {
258256

259257
[NUnit.Framework.Test]
260258
public virtual void MinMaxWidthEqualsActualMarginsBordersPaddings() {
261-
PdfDocument pdfDocument = new PdfDocument(new PdfWriter(new MemoryStream()));
262-
Document document = new Document(pdfDocument);
263259
Text ranText = new Text("ran");
264260
ranText.SetProperty(Property.MARGIN_LEFT, new UnitValue(UnitValue.POINT, 8f));
265261
ranText.SetProperty(Property.MARGIN_RIGHT, new UnitValue(UnitValue.POINT, 10f));
@@ -274,7 +270,7 @@ public virtual void MinMaxWidthEqualsActualMarginsBordersPaddings() {
274270
TextRenderer dom = new TextRenderer(domText);
275271
LayoutArea layoutArea = new LayoutArea(1, new Rectangle(AbstractRenderer.INF, AbstractRenderer.INF));
276272
LineRenderer lineRenderer = new LineRenderer();
277-
lineRenderer.SetParent(document.GetRenderer());
273+
lineRenderer.SetParent(CreateDummyDocument().GetRenderer());
278274
lineRenderer.AddChild(ran);
279275
lineRenderer.AddChild(dom);
280276
float countedMinWidth = lineRenderer.GetMinMaxWidth().GetMinWidth();
@@ -284,7 +280,7 @@ public virtual void MinMaxWidthEqualsActualMarginsBordersPaddings() {
284280

285281
[NUnit.Framework.Test]
286282
public virtual void SplitLineIntoGlyphsSimpleTest() {
287-
Document dummyDocument = CreateDocument();
283+
Document dummyDocument = CreateDummyDocument();
288284
TextRenderer dummy1 = CreateLayoutedTextRenderer("hello", dummyDocument);
289285
TextRenderer dummy2 = CreateLayoutedTextRenderer("world", dummyDocument);
290286
TextRenderer dummy3 = CreateLayoutedTextRenderer("!!!", dummyDocument);
@@ -317,7 +313,7 @@ public virtual void SplitLineIntoGlyphsSimpleTest() {
317313

318314
[NUnit.Framework.Test]
319315
public virtual void SplitLineIntoGlyphsWithLineBreakTest() {
320-
Document dummyDocument = CreateDocument();
316+
Document dummyDocument = CreateDummyDocument();
321317
TextRenderer dummy1 = CreateLayoutedTextRenderer("hello", dummyDocument);
322318
TextRenderer dummy2 = CreateLayoutedTextRenderer("world", dummyDocument);
323319
dummy2.line.Set(2, new Glyph('\n', 0, '\n'));
@@ -349,7 +345,7 @@ public virtual void SplitLineIntoGlyphsWithLineBreakTest() {
349345

350346
[NUnit.Framework.Test]
351347
public virtual void ReorderSimpleTest() {
352-
Document dummyDocument = CreateDocument();
348+
Document dummyDocument = CreateDummyDocument();
353349
IRenderer dummy1 = CreateLayoutedTextRenderer("hello", dummyDocument);
354350
IRenderer dummy2 = CreateLayoutedTextRenderer("world", dummyDocument);
355351
IRenderer dummy3 = CreateLayoutedTextRenderer("!!!", dummyDocument);

‎itext.tests/itext.layout.tests/itext/layout/renderer/RendererUnitTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ source product.
5353
namespace iText.Layout.Renderer {
5454
public abstract class RendererUnitTest : ExtendedITextTest {
5555
// This also can be converted to a @Rule to have it all at hand in the future
56-
protected internal static Document CreateDocument() {
56+
protected internal static Document CreateDummyDocument() {
5757
return new Document(new PdfDocument(new PdfWriter(new ByteArrayOutputStream())));
5858
}
5959

‎itext.tests/itext.layout.tests/itext/layout/renderer/TextRendererTest.cs

Lines changed: 11 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public virtual void SetFontAsText() {
172172

173173
[NUnit.Framework.Test]
174174
public virtual void GetDescentTest() {
175-
Document doc = CreateDocument();
175+
Document doc = CreateDummyDocument();
176176
TextRenderer textRenderer = CreateLayoutedTextRenderer("hello", doc);
177177
textRenderer.SetProperty(Property.PADDING_TOP, UnitValue.CreatePointValue(20f));
178178
textRenderer.SetProperty(Property.MARGIN_TOP, UnitValue.CreatePointValue(20f));
@@ -181,7 +181,7 @@ public virtual void GetDescentTest() {
181181

182182
[NUnit.Framework.Test]
183183
public virtual void GetOccupiedAreaBBoxTest() {
184-
Document doc = CreateDocument();
184+
Document doc = CreateDummyDocument();
185185
TextRenderer textRenderer = CreateLayoutedTextRenderer("hello", doc);
186186
textRenderer.SetProperty(Property.PADDING_TOP, UnitValue.CreatePointValue(20f));
187187
textRenderer.SetProperty(Property.MARGIN_TOP, UnitValue.CreatePointValue(20f));
@@ -193,7 +193,7 @@ public virtual void GetOccupiedAreaBBoxTest() {
193193

194194
[NUnit.Framework.Test]
195195
public virtual void GetInnerAreaBBoxTest() {
196-
Document doc = CreateDocument();
196+
Document doc = CreateDummyDocument();
197197
TextRenderer textRenderer = CreateLayoutedTextRenderer("hello", doc);
198198
textRenderer.SetProperty(Property.PADDING_TOP, UnitValue.CreatePointValue(20f));
199199
textRenderer.SetProperty(Property.MARGIN_TOP, UnitValue.CreatePointValue(20f));
@@ -252,29 +252,22 @@ public virtual void CyrillicCharacterDoesntBelongToSpecificScripts() {
252252

253253
[NUnit.Framework.Test]
254254
public virtual void OverflowWrapAnywhereProperty() {
255-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
256-
pdfDoc.AddNewPage();
257-
Document doc = new Document(pdfDoc);
258-
RootRenderer documentRenderer = doc.GetRenderer();
259255
Text text = new Text("wow");
260256
text.SetProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
261257
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
262-
textRenderer.SetParent(documentRenderer);
258+
textRenderer.SetParent(CreateDummyDocument().GetRenderer());
263259
MinMaxWidth minMaxWidth = textRenderer.GetMinMaxWidth();
264260
NUnit.Framework.Assert.IsTrue(minMaxWidth.GetMinWidth() < minMaxWidth.GetMaxWidth());
265261
}
266262

267263
[NUnit.Framework.Test]
268264
public virtual void OverflowWrapBreakWordProperty() {
269-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
270-
pdfDoc.AddNewPage();
271-
Document doc = new Document(pdfDoc);
272-
RootRenderer documentRenderer = doc.GetRenderer();
273265
Text text = new Text("wooow");
274266
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
275-
textRenderer.SetParent(documentRenderer);
267+
RootRenderer parentRenderer = CreateDummyDocument().GetRenderer();
268+
textRenderer.SetParent(parentRenderer);
276269
// overflow is set here to mock LineRenderer#layout behavior
277-
documentRenderer.SetProperty(Property.OVERFLOW_X, OverflowPropertyValue.VISIBLE);
270+
parentRenderer.SetProperty(Property.OVERFLOW_X, OverflowPropertyValue.VISIBLE);
278271
float fullWordWidth = textRenderer.GetMinMaxWidth().GetMaxWidth();
279272
LayoutArea layoutArea = new LayoutArea(1, new Rectangle(fullWordWidth / 2, AbstractRenderer.INF));
280273
TextLayoutResult result = (TextLayoutResult)textRenderer.Layout(new LayoutContext(layoutArea));
@@ -286,14 +279,10 @@ public virtual void OverflowWrapBreakWordProperty() {
286279

287280
[NUnit.Framework.Test]
288281
public virtual void OverflowWrapAnywhereBoldSimulationMaxWidth() {
289-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
290-
pdfDoc.AddNewPage();
291-
Document doc = new Document(pdfDoc);
292-
RootRenderer documentRenderer = doc.GetRenderer();
293282
Text text = new Text("wow");
294283
text.SetBold();
295284
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
296-
textRenderer.SetParent(documentRenderer);
285+
textRenderer.SetParent(CreateDummyDocument().GetRenderer());
297286
float maxWidthNoOverflowWrap = textRenderer.GetMinMaxWidth().GetMaxWidth();
298287
text.SetProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
299288
float maxWidthAndOverflowWrap = textRenderer.GetMinMaxWidth().GetMaxWidth();
@@ -302,14 +291,10 @@ public virtual void OverflowWrapAnywhereBoldSimulationMaxWidth() {
302291

303292
[NUnit.Framework.Test]
304293
public virtual void OverflowWrapAnywhereItalicSimulationMaxWidth() {
305-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
306-
pdfDoc.AddNewPage();
307-
Document doc = new Document(pdfDoc);
308-
RootRenderer documentRenderer = doc.GetRenderer();
309294
Text text = new Text("wow");
310295
text.SetItalic();
311296
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
312-
textRenderer.SetParent(documentRenderer);
297+
textRenderer.SetParent(CreateDummyDocument().GetRenderer());
313298
float maxWidthNoOverflowWrap = textRenderer.GetMinMaxWidth().GetMaxWidth();
314299
text.SetProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
315300
float maxWidthAndOverflowWrap = textRenderer.GetMinMaxWidth().GetMaxWidth();
@@ -318,14 +303,10 @@ public virtual void OverflowWrapAnywhereItalicSimulationMaxWidth() {
318303

319304
[NUnit.Framework.Test]
320305
public virtual void OverflowWrapAnywhereBoldSimulationMinWidth() {
321-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
322-
pdfDoc.AddNewPage();
323-
Document doc = new Document(pdfDoc);
324-
RootRenderer documentRenderer = doc.GetRenderer();
325306
Text text = new Text("wow");
326307
text.SetProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
327308
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
328-
textRenderer.SetParent(documentRenderer);
309+
textRenderer.SetParent(CreateDummyDocument().GetRenderer());
329310
float minWidthNoBoldSimulation = textRenderer.GetMinMaxWidth().GetMinWidth();
330311
text.SetBold();
331312
float minWidthAndBoldSimulation = textRenderer.GetMinMaxWidth().GetMinWidth();
@@ -334,14 +315,10 @@ public virtual void OverflowWrapAnywhereBoldSimulationMinWidth() {
334315

335316
[NUnit.Framework.Test]
336317
public virtual void OverflowWrapAnywhereItalicSimulationMinWidth() {
337-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
338-
pdfDoc.AddNewPage();
339-
Document doc = new Document(pdfDoc);
340-
RootRenderer documentRenderer = doc.GetRenderer();
341318
Text text = new Text("wow");
342319
text.SetProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
343320
TextRenderer textRenderer = (TextRenderer)text.GetRenderer();
344-
textRenderer.SetParent(documentRenderer);
321+
textRenderer.SetParent(CreateDummyDocument().GetRenderer());
345322
float minWidthNoItalicSimulation = textRenderer.GetMinMaxWidth().GetMinWidth();
346323
text.SetItalic();
347324
float minWidthAndItalicSimulation = textRenderer.GetMinMaxWidth().GetMinWidth();

‎port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
147f3f6e1532b9dc5244ec8156c5e4c75a191e08
1+
d3b3998013941ca7d12e5e1596f03edd9cbd2a5f

0 commit comments

Comments
 (0)