Review checked exceptions softening in layout module

Autoported commit.
Original commit hash: [8d67c4213]
Manual files:
layout/findbugs-filter.xml
layout/src/main/java/com/itextpdf/layout/hyphenation/PatternParser.java

Author: yulian-gaponenko

itext/itext.layout/itext/layout/font/FontProvider.cs

@@ -412,6 +412,15 @@ public virtual PdfFont GetPdfFont(FontInfo fontInfo, FontSet tempFonts) {
                     pdfFont = PdfFontFactory.CreateFont(fontProgram, encoding, GetDefaultEmbeddingFlag());
                 }
                 catch (System.IO.IOException e) {
+                    // Converting checked exceptions to unchecked RuntimeException (java-specific comment).
+                    //
+                    // FontProvider is usually used in highlevel API, which requests fonts in deep underlying logic.
+                    // IOException would mean that font is chosen and it is supposed to exist, however it cannot be read.
+                    // Using fallbacks in such situations would make FontProvider less intuitive.
+                    //
+                    // Even though softening of checked exceptions can be handled at higher levels in order to let
+                    // the caller of this method know that font creation failed, we prefer to avoid bloating highlevel API
+                    // and avoid making higher level code depend on low-level code because of the exceptions handling.
                     throw new PdfException(PdfException.IoExceptionWhileCreatingFont, e);
                 }
                 pdfFonts.Put(fontInfo, pdfFont);

itext/itext.layout/itext/layout/renderer/TypographyUtils.cs

@@ -289,6 +289,15 @@ private static Object CallMethod(String className, String methodName, Object tar
                     , e.Message));
             }
             catch (Exception e) {
+                // Converting checked exceptions to unchecked RuntimeException (java-specific comment).
+                //
+                // If typography utils throws an exception at this point, we consider it as unrecoverable situation for
+                // its callers (layouting methods). Presence of typography module in class path is checked before.
+                // It's might be more suitable to wrap checked exceptions at a bit higher level, but we do it here for
+                // the sake of convenience.
+                //
+                // The RuntimeException exception is used instead of, for example, PdfException, because failure here is
+                // unexpected and is not connected to PDF documents processing.
                 throw new Exception(e.ToString(), e);
             }
             return null;
@@ -306,6 +315,15 @@ private static Object CallConstructor(String className, Type[] parameterTypes, p
                 logger.Warn(MessageFormatUtil.Format("Cannot find class {0}", className));
             }
             catch (Exception exc) {
+                // Converting checked exceptions to unchecked RuntimeException (java-specific comment).
+                //
+                // If typography utils throws an exception at this point, we consider it as unrecoverable situation for
+                // its callers (layouting methods). Presence of typography module in class path is checked before.
+                // It's might be more suitable to wrap checked exceptions at a bit higher level, but we do it here for
+                // the sake of convenience.
+                //
+                // The RuntimeException exception is used instead of, for example, PdfException, because failure here is
+                // unexpected and is not connected to PDF documents processing.
                 throw new Exception(exc.ToString(), exc);
             }
             return null;

port-hash

@@ -1 +1 @@
-5fc41659adec32a84946e832bd2ac17e9defb31c
+8d67c42138b14653256da2f84970f355bc5c20a1