Refactor log messages with non-initialized occupied area

The message has been changed to a generic one and explanations are
added in-place whenever needed

DEVSIX-1381

Autoported commit.
Original commit hash: [9eb8df0ae]

Author: Snipx

itext/itext.io/itext/io/LogMessageConstant.cs

@@ -126,7 +126,7 @@ public sealed class LogMessageConstant {
 
         public const String POPUP_ENTRY_IS_NOT_POPUP_ANNOTATION = "Popup entry in the markup annotations refers not to the annotation with Popup subtype.";
 
-        public const String OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED = "Occupied area hasn't been initialized. Drawing won't be performed";
+        public const String OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED = "Occupied area has not been initialized. {0}";
 
         public const String OCSP_STATUS_IS_REVOKED = "OCSP status is revoked.";
 

itext/itext.layout/itext/layout/renderer/AbstractRenderer.cs

@@ -1060,7 +1060,8 @@ protected internal virtual void AlignChildHorizontally(IRenderer childRenderer,
                 }
                 catch (ArgumentNullException) {
                     ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.AbstractRenderer));
-                    logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                    logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Some of the children might not end up aligned horizontally."
+                        ));
                 }
             }
         }

itext/itext.layout/itext/layout/renderer/BlockRenderer.cs

@@ -449,7 +449,8 @@ protected internal virtual AbstractRenderer CreateOverflowRenderer(int layoutRes
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.BlockRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             PdfDocument document = drawContext.GetDocument();

itext/itext.layout/itext/layout/renderer/ImageRenderer.cs

@@ -255,7 +255,8 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.ImageRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             ApplyMargins(occupiedArea.GetBBox(), false);

itext/itext.layout/itext/layout/renderer/LinkRenderer.cs

@@ -76,7 +76,8 @@ public LinkRenderer(Link linkElement, String text)
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.LinkRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             base.Draw(drawContext);

itext/itext.layout/itext/layout/renderer/ListItemRenderer.cs

@@ -92,7 +92,8 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.ListItemRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             bool isTagged = drawContext.IsTaggingEnabled() && GetModelElement() is IAccessibleElement;

itext/itext.layout/itext/layout/renderer/TabRenderer.cs

@@ -41,6 +41,7 @@ source product.
 For more information, please contact iText Software Corp. at this
 address: [email protected]
 */
+using System;
 using iText.IO.Log;
 using iText.Kernel.Geom;
 using iText.Kernel.Pdf.Canvas;
@@ -73,7 +74,8 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.TabRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             ILineDrawer leader = this.GetProperty<ILineDrawer>(Property.TAB_LEADER);

itext/itext.layout/itext/layout/renderer/TextRenderer.cs

@@ -516,7 +516,8 @@ public virtual void ApplyOtf() {
         public override void Draw(DrawContext drawContext) {
             if (occupiedArea == null) {
                 ILogger logger = LoggerFactory.GetLogger(typeof(iText.Layout.Renderer.TextRenderer));
-                logger.Error(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.Error(String.Format(iText.IO.LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."
+                    ));
                 return;
             }
             // Set up marked content before super.draw so that annotations are placed within marked content
@@ -647,7 +648,7 @@ public override void Draw(DrawContext drawContext) {
                 if (horizontalScaling != null && horizontalScaling != 1) {
                     canvas.SetHorizontalScaling((float)horizontalScaling * 100);
                 }
-                GlyphLine.IGlyphLineFilter filter = new _IGlyphLineFilter_682();
+                GlyphLine.IGlyphLineFilter filter = new _IGlyphLineFilter_683();
                 bool appearanceStreamLayout = true.Equals(GetPropertyAsBoolean(Property.APPEARANCE_STREAM_LAYOUT));
                 if (GetReversedRanges() != null) {
                     bool writeReversedChars = !appearanceStreamLayout;
@@ -711,8 +712,8 @@ public override void Draw(DrawContext drawContext) {
             }
         }
 
-        private sealed class _IGlyphLineFilter_682 : GlyphLine.IGlyphLineFilter {
-            public _IGlyphLineFilter_682() {
+        private sealed class _IGlyphLineFilter_683 : GlyphLine.IGlyphLineFilter {
+            public _IGlyphLineFilter_683() {
             }
 
             public bool Accept(Glyph glyph) {

port-hash

@@ -1 +1 @@
-1dfb78f8b8cc2378676c51546a852c0d87ee3075
+9eb8df0ae7a39a045bb73755f965a691197ba838