Add html mode check for LineRenderer childs

DEVSIX-3837

Autoported commit.
Original commit hash: [42962d3e7]

Author: ar3em

itext.tests/itext.layout.tests/itext/layout/renderer/LineRendererUnitTest.cs

@@ -153,5 +153,80 @@ public virtual void AdjustChildrenYLineImageChildHtmlModeTest() {
             NUnit.Framework.Assert.AreEqual(50f, lineRenderer.GetOccupiedAreaBBox().GetBottom(), EPS);
             NUnit.Framework.Assert.AreEqual(150.0, childImageRenderer.GetOccupiedAreaBBox().GetBottom(), EPS);
         }
+
+        [NUnit.Framework.Test]
+        public virtual void HasChildRendererInHtmlModeTest() {
+            LineRenderer lineRenderer = new LineRenderer();
+            TextRenderer textRenderer1 = new TextRenderer(new Text("text1"));
+            TextRenderer textRenderer2 = new TextRenderer(new Text("text2"));
+            textRenderer2.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            lineRenderer.AddChild(textRenderer1);
+            lineRenderer.AddChild(textRenderer2);
+            NUnit.Framework.Assert.IsTrue(lineRenderer.HasChildRendererInHtmlMode());
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void ChildRendererInDefaultModeTest() {
+            LineRenderer lineRenderer = new LineRenderer();
+            TextRenderer textRenderer1 = new TextRenderer(new Text("text1"));
+            TextRenderer textRenderer2 = new TextRenderer(new Text("text2"));
+            textRenderer2.SetProperty(Property.RENDERING_MODE, RenderingMode.DEFAULT_LAYOUT_MODE);
+            lineRenderer.AddChild(textRenderer1);
+            lineRenderer.AddChild(textRenderer2);
+            NUnit.Framework.Assert.IsFalse(lineRenderer.HasChildRendererInHtmlMode());
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void HasChildRendererInHtmlModeNoChildrenTest() {
+            LineRenderer lineRenderer = new LineRenderer();
+            NUnit.Framework.Assert.IsFalse(lineRenderer.HasChildRendererInHtmlMode());
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndNoChildrenTest() {
+            Document document = CreateDocument();
+            LineRenderer lineRenderer = new LineRenderer();
+            lineRenderer.SetParent(document.GetRenderer());
+            lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            lineRenderer.SetProperty(Property.LINE_HEIGHT, LineHeight.CreateNormalValue());
+            lineRenderer.Layout(new LayoutContext(CreateLayoutArea(1000, 1000)));
+            NUnit.Framework.Assert.AreEqual(0f, lineRenderer.maxAscent, 0f);
+            NUnit.Framework.Assert.AreEqual(0f, lineRenderer.maxDescent, 0f);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildrenInDefaultModeTest() {
+            Document document = CreateDocument();
+            LineRenderer lineRenderer = new LineRenderer();
+            lineRenderer.SetParent(document.GetRenderer());
+            lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            lineRenderer.SetProperty(Property.LINE_HEIGHT, LineHeight.CreateFixedValue(50));
+            TextRenderer textRenderer1 = new TextRenderer(new Text("text"));
+            textRenderer1.SetProperty(Property.RENDERING_MODE, RenderingMode.DEFAULT_LAYOUT_MODE);
+            TextRenderer textRenderer2 = new TextRenderer(new Text("text"));
+            textRenderer2.SetProperty(Property.RENDERING_MODE, RenderingMode.DEFAULT_LAYOUT_MODE);
+            lineRenderer.AddChild(textRenderer1);
+            lineRenderer.AddChild(textRenderer2);
+            lineRenderer.Layout(new LayoutContext(CreateLayoutArea(1000, 1000)));
+            NUnit.Framework.Assert.AreEqual(10.3392f, lineRenderer.maxAscent, EPS);
+            NUnit.Framework.Assert.AreEqual(-2.98079f, lineRenderer.maxDescent, EPS);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlModeTest() {
+            Document document = CreateDocument();
+            LineRenderer lineRenderer = new LineRenderer();
+            lineRenderer.SetParent(document.GetRenderer());
+            lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            lineRenderer.SetProperty(Property.LINE_HEIGHT, LineHeight.CreateFixedValue(50));
+            TextRenderer textRenderer1 = new TextRenderer(new Text("text"));
+            textRenderer1.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            TextRenderer textRenderer2 = new TextRenderer(new Text("text"));
+            lineRenderer.AddChild(textRenderer1);
+            lineRenderer.AddChild(textRenderer2);
+            lineRenderer.Layout(new LayoutContext(CreateLayoutArea(1000, 1000)));
+            NUnit.Framework.Assert.AreEqual(28.67920f, lineRenderer.maxAscent, EPS);
+            NUnit.Framework.Assert.AreEqual(-21.32080f, lineRenderer.maxDescent, EPS);
+        }
     }
 }

itext/itext.layout/itext/layout/renderer/LineRenderer.cs

@@ -99,9 +99,10 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
             }
             occupiedArea = new LayoutArea(layoutContext.GetArea().GetPageNumber(), layoutBox.Clone().MoveUp(layoutBox.
                 GetHeight()).SetHeight(0).SetWidth(0));
+            UpdateChildrenParent();
             float curWidth = 0;
             if (RenderingMode.HTML_MODE.Equals(this.GetProperty<RenderingMode?>(Property.RENDERING_MODE)) && HasProperty
-                (Property.LINE_HEIGHT)) {
+                (Property.LINE_HEIGHT) && HasChildRendererInHtmlMode()) {
                 float[] ascenderDescender = LineHeightHelper.GetActualAscenderDescender(this);
                 maxAscent = ascenderDescender[0];
                 maxDescent = ascenderDescender[1];
@@ -123,7 +124,6 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
             else {
                 widthHandler = new MaxSumWidthHandler(minMaxWidth);
             }
-            UpdateChildrenParent();
             ResolveChildrenFonts();
             int totalNumberOfTrimmedGlyphs = TrimFirst();
             BaseDirection? baseDirection = ApplyOtf();
@@ -919,6 +919,15 @@ public override MinMaxWidth GetMinMaxWidth() {
             return result.GetMinMaxWidth();
         }
 
+        internal virtual bool HasChildRendererInHtmlMode() {
+            foreach (IRenderer childRenderer in childRenderers) {
+                if (RenderingMode.HTML_MODE.Equals(childRenderer.GetProperty<RenderingMode?>(Property.RENDERING_MODE))) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
         internal virtual float GetTopLeadingIndent(Leading leading) {
             switch (leading.GetLeadingType()) {
                 case Leading.FIXED: {

port-hash

@@ -1 +1 @@
-9946d7d113c033e1df6c213230c42ff7ad140c5d
+42962d3e7cb76c51101448397741cc467b1d4d2f