Resolve TODOs in CssPageRule and MediaExpression

DEVSIX-6348

Autoported commit.
Original commit hash: [ffc141d09]

Author: Evgeniy Prudnikov

itext.tests/itext.styledxmlparser.tests/itext/styledxmlparser/css/parse/CssStyleSheetParserTest.cs

@@ -139,8 +139,7 @@ public virtual void Test10() {
 
         [NUnit.Framework.Test]
         public virtual void Test11() {
-            // TODO in this test declarations of the page at-rule with compound selector are duplicated.
-            // See CssPageRule#addBodyCssDeclarations() method for the reason and possible solution if this becomes important.
+            // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
             String cssFile = sourceFolder + "css11.css";
             String cmpFile = sourceFolder + "cmp_css11.css";
             CssStyleSheet styleSheet = CssStyleSheetParser.Parse(new FileStream(cssFile, FileMode.Open, FileAccess.Read

itext/itext.styledxmlparser/itext/styledxmlparser/css/media/MediaExpression.cs

@@ -241,7 +241,8 @@ public virtual bool Matches(MediaDeviceDescription deviceDescription) {
         /// </returns>
         private static float ParseAbsoluteLength(String value) {
             if (CssTypesValidationUtils.IsRelativeValue(value)) {
-                // TODO here should be used default font size of the browser, it probably should be fetched from the more generic place than private class constant
+                // TODO Use some shared default value (from default.css or CssDefaults)
+                //      rather than a constant of this class
                 return CssDimensionParsingUtils.ParseRelativeValue(value, DEFAULT_FONT_SIZE);
             }
             else {

itext/itext.styledxmlparser/itext/styledxmlparser/css/page/CssMarginRule.cs

@@ -68,6 +68,7 @@ public CssMarginRule(String ruleName)
         * @see com.itextpdf.styledxmlparser.css.CssNestedAtRule#addBodyCssDeclarations(java.util.List)
         */
         public override void AddBodyCssDeclarations(IList<CssDeclaration> cssDeclarations) {
+            // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
             foreach (ICssSelector pageSelector in pageSelectors) {
                 this.body.Add(new CssNonStandardRuleSet(new CssPageMarginBoxSelector(GetRuleName(), pageSelector), cssDeclarations
                     ));

itext/itext.styledxmlparser/itext/styledxmlparser/css/page/CssPageRule.cs

@@ -77,16 +77,17 @@ public CssPageRule(String ruleParameters)
         * @see com.itextpdf.styledxmlparser.css.CssNestedAtRule#addBodyCssDeclarations(java.util.List)
         */
         public override void AddBodyCssDeclarations(IList<CssDeclaration> cssDeclarations) {
-            // TODO Due to this for-loop, on toString method call for the CssPageRule instance
+            // TODO DEVSIX-6364 Fix the body declarations duplication for each pageSelector part
+            //      Due to this for-loop, on toString method call for the CssPageRule instance
             //      all the body declarations will be duplicated for each pageSelector part.
             //      This potentially could lead to a nasty behaviour when declarations will double
-            //      for each read-write iteration of the same css-file (however, this use case seems 
-            //      to be unlikely to happen). 
-            //      Possible solution would be to split single page rule with compound selector into 
+            //      for each read-write iteration of the same css-file (however, this use case seems
+            //      to be unlikely to happen).
+            //      Possible solution would be to split single page rule with compound selector into
             //      several page rules with simple selectors on addition of the page rule to it's parent.
             //
             //      Also, the same concerns this method implementation in CssMarginRule class.
-            //      
+            //
             //      See CssStyleSheetParserTest#test11 test.
             foreach (ICssSelector pageSelector in pageSelectors) {
                 this.body.Add(new CssNonStandardRuleSet(pageSelector, cssDeclarations));

port-hash

@@ -1 +1 @@
-4575c74eaf100c0151ee203e9eac8aa2fa794de5
+ffc141d097ec67efe16fc83fbf565125712f9da4