Wrap negative offsets in datamatrix

Add tests for IndexOutOfBounds
Update width&height samples in javadocs.

DEVSIX-1845

Autoported commit.
Original commit hash: [963e9369a]

Author: pavel-alay

itext.tests/itext.barcodes.tests/itext/barcodes/BarcodeDataMatrixTest.cs

@@ -186,5 +186,32 @@ public virtual void Barcode07Test() {
             int result = bc.SetCode(aCode);
             NUnit.Framework.Assert.AreEqual(result, BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG);
         }
+
+        [NUnit.Framework.Test]
+        public virtual void Barcode08Test() {
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(18);
+            barcodeDataMatrix.SetHeight(18);
+            int result = barcodeDataMatrix.SetCode("AbcdFFghijklmnopqrstuWXSQ");
+            NUnit.Framework.Assert.AreEqual(BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG, result);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void Barcode09Test() {
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(17);
+            barcodeDataMatrix.SetHeight(17);
+            int result = barcodeDataMatrix.SetCode("AbcdFFghijklmnopqrstuWXSQ");
+            NUnit.Framework.Assert.AreEqual(BarcodeDataMatrix.DM_ERROR_INVALID_SQUARE, result);
+        }
+
+        [NUnit.Framework.Test]
+        public virtual void Barcode10Test() {
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(26);
+            barcodeDataMatrix.SetHeight(12);
+            int result = barcodeDataMatrix.SetCode("AbcdFFghijklmnopqrstuWXSQ");
+            NUnit.Framework.Assert.AreEqual(BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG, result);
+        }
     }
 }

itext/itext.barcodes/itext/barcodes/BarcodeDataMatrix.cs

@@ -333,23 +333,24 @@ public virtual int GetHeight() {
 
         /// <summary>Sets the height of the barcode.</summary>
         /// <remarks>
-        /// Sets the height of the barcode. If the height is zero it will be calculated. This height doesn't include the whitespace border, if any.
-        /// The allowed dimensions are (height, width):<p>
+        /// Sets the height of the barcode. If the height is zero it will be calculated.
+        /// This height doesn't include the whitespace border, if any.
+        /// The allowed dimensions are (width, height):<p>
         /// 10, 10<br />
         /// 12, 12<br />
-        /// 8, 18<br />
+        /// 18, 8<br />
         /// 14, 14<br />
-        /// 8, 32<br />
+        /// 32, 8<br />
         /// 16, 16<br />
-        /// 12, 26<br />
+        /// 26, 12<br />
         /// 18, 18<br />
         /// 20, 20<br />
-        /// 12, 36<br />
+        /// 36, 12<br />
         /// 22, 22<br />
-        /// 16, 36<br />
+        /// 36, 16<br />
         /// 24, 24<br />
         /// 26, 26<br />
-        /// 16, 48<br />
+        /// 48, 16<br />
         /// 32, 32<br />
         /// 36, 36<br />
         /// 40, 40<br />
@@ -383,23 +384,24 @@ public virtual int GetWidth() {
 
         /// <summary>Sets the width of the barcode.</summary>
         /// <remarks>
-        /// Sets the width of the barcode. If the width is zero it will be calculated. This width doesn't include the whitespace border, if any.
-        /// The allowed dimensions are (height, width):<p>
+        /// Sets the width of the barcode. If the width is zero it will be calculated.
+        /// This width doesn't include the whitespace border, if any.
+        /// The allowed dimensions are (width, height):<p>
         /// 10, 10<br />
         /// 12, 12<br />
-        /// 8, 18<br />
+        /// 18, 8<br />
         /// 14, 14<br />
-        /// 8, 32<br />
+        /// 32, 8<br />
         /// 16, 16<br />
-        /// 12, 26<br />
+        /// 26, 12<br />
         /// 18, 18<br />
         /// 20, 20<br />
-        /// 12, 36<br />
+        /// 36, 12<br />
         /// 22, 22<br />
-        /// 16, 36<br />
+        /// 36, 16<br />
         /// 24, 24<br />
         /// 26, 26<br />
-        /// 16, 48<br />
+        /// 48, 16<br />
         /// 32, 32<br />
         /// 36, 36<br />
         /// 40, 40<br />
@@ -1117,7 +1119,7 @@ private int C40OrTextEncodation(byte[] text, int textOffset, int textLength, byt
                                 dataOffsetNew = requiredCapacityForASCII;
                             }
                         }
-                        addLatch = unlatch < 0 ? true : (dataOffset - requiredCapacityForASCII != unlatch);
+                        addLatch = (unlatch < 0) || ((dataOffset - requiredCapacityForASCII) != unlatch);
                         if (requiredCapacityForC40orText % 3 == 0 && requiredCapacityForC40orText / 3 * 2 + (addLatch ? 2 : 0) < requiredCapacityForASCII
                             ) {
                             usingASCII = false;
@@ -1138,17 +1140,15 @@ private int C40OrTextEncodation(byte[] text, int textOffset, int textLength, byt
                     usingASCII = true;
                 }
             }
+            if (dataOffset < 0) {
+                return -1;
+            }
             if (usingASCII) {
                 return AsciiEncodation(text, textOffset, 1, data, dataOffset, dataLength, prevEnc == mode ? 1 : -1, DM_ASCII
                     , origDataOffset);
             }
             if (addLatch) {
-                if (c40) {
-                    data[dataOffset + ptrOut++] = LATCH_C40;
-                }
-                else {
-                    data[dataOffset + ptrOut++] = LATCH_TEXT;
-                }
+                data[dataOffset + ptrOut++] = c40 ? LATCH_C40 : LATCH_TEXT;
             }
             int[] enc = new int[textLength * 4 + 10];
             encPtr = 0;

port-hash

@@ -1 +1 @@
-81ee78e4b14d6a1bd6fcc7095e13252b80001b0c
+963e9369a70d97773f9dfa873b56d13e1dd5e411