Skip KEEP_TOGETHER in case of AreaBreak

DEVSIX-5156

Autoported commit.
Original commit hash: [6328d385a]

Author: ars18wrw

itext.tests/itext.layout.tests/itext/layout/KeepTogetherTest.cs

@@ -41,6 +41,7 @@ source product.
 address: [email protected]
 */
 using System;
+using System.IO;
 using System.Text;
 using iText.IO.Font.Constants;
 using iText.IO.Image;
@@ -100,6 +101,20 @@ public virtual void KeepTogetherParagraphTest01() {
                 "diff"));
         }
 
+        [NUnit.Framework.Test]
+        public virtual void SkipKeepTogetherInCaseOfAreaBreak() {
+            PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new MemoryStream()));
+            Document doc = new Document(pdfDoc);
+            Div keptTogetherDiv = new Div();
+            keptTogetherDiv.SetKeepTogether(true);
+            AreaBreak areaBreak = new AreaBreak();
+            keptTogetherDiv.Add(areaBreak);
+            doc.Add(keptTogetherDiv);
+            // If this line is not triggered, then an NPE occurred
+            NUnit.Framework.Assert.IsTrue(true);
+            doc.Close();
+        }
+
         [NUnit.Framework.Test]
         [LogMessage(iText.IO.LogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA)]
         public virtual void KeepTogetherParagraphTest02() {

itext/itext.layout/itext/layout/renderer/AbstractRenderer.cs

@@ -2099,7 +2099,11 @@ protected internal virtual bool IsAbsolutePosition() {
         }
 
         protected internal virtual bool IsKeepTogether() {
-            return true.Equals(GetPropertyAsBoolean(Property.KEEP_TOGETHER));
+            return IsKeepTogether(null);
+        }
+
+        internal virtual bool IsKeepTogether(IRenderer causeOfNothing) {
+            return true.Equals(GetPropertyAsBoolean(Property.KEEP_TOGETHER)) && !(causeOfNothing is AreaBreakRenderer);
         }
 
         // Note! The second parameter is here on purpose. Currently occupied area is passed as a value of this parameter in

itext/itext.layout/itext/layout/renderer/BlockRenderer.cs

@@ -155,7 +155,7 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
                     FloatingHelper.IncludeChildFloatsInOccupiedArea(floatRendererAreas, this, nonChildFloatingRendererAreas);
                     FixOccupiedAreaIfOverflowedX(overflowX, layoutBox);
                     result = new LayoutResult(LayoutResult.NOTHING, null, null, childRenderer);
-                    bool isKeepTogether = IsKeepTogether();
+                    bool isKeepTogether = IsKeepTogether(childRenderer);
                     int layoutResult = anythingPlaced && !isKeepTogether ? LayoutResult.PARTIAL : LayoutResult.NOTHING;
                     AbstractRenderer[] splitAndOverflowRenderers = CreateSplitAndOverflowRenderers(childPos, layoutResult, result
                         , waitingFloatsSplitRenderers, waitingOverflowFloatRenderers);
@@ -736,7 +736,7 @@ internal virtual LayoutResult ProcessNotFullChildResult(LayoutContext layoutCont
             }
             else {
                 if (result.GetStatus() == LayoutResult.NOTHING) {
-                    bool keepTogether = IsKeepTogether();
+                    bool keepTogether = IsKeepTogether(causeOfNothing);
                     int layoutResult = anythingPlaced && !keepTogether ? LayoutResult.PARTIAL : LayoutResult.NOTHING;
                     AbstractRenderer[] splitAndOverflowRenderers = CreateSplitAndOverflowRenderers(childPos, layoutResult, result
                         , waitingFloatsSplitRenderers, waitingOverflowFloatRenderers);

itext/itext.layout/itext/layout/renderer/FlexContainerRenderer.cs

@@ -175,7 +175,7 @@ internal override LayoutResult ProcessNotFullChildResult(LayoutContext layoutCon
             [] borders, UnitValue[] paddings, IList<Rectangle> areas, int currentAreaPos, Rectangle layoutBox, ICollection
             <Rectangle> nonChildFloatingRendererAreas, IRenderer causeOfNothing, bool anythingPlaced, int childPos
             , LayoutResult result) {
-            bool keepTogether = IsKeepTogether();
+            bool keepTogether = IsKeepTogether(causeOfNothing);
             AbstractRenderer[] splitAndOverflowRenderers = CreateSplitAndOverflowRenderers(childPos, result.GetStatus(
                 ), result, waitingFloatsSplitRenderers, waitingOverflowFloatRenderers);
             AbstractRenderer splitRenderer = splitAndOverflowRenderers[0];

itext/itext.layout/itext/layout/renderer/ParagraphRenderer.cs

@@ -279,7 +279,7 @@ protected internal virtual LayoutResult DirectLayout(LayoutContext layoutContext
                         firstLineInBox = true;
                     }
                     else {
-                        bool keepTogether = IsKeepTogether();
+                        bool keepTogether = IsKeepTogether(result.GetCauseOfNothing());
                         if (keepTogether) {
                             floatRendererAreas.RetainAll(nonChildFloatingRendererAreas);
                             return new MinMaxWidthLayoutResult(LayoutResult.NOTHING, null, null, this, null == result.GetCauseOfNothing

itext/itext.layout/itext/layout/renderer/TableRenderer.cs

@@ -887,8 +887,8 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
                             overflowRows.SetCell(row - splitResult[0].rows.Count, entry.Key, null);
                         }
                     }
-                    if ((IsKeepTogether() && 0 == lastFlushedRowBottomBorder.Count) && !true.Equals(GetPropertyAsBoolean(Property
-                        .FORCED_PLACEMENT))) {
+                    if (IsKeepTogether(firstCauseOfNothing) && 0 == lastFlushedRowBottomBorder.Count && !true.Equals(GetPropertyAsBoolean
+                        (Property.FORCED_PLACEMENT))) {
                         return new LayoutResult(LayoutResult.NOTHING, null, null, this, null == firstCauseOfNothing ? this : firstCauseOfNothing
                             );
                     }

port-hash

@@ -1 +1 @@
-504a9a8cf451797fa1aa8ff775cf7ecb09012c41
+6328d385a64fd46355e1bbccdf94b8fb394d849a