Get rid of exception in the AbstractContextBasedITextEvent#setMetaInfo

DEVSIX-5887

Autoported commit.
Original commit hash: [6c1b6135d]

Author: ar3em

itext.tests/itext.commons.tests/itext/commons/actions/AbstractContextBasedITextEventTest.cs

@@ -20,11 +20,9 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 You should have received a copy of the GNU Affero General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-using System;
 using iText.Commons.Actions.Contexts;
 using iText.Commons.Actions.Data;
 using iText.Commons.Ecosystem;
-using iText.Commons.Exceptions;
 using iText.Test;
 
 namespace iText.Commons.Actions {
@@ -45,10 +43,7 @@ public virtual void ResetMetaInfoForbiddenTest() {
             AbstractContextBasedITextEventTest.BasicAbstractContextBasedITextEvent e = new AbstractContextBasedITextEventTest.BasicAbstractContextBasedITextEvent
                 (CommonsProductData.GetInstance(), metaInfoBefore);
             NUnit.Framework.Assert.AreSame(metaInfoBefore, e.GetMetaInfo());
-            Exception exception = NUnit.Framework.Assert.Catch(typeof(InvalidOperationException), () => e.SetMetaInfo(
-                metaInfoAfter));
-            NUnit.Framework.Assert.AreEqual(CommonsExceptionMessageConstant.META_INFO_SHOULDNT_BE_NULL, exception.Message
-                );
+            NUnit.Framework.Assert.IsFalse(e.SetMetaInfo(metaInfoAfter));
         }
 
         private class BasicAbstractContextBasedITextEvent : AbstractContextBasedITextEvent {

itext/itext.commons/itext/commons/actions/AbstractContextBasedITextEvent.cs

@@ -23,7 +23,6 @@ You should have received a copy of the GNU Affero General Public License
 using System;
 using iText.Commons.Actions.Contexts;
 using iText.Commons.Actions.Data;
-using iText.Commons.Exceptions;
 
 namespace iText.Commons.Actions {
     /// <summary>Represents a context-based event.</summary>
@@ -51,11 +50,13 @@ public virtual Type GetClassFromContext() {
 
         /// <summary>Sets meta info.</summary>
         /// <param name="metaInfo">meta info</param>
-        public virtual void SetMetaInfo(IMetaInfo metaInfo) {
+        /// <returns>true if meta info has been set, false otherwise</returns>
+        public virtual bool SetMetaInfo(IMetaInfo metaInfo) {
             if (this.metaInfo != null) {
-                throw new InvalidOperationException(CommonsExceptionMessageConstant.META_INFO_SHOULDNT_BE_NULL);
+                return false;
             }
             this.metaInfo = metaInfo;
+            return true;
         }
 
         /// <summary>Obtains stored meta info associated with the event.</summary>

itext/itext.commons/itext/commons/exceptions/CommonsExceptionMessageConstant.cs

@@ -43,8 +43,6 @@ public sealed class CommonsExceptionMessageConstant {
 
         public const String INVALID_USAGE_FORMAT_REQUIRED = "Invalid usage of placeholder \"{0}\": format is required";
 
-        public const String META_INFO_SHOULDNT_BE_NULL = "Meta info shouldn't be null";
-
         public const String NO_EVENTS_WERE_REGISTERED_FOR_THE_DOCUMENT = "No events were registered for the document!";
 
         public const String PATTERN_CONTAINS_OPEN_QUOTATION = "Pattern contains open quotation!";

port-hash

@@ -1 +1 @@
-7309ce8ca4c7782f482d4c4cf2b68a82fc305745
+6c1b6135d55c607dd1098c733cc1a3b300d5cc96