Skip to content

Commit ec066b5

Browse files
BezrukovMiText-CI
authored andcommitted
Add tests for PdfDocument with missing, null and not PdfString producer
DEVSIX-5084 Autoported commit. Original commit hash: [1a88e77a3]
1 parent 8104aac commit ec066b5

File tree

6 files changed

+51
-2
lines changed

6 files changed

+51
-2
lines changed

itext.tests/itext.kernel.tests/itext/kernel/pdf/PdfDocumentTest.cs

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,55 @@ public static void BeforeClass() {
6969
CreateOrClearDestinationFolder(DESTINATION_FOLDER);
7070
}
7171

72+
[NUnit.Framework.Test]
73+
public virtual void MissingProducerTest() {
74+
String inputFile = SOURCE_FOLDER + "missingProducer.pdf";
75+
using (PdfDocument document = new PdfDocument(new PdfReader(inputFile))) {
76+
PdfDocumentInfo documentInfo = document.GetDocumentInfo();
77+
NUnit.Framework.Assert.IsNull(documentInfo.GetPdfObject().Get(PdfName.Producer));
78+
NUnit.Framework.Assert.IsNull(documentInfo.GetProducer());
79+
}
80+
using (PdfDocument document_1 = new PdfDocument(new PdfReader(inputFile), new PdfWriter(new MemoryStream()
81+
))) {
82+
PdfDocumentInfo documentInfo = document_1.GetDocumentInfo();
83+
NUnit.Framework.Assert.IsNotNull(documentInfo.GetPdfObject().Get(PdfName.Producer));
84+
NUnit.Framework.Assert.IsNotNull(document_1.GetDocumentInfo().GetProducer());
85+
}
86+
}
87+
88+
[NUnit.Framework.Test]
89+
public virtual void NullProducerTest() {
90+
String inputFile = SOURCE_FOLDER + "nullProducer.pdf";
91+
using (PdfDocument document = new PdfDocument(new PdfReader(inputFile))) {
92+
PdfDocumentInfo documentInfo = document.GetDocumentInfo();
93+
NUnit.Framework.Assert.AreEqual(PdfNull.PDF_NULL, documentInfo.GetPdfObject().Get(PdfName.Producer));
94+
NUnit.Framework.Assert.IsNull(documentInfo.GetProducer());
95+
}
96+
using (PdfDocument document_1 = new PdfDocument(new PdfReader(inputFile), new PdfWriter(new MemoryStream()
97+
))) {
98+
PdfDocumentInfo documentInfo = document_1.GetDocumentInfo();
99+
NUnit.Framework.Assert.IsNotNull(documentInfo.GetPdfObject().Get(PdfName.Producer));
100+
NUnit.Framework.Assert.IsNotNull(document_1.GetDocumentInfo().GetProducer());
101+
}
102+
}
103+
104+
[NUnit.Framework.Test]
105+
public virtual void NameProducerTest() {
106+
String inputFile = SOURCE_FOLDER + "nameProducer.pdf";
107+
using (PdfDocument document = new PdfDocument(new PdfReader(inputFile))) {
108+
PdfDocumentInfo documentInfo = document.GetDocumentInfo();
109+
NUnit.Framework.Assert.AreEqual(new PdfName("producerAsName"), documentInfo.GetPdfObject().Get(PdfName.Producer
110+
));
111+
NUnit.Framework.Assert.IsNull(documentInfo.GetProducer());
112+
}
113+
using (PdfDocument document_1 = new PdfDocument(new PdfReader(inputFile), new PdfWriter(new MemoryStream()
114+
))) {
115+
PdfDocumentInfo documentInfo = document_1.GetDocumentInfo();
116+
NUnit.Framework.Assert.IsNotNull(documentInfo.GetPdfObject().Get(PdfName.Producer));
117+
NUnit.Framework.Assert.IsNotNull(document_1.GetDocumentInfo().GetProducer());
118+
}
119+
}
120+
72121
[NUnit.Framework.Test]
73122
public virtual void WritingVersionTest01() {
74123
// There is a possibility to override version in stamping mode

itext/itext.kernel/itext/kernel/pdf/PdfDocument.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2272,7 +2272,7 @@ private void UpdateProducerInInfoDictionary() {
22722272
else {
22732273
if (info.GetPdfObject().ContainsKey(PdfName.Producer)) {
22742274
PdfString producerPdfStr = info.GetPdfObject().GetAsString(PdfName.Producer);
2275-
producer = producerPdfStr != null ? producerPdfStr.ToUnicodeString() : null;
2275+
producer = producerPdfStr == null ? null : producerPdfStr.ToUnicodeString();
22762276
}
22772277
producer = AddModifiedPostfix(producer);
22782278
}

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
090af8f2c31512fb80c559ee5dd60c15ee97fc28
1+
1a88e77a3ad86d8caa576b20ef41863b293f6403

0 commit comments

Comments
 (0)