Fix unit tests failing with changed locale minus.

The behaviour was broken when the locale negative sign was changed
from '-' to other characters. This change updates behaviour so
that it passes those tests which were failing.

Author: Evileye

itext/itext.io/itext/io/font/CidFont.cs

@@ -112,24 +112,18 @@ private void InitializeCidFontNameAndStyle(String fontName) {
 
         private void InitializeCidFontProperties(IDictionary<String, Object> fontDesc) {
             fontIdentification.SetPanose((String)fontDesc.Get("Panose"));
-            fontMetrics.SetItalicAngle(Convert.ToInt32((String)fontDesc.Get("ItalicAngle"), System.Globalization.CultureInfo.InvariantCulture
-                ));
-            fontMetrics.SetCapHeight(Convert.ToInt32((String)fontDesc.Get("CapHeight"), System.Globalization.CultureInfo.InvariantCulture
-                ));
-            fontMetrics.SetTypoAscender(Convert.ToInt32((String)fontDesc.Get("Ascent"), System.Globalization.CultureInfo.InvariantCulture
-                ));
-            fontMetrics.SetTypoDescender(Convert.ToInt32((String)fontDesc.Get("Descent"), System.Globalization.CultureInfo.InvariantCulture
-                ));
-            fontMetrics.SetStemV(Convert.ToInt32((String)fontDesc.Get("StemV"), System.Globalization.CultureInfo.InvariantCulture
-                ));
-            pdfFontFlags = Convert.ToInt32((String)fontDesc.Get("Flags"), System.Globalization.CultureInfo.InvariantCulture
-                );
+            fontMetrics.SetItalicAngle(Convert.ToInt32((String)fontDesc.Get("ItalicAngle")));
+            fontMetrics.SetCapHeight(Convert.ToInt32((String)fontDesc.Get("CapHeight")));
+            fontMetrics.SetTypoAscender(Convert.ToInt32((String)fontDesc.Get("Ascent")));
+            fontMetrics.SetTypoDescender(Convert.ToInt32((String)fontDesc.Get("Descent")));
+            fontMetrics.SetStemV(Convert.ToInt32((String)fontDesc.Get("StemV")));
+            pdfFontFlags = Convert.ToInt32((String)fontDesc.Get("Flags"));
             String fontBBox = (String)fontDesc.Get("FontBBox");
             StringTokenizer tk = new StringTokenizer(fontBBox, " []\r\n\t\f");
-            int llx = Convert.ToInt32(tk.NextToken(), System.Globalization.CultureInfo.InvariantCulture);
-            int lly = Convert.ToInt32(tk.NextToken(), System.Globalization.CultureInfo.InvariantCulture);
-            int urx = Convert.ToInt32(tk.NextToken(), System.Globalization.CultureInfo.InvariantCulture);
-            int ury = Convert.ToInt32(tk.NextToken(), System.Globalization.CultureInfo.InvariantCulture);
+            int llx = Convert.ToInt32(tk.NextToken());
+            int lly = Convert.ToInt32(tk.NextToken());
+            int urx = Convert.ToInt32(tk.NextToken());
+            int ury = Convert.ToInt32(tk.NextToken());
             fontMetrics.UpdateBbox(llx, lly, urx, ury);
             registry = (String)fontDesc.Get("Registry");
             String uniMap = GetCompatibleUniMap(registry);

itext/itext.io/itext/io/font/Pfm2afm.cs

@@ -99,7 +99,7 @@ private String ReadString() {
 
         private void Outval(int n) {
             output.Write(' ');
-            output.Write(n);
+            output.Write(n.ToString(System.Globalization.CultureInfo.InvariantCulture));
         }
 
         /*

itext/itext.io/itext/io/font/Type1Font.cs

@@ -405,10 +405,10 @@ protected internal virtual void Process() {
                         }
 
                         case "B": {
-                            B = new int[] { Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture), Convert.ToInt32
-                                (tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture), Convert.ToInt32(tokc.NextToken(
-                                ), System.Globalization.CultureInfo.InvariantCulture), Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture
-                                ) };
+                            B = new int[] { Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture),
+                                Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture),
+                                Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture),
+                                Convert.ToInt32(tokc.NextToken(), System.Globalization.CultureInfo.InvariantCulture) };
                             break;
                         }
                     }

itext/itext.styledxmlparser/itext/styledxmlparser/css/selector/item/CssPseudoClassNthSelectorItem.cs

@@ -98,8 +98,7 @@ protected internal virtual void GetNthArguments() {
                             }
                             String bParticle = arguments.Substring(indexOfN + 1).Trim();
                             if (!String.IsNullOrEmpty(bParticle)) {
-                                this.nthB = Convert.ToInt32(bParticle[0] + bParticle.Substring(1).Trim(), System.Globalization.CultureInfo.InvariantCulture
-                                    );
+                                this.nthB = Convert.ToInt32(bParticle[0] + bParticle.Substring(1).Trim(), System.Globalization.CultureInfo.InvariantCulture);
                             }
                             else {
                                 this.nthB = 0;

itext/itext.styledxmlparser/itext/styledxmlparser/jsoup/select/QueryParser.cs

@@ -466,8 +466,7 @@ private void CssNthChild(bool backwards, bool ofType) {
                     else {
                         if (mB.Success) {
                             a = 0;
-                            b = Convert.ToInt32(iText.IO.Util.StringUtil.Group(mB).ReplaceFirst("^\\+", ""), System.Globalization.CultureInfo.InvariantCulture
-                                );
+                            b = Convert.ToInt32(iText.IO.Util.StringUtil.Group(mB).ReplaceFirst("^\\+", ""), System.Globalization.CultureInfo.InvariantCulture);
                         }
                         else {
                             throw new Selector.SelectorParseException("Could not parse nth-index " + PortUtil.EscapedSingleBracket + "{0}"