Stop reusing xref object nrs & edit tests to fit

DEVSIX-1428

Autoported commit.
Original commit hash: [e029f7c14]

Author: Benoit Lagae

itext.tests/itext.kernel.tests/itext/kernel/pdf/PdfPagesTest.cs

@@ -162,7 +162,7 @@ public virtual void RandomObjectPagesTest() {
             PdfPage testPage = document.RemovePage(1000);
             NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference() == null);
             document.AddPage(1000, testPage);
-            NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference().GetObjNumber() < xrefSize);
+            NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference().GetObjNumber() == xrefSize);
             for (int i = 0; i < pages.Length; i++) {
                 NUnit.Framework.Assert.AreEqual(true, document.RemovePage(pages[i]), "Remove page");
                 document.AddPage(i + 1, pages[i]);

itext.tests/itext.kernel.tests/itext/kernel/pdf/PdfReaderTest.cs

@@ -315,7 +315,7 @@ public virtual void PagesTest01() {
             PdfPage testPage = document.RemovePage(1000);
             NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference() == null);
             document.AddPage(1000, testPage);
-            NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference().GetObjNumber() < xrefSize);
+            NUnit.Framework.Assert.IsTrue(testPage.GetPdfObject().GetIndirectReference().GetObjNumber() == xrefSize);
             for (int i = 1; i < document.GetNumberOfPages() + 1; i++) {
                 PdfPage page = document.GetPage(i);
                 String content = iText.IO.Util.JavaUtil.GetStringForBytes(page.GetContentStream(0).GetBytes());

itext/itext.kernel/itext/kernel/pdf/PdfXrefTable.cs

@@ -103,21 +103,8 @@ public virtual PdfIndirectReference Get(int index) {
         /// <summary>Creates next available indirect reference.</summary>
         /// <returns>created indirect reference.</returns>
         protected internal virtual PdfIndirectReference CreateNextIndirectReference(PdfDocument document) {
-            PdfIndirectReference reference;
-            if (freeReferences.Count > 0) {
-                int num = (int)freeReferences.PollFirst();
-                reference = xref[num];
-                if (reference == null) {
-                    reference = new PdfIndirectReference(document, num);
-                    xref[num] = reference;
-                }
-                reference.SetOffset(0);
-                reference.ClearState(PdfObject.FREE);
-            }
-            else {
-                reference = new PdfIndirectReference(document, ++count);
-                Add(reference);
-            }
+            PdfIndirectReference reference = new PdfIndirectReference(document, ++count);
+            Add(reference);
             return ((PdfIndirectReference)reference.SetState(PdfObject.MODIFIED));
         }
 

port-hash

@@ -1 +1 @@
-a3e57f271528164aa1f9ef737a1095287c4d3e13
+e029f7c146b1cdabda9d177dac98a423d5d770cb