Fix issue with shartTag in reusable Type 3 font.

DEVSIX-1468

Author: pavel-alay

kernel/src/main/java/com/itextpdf/kernel/font/PdfType3Font.java

@@ -130,9 +130,13 @@ public class PdfType3Font extends PdfSimpleFont<Type3Font> {
         } else {
             fontProgram.getFontMetrics().setBbox(0, 0, 0, 0);
         }
-        PdfNumber firstCharNumber = fontDictionary.getAsNumber(PdfName.FirstChar);
-        int firstChar = firstCharNumber != null ? Math.max(firstCharNumber.intValue(), 0) : 0;
+        int firstChar = normalizeFirstLastChar(fontDictionary.getAsNumber(PdfName.FirstChar), 0);
+        int lastChar = normalizeFirstLastChar(fontDictionary.getAsNumber(PdfName.LastChar), 255);
+        for (int i = firstChar; i <= lastChar; i++) {
+            shortTag[i] = 1;
+        }
         int[] widths = FontUtil.convertSimpleWidthsArray(fontDictionary.getAsArray(PdfName.Widths), firstChar, 0);
+
         double[] fontMatrix = new double[6];
         for (int i = 0; i < fontMatrixArray.size(); i++) {
             fontMatrix[i] = ((PdfNumber) fontMatrixArray.get(i)).getValue();
@@ -177,7 +181,7 @@ public void setFontWeight(int fontWeight) {
     }
 
     /**
-     * Sets the PostScript italic angel.
+     * Sets the PostScript italic angle.
      * <br/>
      * Italic angle in counter-clockwise degrees from the vertical. Zero for upright text, negative for text that leans to the right (forward).
      *
@@ -370,7 +374,6 @@ protected PdfDocument getDocument() {
         return getPdfObject().getIndirectReference().getDocument();
     }
 
-
     /**
      * Gets first empty code, that could use with {@see addSymbol()}
      *
@@ -386,7 +389,6 @@ private int getFirstEmptyCode() {
         return -1;
     }
 
-
     private void fillFontDescriptor(PdfDictionary fontDesc) {
         if (fontDesc == null) {
             return;
@@ -415,4 +417,10 @@ private void fillFontDescriptor(PdfDictionary fontDesc) {
             setFontFamily(fontFamily.getValue());
         }
     }
+
+    private int normalizeFirstLastChar(PdfNumber firstLast, int defaultValue) {
+        if (firstLast == null) return defaultValue;
+        int result = firstLast.intValue();
+        return result < 0 || result > 255 ? defaultValue : result;
+    }
 }

layout/src/test/java/com/itextpdf/layout/FontProviderTest.java

@@ -92,5 +92,4 @@ public void standardAndType3Fonts() throws Exception {
 
         Assert.assertNull(new CompareTool().compareByContent(outFileName, cmpFileName, destinationFolder, "diff"));
     }
-
 }