Duplicated entries in the AcroForm /Fields array

DEVSIX-460

Author: pavel-morozov-duallab

forms/src/main/java/com/itextpdf/forms/PdfAcroForm.java

@@ -762,7 +762,7 @@ protected PdfArray getFields() {
 
     @Override
     protected boolean isWrappedObjectMustBeIndirect() {
-        return true;
+        return false;
     }
 
     private Map<String, PdfFormField> iterateFields(PdfArray array) {

forms/src/main/java/com/itextpdf/forms/PdfPageFormCopier.java

@@ -96,7 +96,7 @@ public void copy(PdfPage fromPage, PdfPage toPage) {
 
     private PdfFormField mergeFieldsWithTheSameName(PdfFormField existingField, PdfFormField newField) {
         PdfFormField mergedField = PdfFormField.createEmptyField(documentTo);
-        formTo.removeField(existingField.getFieldName().toUnicodeString());
+        formTo.getFields().remove(newField.getPdfObject());
         mergedField.
                 put(PdfName.FT, existingField.getFormType()).
                 put(PdfName.T, existingField.getFieldName()).

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -571,6 +571,9 @@ public static PdfButtonFormField createCheckBox(PdfDocument doc, Rectangle rect,
         check.setFieldName(name);
         check.setValue(value);
         annot.setAppearanceState(new PdfName(value));
+        if (value.equals("Off")) {
+            value = "Yes";
+        }
         check.drawCheckAppearance(rect.getWidth(), rect.getHeight(), value);
 
         return (PdfButtonFormField) check;

forms/src/test/java/com/itextpdf/forms/PdfFormCopyTest.java

@@ -36,7 +36,6 @@ static public void beforeClass() {
     @LogMessages(messages = {
             @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 13)
     })
-    @Ignore("Merging forms with the same name: widget annotation of old field is removed")
     public void copyFieldsTest01() throws IOException, InterruptedException {
         String srcFilename1 = sourceFolder + "appearances1.pdf";
         String srcFilename2 = sourceFolder + "fieldsOn2-sPage.pdf";