Remove default appearance from AcroForm.

DEVSIX-1677

Author: pavel-alay

forms/src/main/java/com/itextpdf/forms/PdfAcroForm.java

@@ -52,7 +52,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfBoolean;
 import com.itextpdf.kernel.pdf.PdfDictionary;
 import com.itextpdf.kernel.pdf.PdfDocument;
-import com.itextpdf.kernel.pdf.PdfIndirectReference;
 import com.itextpdf.kernel.pdf.PdfName;
 import com.itextpdf.kernel.pdf.PdfNumber;
 import com.itextpdf.kernel.pdf.PdfObject;
@@ -65,6 +64,8 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.tagutils.TagReference;
 import com.itextpdf.kernel.pdf.tagutils.TagTreePointer;
 import com.itextpdf.kernel.pdf.xobject.PdfFormXObject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -74,9 +75,6 @@ This file is part of the iText (R) project.
 import java.util.Map;
 import java.util.Set;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 /**
  * This class represents the static form technology AcroForm on a PDF file.
  */
@@ -129,7 +127,6 @@ public class PdfAcroForm extends PdfObjectWrapper<PdfDictionary> {
      */
     protected PdfDocument document;
 
-    Logger logger = LoggerFactory.getLogger(PdfAcroForm.class);
     private static PdfName[] resourceNames = {PdfName.Font, PdfName.XObject, PdfName.ColorSpace, PdfName.Pattern};
     private PdfDictionary defaultResources;
     private Set<PdfFormField> fieldsForFlattening = new LinkedHashSet<>();
@@ -178,7 +175,6 @@ public static PdfAcroForm getAcroForm(PdfDocument document, boolean createIfNotE
                 acroForm.makeIndirect(document);
                 document.getCatalog().put(PdfName.AcroForm, acroForm.getPdfObject());
                 document.getCatalog().setModified();
-                acroForm.setDefaultAppearance("/Helv 0 Tf 0 g ");
             }
         } else {
             acroForm = new PdfAcroForm(acroFormDictionary, document);
@@ -839,6 +835,7 @@ public void replaceField(String name, PdfFormField field) {
     protected PdfArray getFields() {
         PdfArray fields = getPdfObject().getAsArray(PdfName.Fields);
         if (fields == null) {
+            Logger logger = LoggerFactory.getLogger(PdfAcroForm.class);
             logger.warn(LogMessageConstant.NO_FIELDS_IN_ACROFORM);
             fields = new PdfArray();
             getPdfObject().put(PdfName.Fields, fields);
@@ -855,6 +852,7 @@ private Map<String, PdfFormField> iterateFields(PdfArray array, Map<String, PdfF
         int index = 1;
         for (PdfObject field : array) {
             if (field.isFlushed()) {
+                Logger logger = LoggerFactory.getLogger(PdfAcroForm.class);
                 logger.warn(LogMessageConstant.FORM_FIELD_WAS_FLUSHED);
                 continue;
             }

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -1497,7 +1497,7 @@ public PdfString getDefaultAppearance() {
                 }
             }
         }
-        //DA is an inherited key, therefore AcroForm shall be checked if there is no parent or no DA in parent.
+        // DA is an inherited key, therefore AcroForm shall be checked if there is no parent or no DA in parent.
         if (defaultAppearance == null) {
             defaultAppearance = (PdfString) getAcroFormKey(PdfName.DA, PdfObject.STRING);
         }
@@ -1522,6 +1522,7 @@ public PdfFormField setDefaultAppearance(String defaultAppearance) {
         return this;
     }
 
+
     /**
      * Gets a code specifying the form of quadding (justification) to be used in displaying the text:
      * 0 Left-justified