Regenerate appearance only by request.

DEVSIX-1568

Author: pavel-alay

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -1035,13 +1035,10 @@ public PdfFormField setValue(String value, boolean generateAppearance) {
             put(PdfName.V, new PdfString(value, PdfEncodings.UNICODE_BIG));
         }
 
-        if (PdfName.Btn.equals(formType) && (getFieldFlags() & PdfButtonFormField.FF_PUSH_BUTTON) == 0) {
-            if (generateAppearance) {
-                regenerateField();
-            }
-        } else {
+        if (generateAppearance) {
             regenerateField();
         }
+
         this.setModified();
         return this;
     }

forms/src/test/java/com/itextpdf/forms/PdfFormFieldTest.java

@@ -49,10 +49,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.io.LogMessageConstant;
 import com.itextpdf.io.source.ByteArrayOutputStream;
 import com.itextpdf.kernel.geom.Rectangle;
-import com.itextpdf.kernel.pdf.PdfDocument;
-import com.itextpdf.kernel.pdf.PdfPage;
-import com.itextpdf.kernel.pdf.PdfReader;
-import com.itextpdf.kernel.pdf.PdfWriter;
+import com.itextpdf.kernel.pdf.*;
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.LogMessage;
@@ -362,4 +359,24 @@ public void acroFieldDictionaryNoFields() throws IOException, InterruptedExcepti
             Assert.fail(errorMessage);
         }
     }
+
+    @Test
+    public void regenerateAppearance() throws IOException, InterruptedException {
+        String input = "regenerateAppearance.pdf";
+        String output = "regenerateAppearance.pdf";
+        PdfDocument document = new PdfDocument(new PdfReader(sourceFolder + input ),
+                new PdfWriter(destinationFolder + output),
+                new StampingProperties().useAppendMode());
+        PdfAcroForm acro = PdfAcroForm.getAcroForm(document, false);
+        int i = 1;
+        for (Map.Entry<String, PdfFormField> entry : acro.getFormFields().entrySet()) {
+            if (entry.getKey().contains("field")) {
+                PdfFormField field = entry.getValue();
+                field.setValue("test" + i++, false);
+            }
+        }
+        document.close();
+        Assert.assertNull(new CompareTool().compareByContent(destinationFolder + output,
+                sourceFolder + "cmp_" + output, destinationFolder, "diff"));
+    }
 }