Deprecate CSS redundant rule class constructors that are more flexible than CSS specification

DEVSIX-3321

Author: Snipx

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/CssFontFaceRule.java

@@ -55,11 +55,20 @@ public class CssFontFaceRule extends CssNestedAtRule {
      */
     private List<CssDeclaration> properties;
 
+    /**
+     * Instantiates a new CSS font face rule.
+     */
+    public CssFontFaceRule() {
+        this("");
+    }
+
     /**
      * Instantiates a new CSS font face rule.
      *
      * @param ruleParameters the rule parameters
+     * @deprecated Will be removed in 7.2. Use {@link #CssFontFaceRule()} instead
      */
+    @Deprecated
     public CssFontFaceRule(String ruleParameters) {
         super(CssRuleName.FONT_FACE, ruleParameters);
     }

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/CssNestedAtRuleFactory.java

@@ -90,9 +90,9 @@ public static CssNestedAtRule createNestedRule(String ruleDeclaration) {
             case CssRuleName.BOTTOM_CENTER:
             case CssRuleName.BOTTOM_RIGHT:
             case CssRuleName.BOTTOM_RIGHT_CORNER:
-                return new CssMarginRule(ruleName, ruleParameters);
+                return new CssMarginRule(ruleName);
             case CssRuleName.FONT_FACE:
-                return new CssFontFaceRule(ruleParameters);
+                return new CssFontFaceRule();
             default:
                 return new CssNestedAtRule(ruleName, ruleParameters);
         }

styled-xml-parser/src/main/java/com/itextpdf/styledxmlparser/css/page/CssMarginRule.java

@@ -58,12 +58,23 @@ public class CssMarginRule extends CssNestedAtRule {
     /** The page selectors. */
     private List<ICssSelector> pageSelectors;
 
+    /**
+     * Creates a new {@link CssMarginRule} instance.
+     *
+     * @param ruleName the rule name
+     */
+    public CssMarginRule(String ruleName) {
+        this(ruleName, "");
+    }
+
     /**
      * Creates a new {@link CssMarginRule} instance.
      *
      * @param ruleName the rule name
      * @param ruleParameters the rule parameters
+     * @deprecated Will be removed in 7.2. Use {@link #CssMarginRule(String)} instead
      */
+    @Deprecated
     public CssMarginRule(String ruleName, String ruleParameters) {
         super(ruleName, ruleParameters);
     }

styled-xml-parser/src/test/java/com/itextpdf/styledxmlparser/css/CssFontFaceRuleTest.java

@@ -14,7 +14,7 @@ public class CssFontFaceRuleTest extends ExtendedITextTest {
 
     @Test
     public void verifyThatToStringProducesValidCss() {
-        CssFontFaceRule fontFaceRule = new CssFontFaceRule("");
+        CssFontFaceRule fontFaceRule = new CssFontFaceRule();
         List<CssDeclaration> declarations = new ArrayList<>();
         declarations.add(new CssDeclaration(CommonCssConstants.FONT_FAMILY, "test-font-family"));
         declarations.add(new CssDeclaration(CommonCssConstants.FONT_WEIGHT, CommonCssConstants.BOLD));