Skip to content

Commit 42bb7f3

Browse files
amedeeamedee
committed
Replace Findbugs with Spotbugs
Findbugs is no longer maintained, see https://gleclaire.github.io/findbugs-maven-plugin/index.html and https://spotbugs.github.io/ QA-1201
1 parent 0337d3b commit 42bb7f3

File tree

13 files changed

+168
-160
lines changed

13 files changed

+168
-160
lines changed

‎Jenkinsfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ pipeline {
8585
}
8686
}
8787
}
88-
stage('Findbugs') {
88+
stage('Spotbugs') {
8989
options {
9090
timeout(time: 10, unit: 'MINUTES')
9191
}
9292
steps {
9393
/* Change treshold to Default or remove treshold to find more bugs */
9494
withMaven(jdk: "${JDK_VERSION}", maven: 'M3') {
95-
sh 'mvn --activate-profiles qa findbugs:check -Dfindbugs.threshold="High"'
95+
sh 'mvn --activate-profiles qa spotbugs:check -Dspotbugs.threshold="High"'
9696
}
9797
}
9898
}

‎barcodes/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,16 @@
2929

3030
<build>
3131
<plugins>
32+
<plugin>
33+
<groupId>com.github.spotbugs</groupId>
34+
<artifactId>spotbugs-maven-plugin</artifactId>
35+
<version>${spotbugs.version}</version>
36+
<configuration>
37+
<threshold>High</threshold>
38+
<failOnError>true</failOnError>
39+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
40+
</configuration>
41+
</plugin>
3242
<plugin>
3343
<groupId>org.apache.maven.plugins</groupId>
3444
<artifactId>maven-failsafe-plugin</artifactId>
@@ -46,16 +56,6 @@
4656
<groups>${unittests}</groups>
4757
</configuration>
4858
</plugin>
49-
<plugin>
50-
<groupId>org.codehaus.mojo</groupId>
51-
<artifactId>findbugs-maven-plugin</artifactId>
52-
<version>${findbugs.version}</version>
53-
<configuration>
54-
<threshold>High</threshold>
55-
<failOnError>true</failOnError>
56-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
57-
</configuration>
58-
</plugin>
5959
</plugins>
6060
</build>
6161
</project>

‎forms/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,16 @@
4848

4949
<build>
5050
<plugins>
51+
<plugin>
52+
<groupId>com.github.spotbugs</groupId>
53+
<artifactId>spotbugs-maven-plugin</artifactId>
54+
<version>${spotbugs.version}</version>
55+
<configuration>
56+
<threshold>High</threshold>
57+
<failOnError>true</failOnError>
58+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
59+
</configuration>
60+
</plugin>
5161
<plugin>
5262
<groupId>org.apache.maven.plugins</groupId>
5363
<artifactId>maven-failsafe-plugin</artifactId>
@@ -65,16 +75,6 @@
6575
<groups>${unittests}</groups>
6676
</configuration>
6777
</plugin>
68-
<plugin>
69-
<groupId>org.codehaus.mojo</groupId>
70-
<artifactId>findbugs-maven-plugin</artifactId>
71-
<version>${findbugs.version}</version>
72-
<configuration>
73-
<threshold>High</threshold>
74-
<failOnError>true</failOnError>
75-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
76-
</configuration>
77-
</plugin>
7878
</plugins>
7979
</build>
8080
</project>

‎io/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@
4545
</testResources>
4646
<plugins>
4747
<plugin>
48-
<groupId>org.codehaus.mojo</groupId>
49-
<artifactId>findbugs-maven-plugin</artifactId>
50-
<version>${findbugs.version}</version>
48+
<groupId>com.github.spotbugs</groupId>
49+
<artifactId>spotbugs-maven-plugin</artifactId>
50+
<version>${spotbugs.version}</version>
5151
<configuration>
5252
<threshold>High</threshold>
5353
<failOnError>true</failOnError>

‎itextcore/pom.xml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,15 @@
139139
<plugin>
140140
<groupId>org.revapi</groupId>
141141
<artifactId>revapi-maven-plugin</artifactId>
142-
<version>0.8.2</version>
142+
<version>0.10.4</version>
143+
<configuration>
144+
<skip>true</skip>
145+
</configuration>
146+
</plugin>
147+
<plugin>
148+
<groupId>com.github.spotbugs</groupId>
149+
<artifactId>spotbugs-maven-plugin</artifactId>
150+
<version>3.1.11</version>
143151
<configuration>
144152
<skip>true</skip>
145153
</configuration>

‎kernel/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,16 @@
4747

4848
<build>
4949
<plugins>
50+
<plugin>
51+
<groupId>com.github.spotbugs</groupId>
52+
<artifactId>spotbugs-maven-plugin</artifactId>
53+
<version>${spotbugs.version}</version>
54+
<configuration>
55+
<threshold>High</threshold>
56+
<failOnError>true</failOnError>
57+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
58+
</configuration>
59+
</plugin>
5060
<plugin>
5161
<groupId>org.apache.maven.plugins</groupId>
5262
<artifactId>maven-failsafe-plugin</artifactId>
@@ -64,16 +74,6 @@
6474
<groups>${unittests}</groups>
6575
</configuration>
6676
</plugin>
67-
<plugin>
68-
<groupId>org.codehaus.mojo</groupId>
69-
<artifactId>findbugs-maven-plugin</artifactId>
70-
<version>${findbugs.version}</version>
71-
<configuration>
72-
<threshold>High</threshold>
73-
<failOnError>true</failOnError>
74-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
75-
</configuration>
76-
</plugin>
7777
</plugins>
7878
</build>
7979
</project>

‎layout/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,16 @@
3535

3636
<build>
3737
<plugins>
38+
<plugin>
39+
<groupId>com.github.spotbugs</groupId>
40+
<artifactId>spotbugs-maven-plugin</artifactId>
41+
<version>${spotbugs.version}</version>
42+
<configuration>
43+
<threshold>High</threshold>
44+
<failOnError>true</failOnError>
45+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
46+
</configuration>
47+
</plugin>
3848
<plugin>
3949
<groupId>org.apache.maven.plugins</groupId>
4050
<artifactId>maven-failsafe-plugin</artifactId>
@@ -52,16 +62,6 @@
5262
<groups>${unittests}</groups>
5363
</configuration>
5464
</plugin>
55-
<plugin>
56-
<groupId>org.codehaus.mojo</groupId>
57-
<artifactId>findbugs-maven-plugin</artifactId>
58-
<version>${findbugs.version}</version>
59-
<configuration>
60-
<threshold>High</threshold>
61-
<failOnError>true</failOnError>
62-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
63-
</configuration>
64-
</plugin>
6565
</plugins>
6666
</build>
6767
</project>

‎pdfa/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,16 @@
4141

4242
<build>
4343
<plugins>
44+
<plugin>
45+
<groupId>com.github.spotbugs</groupId>
46+
<artifactId>spotbugs-maven-plugin</artifactId>
47+
<version>${spotbugs.version}</version>
48+
<configuration>
49+
<threshold>High</threshold>
50+
<failOnError>true</failOnError>
51+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
52+
</configuration>
53+
</plugin>
4454
<plugin>
4555
<groupId>org.apache.maven.plugins</groupId>
4656
<artifactId>maven-failsafe-plugin</artifactId>
@@ -58,16 +68,6 @@
5868
<groups>${unittests}</groups>
5969
</configuration>
6070
</plugin>
61-
<plugin>
62-
<groupId>org.codehaus.mojo</groupId>
63-
<artifactId>findbugs-maven-plugin</artifactId>
64-
<version>${findbugs.version}</version>
65-
<configuration>
66-
<threshold>High</threshold>
67-
<failOnError>true</failOnError>
68-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
69-
</configuration>
70-
</plugin>
7171
</plugins>
7272
</build>
7373
</project>

‎pdftest/pom.xml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,16 @@
2828

2929
<build>
3030
<plugins>
31+
<plugin>
32+
<groupId>com.github.spotbugs</groupId>
33+
<artifactId>spotbugs-maven-plugin</artifactId>
34+
<version>${spotbugs.version}</version>
35+
<configuration>
36+
<threshold>High</threshold>
37+
<failOnError>true</failOnError>
38+
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
39+
</configuration>
40+
</plugin>
3141
<plugin>
3242
<groupId>org.apache.maven.plugins</groupId>
3343
<artifactId>maven-failsafe-plugin</artifactId>
@@ -45,16 +55,6 @@
4555
<groups>${unittests}</groups>
4656
</configuration>
4757
</plugin>
48-
<plugin>
49-
<groupId>org.codehaus.mojo</groupId>
50-
<artifactId>findbugs-maven-plugin</artifactId>
51-
<version>${findbugs.version}</version>
52-
<configuration>
53-
<threshold>High</threshold>
54-
<failOnError>true</failOnError>
55-
<excludeFilterFile>findbugs-filter.xml</excludeFilterFile>
56-
</configuration>
57-
</plugin>
5858
<plugin>
5959
<groupId>org.pitest</groupId>
6060
<artifactId>pitest-maven</artifactId>

0 commit comments

Comments
 (0)