Allow dot in form fields created with builders

DEVSIX-8825

Author: Eugene Bochilo

forms/src/main/java/com/itextpdf/forms/fields/PdfFormAnnotation.java

@@ -816,7 +816,7 @@ protected void drawListFormFieldAndSaveAppearance() {
         boolean multiselect = parent.getFieldFlag(PdfChoiceFormField.FF_MULTI_SELECT);
         if (!(formFieldElement instanceof ListBoxField)) {
             // Create it once and reset properties during each widget regeneration.
-            formFieldElement = new ListBoxField(parent.getPartialFieldName().toUnicodeString(), 0, multiselect);
+            formFieldElement = new ListBoxField("", 0, multiselect);
         }
         formFieldElement.setProperty(FormProperty.FORM_FIELD_MULTIPLE, multiselect);
         ((ListBoxField) formFieldElement).setTopIndex(parent instanceof PdfChoiceFormField &&
@@ -974,7 +974,7 @@ protected void drawComboBoxAndSaveAppearance() {
             return;
         }
         if (!(formFieldElement instanceof ComboBoxField)) {
-            formFieldElement = new ComboBoxField(parent.getPartialFieldName().toUnicodeString());
+            formFieldElement = new ComboBoxField("");
         }
 
         //Apply rotation
@@ -1177,7 +1177,7 @@ private boolean fontRequiredForRegeneration() {
     void createInputButton() {
         if (!(formFieldElement instanceof Button)) {
             // Create it one time and re-set properties during each widget regeneration.
-            formFieldElement = new Button(parent.getPartialFieldName().toUnicodeString());
+            formFieldElement = new Button("");
         }
 
         ((Button) formFieldElement).setFont(getFont());
@@ -1189,7 +1189,7 @@ void createInputButton() {
     void createSigField() {
         if (!(formFieldElement instanceof SignatureFieldAppearance)) {
             // Create it one time and re-set properties during each widget regeneration.
-            formFieldElement = new SignatureFieldAppearance(parent.getPartialFieldName().toUnicodeString());
+            formFieldElement = new SignatureFieldAppearance("");
         }
         if (formFieldElement.<Object>getProperty(Property.FONT) == null) {
             ((SignatureFieldAppearance) formFieldElement).setFont(getFont());

forms/src/test/java/com/itextpdf/forms/fields/CheckBoxFormFieldBuilderTest.java

@@ -34,6 +34,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -72,6 +73,12 @@ public void createCheckBoxWithWidgetTest() {
         compareCheckBoxes(checkBoxFormField, true);
     }
 
+    @Test
+    public void createCheckBoxWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new CheckBoxFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createCheckBox());
+    }
+
     @Test
     public void createCheckBoxWithoutWidgetTest() {
         PdfButtonFormField checkBoxFormField =

forms/src/test/java/com/itextpdf/forms/fields/ChoiceFormFieldBuilderTest.java

@@ -36,6 +36,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -125,6 +126,12 @@ public void createComboBoxWithoutWidgetTest() {
         compareChoices(new PdfDictionary(), choiceFormField, false);
     }
 
+    @Test
+    public void createComboBoxWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createComboBox());
+    }
+
     @Test
     public void createComboBoxWithConformanceLevelTest() {
         PdfChoiceFormField choiceFormField = new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)
@@ -174,6 +181,12 @@ public void createListWithoutWidgetTest() {
         compareChoices(expectedDictionary, choiceFormField, false);
     }
 
+    @Test
+    public void createListWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createList());
+    }
+
     @Test
     public void createListWithConformanceLevelTest() {
         PdfChoiceFormField choiceFormField = new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)

forms/src/test/java/com/itextpdf/forms/fields/PushButtonFormFieldBuilderTest.java

@@ -34,6 +34,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -81,6 +82,12 @@ public void createPushButtonWithoutWidgetTest() {
         comparePushButtons(pushButtonFormField, false);
     }
 
+    @Test
+    public void createPushButtonWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new PushButtonFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createPushButton());
+    }
+
     @Test
     public void createPushButtonWithConformanceLevelTest() {
         PdfButtonFormField pushButtonFormField = new PushButtonFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)

forms/src/test/java/com/itextpdf/forms/fields/RadioFormFieldBuilderTest.java

@@ -37,6 +37,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.annot.PdfAnnotation;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -79,6 +80,12 @@ public void createRadioButtonWithWidgetTest() {
         compareRadioButtons(radioAnnotation, radioGroup, false);
     }
 
+    @Test
+    public void createRadioButtonWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new RadioFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createRadioGroup());
+    }
+
     @Test
     public void createRadioButtonWithWidgetUseSetWidgetRectangleTest() {
         RadioFormFieldBuilder builder = new RadioFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME);

forms/src/test/java/com/itextpdf/forms/fields/SignatureFormFieldBuilderTest.java

@@ -33,6 +33,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -72,6 +73,12 @@ public void createSignatureWithoutWidgetTest() {
         compareSignatures(signatureFormField, false);
     }
 
+    @Test
+    public void createSignatureWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new SignatureFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createSignature());
+    }
+
     @Test
     public void createSignatureWithConformanceLevelTest() {
         PdfSignatureFormField signatureFormField = new SignatureFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)

forms/src/test/java/com/itextpdf/forms/fields/TextFormFieldBuilderTest.java

@@ -34,6 +34,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.pdf.annot.PdfWidgetAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 
 import java.io.ByteArrayOutputStream;
@@ -77,6 +78,12 @@ public void createTextWithoutWidgetTest() {
         compareTexts(expectedDictionary, textFormField, false);
     }
 
+    @Test
+    public void createTextWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new TextFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createText());
+    }
+
     @Test
     public void createTextWithConformanceLevelTest() {
         PdfTextFormField textFormField = new TextFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)
@@ -109,6 +116,12 @@ public void createMultilineTextWithoutWidgetTest() {
         compareTexts(expectedDictionary, textFormField, false);
     }
 
+    @Test
+    public void createMultilineTextWithIncorrectNameTest() {
+        AssertUtil.doesNotThrow(() -> new TextFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .setWidgetRectangle(DUMMY_RECTANGLE).createMultilineText());
+    }
+
     @Test
     public void createMultilineTextWithConformanceLevelTest() {
         PdfTextFormField textFormField = new TextFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME)