Refine Findbugs filters in forms module

QA-1148

Author: Jakub Urban

forms/findbugs-filter.xml

@@ -1,21 +1,88 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <FindBugsFilter>
     <Match>
+        <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+        <Or>
+            <Method name="generateDefaultAppearanceString"/>
+            <Method name="setDefaultAppearance"/>
+            <Method name="getValueAsString"/>
+        </Or>
         <Bug pattern="DM_DEFAULT_ENCODING"/>
     </Match>
     <Match>
+        <Or>
+            <And>
+                <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+                <Method name="createChoice"/>
+            </And>
+            <And>
+                <Class name="com.itextpdf.forms.xfa.XfaForm"/>
+                <Or>
+                    <Method name="&lt;init&gt;" params="com.itextpdf.kernel.pdf.PdfDictionary" returns="void"/>
+                    <Method name="&lt;init&gt;" params="com.itextpdf.kernel.pdf.PdfDocument" returns="void"/>
+                    <Method name="&lt;init&gt;" params="java.io.InputStream" returns="void"/>
+                    <Method name="fillXfaForm" params="org.xml.sax.InputSource, boolean" returns="void"/>
+                </Or>
+            </And>
+            <And>
+                <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+                <Or>
+                    <Method name="setCheckType"/>
+                    <Method name="regenerateField"/>
+                    <Method name="createComboBox" params="com.itextpdf.kernel.pdf.PdfDocument, com.itextpdf.kernel.geom.Rectangle, java.lang.String, java.lang.String, java.lang.String[]" returns="com.itextpdf.forms.fields.PdfChoiceFormField"/>
+                    <Method name="createComboBox" params="com.itextpdf.kernel.pdf.PdfDocument, com.itextpdf.kernel.geom.Rectangle, java.lang.String, java.lang.String, java.lang.String[][]" returns="com.itextpdf.forms.fields.PdfChoiceFormField"/>
+                    <Method name="createList" params="com.itextpdf.kernel.pdf.PdfDocument, com.itextpdf.kernel.geom.Rectangle, java.lang.String, java.lang.String, java.lang.String[]" returns="com.itextpdf.forms.fields.PdfChoiceFormField"/>
+                    <Method name="createList" params="com.itextpdf.kernel.pdf.PdfDocument, com.itextpdf.kernel.geom.Rectangle, java.lang.String, java.lang.String, java.lang.String[][]" returns="com.itextpdf.forms.fields.PdfChoiceFormField"/>
+                    <Method name="createPushButton" params="com.itextpdf.kernel.pdf.PdfDocument, com.itextpdf.kernel.geom.Rectangle, java.lang.String, java.lang.String" returns="com.itextpdf.forms.fields.PdfButtonFormField"/>
+                </Or>
+            </And>
+        </Or>
         <Bug pattern="EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS"/>
     </Match>
     <Match>
+        <Or>
+            <And>
+                <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+                <Or>
+                    <Method name="drawRadioAppearance"/>
+                    <Method name="splitDAelements"/>
+                </Or>
+            </And>
+            <And>
+                <Class name="com.itextpdf.forms.xfa.XfaForm"/>
+                <Or>
+                    <Method name="findDataNode" params="org.w3c.dom.Node" returns="org.w3c.dom.Node"/>
+                    <Method name="fillXfaForm" params="org.w3c.dom.Node, boolean" returns="void"/>
+                </Or>
+            </And>
+        </Or>
         <Bug pattern="LSC_LITERAL_STRING_COMPARISON"/>
     </Match>
     <Match>
+        <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+        <Method name="optionsArrayToString" params="com.itextpdf.kernel.pdf.PdfArray" returns="java.lang.String"/>
         <Bug pattern="LSYC_LOCAL_SYNCHRONIZED_COLLECTION"/>
     </Match>
     <Match>
+        <Or>
+            <And>
+                <Class name="com.itextpdf.forms.PdfPageFormCopier"/>
+                <Method name="mergeFieldsWithTheSameName"/>
+            </And>
+            <And>
+                <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+                <Or>
+                    <Method name="regenerateField"/>
+                    <Method name="setPage"/>
+                    <Method name="setValue" params="java.lang.String, com.itextpdf.kernel.font.PdfFont, float" returns="com.itextpdf.forms.fields.PdfFormField"/>
+                </Or>
+            </And>
+        </Or>
         <Bug pattern="PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS"/>
     </Match>
     <Match>
+        <Class name="com.itextpdf.forms.fields.PdfFormField"/>
+        <Method name="splitDAelements"/>
         <Bug pattern="REC_CATCH_EXCEPTION"/>
     </Match>
 </FindBugsFilter>