Fix wrong initialization order introduced in the refactoring commit

DEVSIX-1286

Author: yulian-gaponenko

sign/src/main/java/com/itextpdf/signatures/LtvVerifier.java

@@ -104,18 +104,12 @@ public class LtvVerifier extends RootStoreVerifier {
      */
     public LtvVerifier(PdfDocument document) throws GeneralSecurityException {
         super(null);
-        this.document = document;
-        this.acroForm = PdfAcroForm.getAcroForm(document, true);
-        this.sgnUtil = new SignatureUtil(document);
-        List<String> names = sgnUtil.getSignatureNames();
-        signatureName = names.get(names.size() - 1);
-        this.signDate = DateTimeUtil.getCurrentTimeDate();
-        pkcs7 = coversWholeDocument();
-        LOGGER.info(MessageFormat.format("Checking {0}signature {1}", pkcs7.isTsp() ? "document-level timestamp " : "", signatureName));
+        initLtvVerifier(document);
     }
     public LtvVerifier(PdfDocument document, String securityProviderCode) throws GeneralSecurityException {
-        this(document);
+        super(null);
         this.securityProviderCode = securityProviderCode;
+        initLtvVerifier(document);
     }
 
     /**
@@ -141,29 +135,6 @@ public void setVerifyRootCertificate(boolean verifyRootCertificate) {
         this.verifyRootCertificate = verifyRootCertificate;
     }
 
-    /**
-     * Checks if the signature covers the whole document
-     * and throws an exception if the document was altered
-     * @return a PdfPKCS7 object
-     * @throws GeneralSecurityException
-     */
-    protected PdfPKCS7 coversWholeDocument() throws GeneralSecurityException {
-        PdfPKCS7 pkcs7 = sgnUtil.verifySignature(signatureName, securityProviderCode);
-        if (sgnUtil.signatureCoversWholeDocument(signatureName)) {
-            LOGGER.info("The timestamp covers whole document.");
-        }
-        else {
-            throw new VerificationException((Certificate) null, "Signature doesn't cover whole document.");
-        }
-        if (pkcs7.verify()) {
-            LOGGER.info("The signed document has not been modified.");
-            return pkcs7;
-        }
-        else {
-            throw new VerificationException((Certificate) null, "The document was altered after the final signature was applied.");
-        }
-    }
-
     /**
      * Verifies all the document-level timestamps and all the signatures in the document.
      * @throws IOException
@@ -352,4 +323,38 @@ public List<BasicOCSPResp> getOCSPResponsesFromDSS() throws IOException, General
         }
         return ocsps;
     }
+
+    protected void initLtvVerifier(PdfDocument document) throws GeneralSecurityException {
+        this.document = document;
+        this.acroForm = PdfAcroForm.getAcroForm(document, true);
+        this.sgnUtil = new SignatureUtil(document);
+        List<String> names = sgnUtil.getSignatureNames();
+        signatureName = names.get(names.size() - 1);
+        this.signDate = DateTimeUtil.getCurrentTimeDate();
+        pkcs7 = coversWholeDocument();
+        LOGGER.info(MessageFormat.format("Checking {0}signature {1}", pkcs7.isTsp() ? "document-level timestamp " : "", signatureName));
+    }
+
+    /**
+     * Checks if the signature covers the whole document
+     * and throws an exception if the document was altered
+     * @return a PdfPKCS7 object
+     * @throws GeneralSecurityException
+     */
+    protected PdfPKCS7 coversWholeDocument() throws GeneralSecurityException {
+        PdfPKCS7 pkcs7 = sgnUtil.verifySignature(signatureName, securityProviderCode);
+        if (sgnUtil.signatureCoversWholeDocument(signatureName)) {
+            LOGGER.info("The timestamp covers whole document.");
+        }
+        else {
+            throw new VerificationException((Certificate) null, "Signature doesn't cover whole document.");
+        }
+        if (pkcs7.verify()) {
+            LOGGER.info("The signed document has not been modified.");
+            return pkcs7;
+        }
+        else {
+            throw new VerificationException((Certificate) null, "The document was altered after the final signature was applied.");
+        }
+    }
 }