Skip to content

Commit 48b3b3d

Browse files
committed
Improve TODOs of OCSPVerifier
Provide the tickets unders which the TODOs should be resolved DEVSIX-5141
1 parent ff08e8f commit 48b3b3d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sign/src/main/java/com/itextpdf/signatures/OCSPVerifier.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@ public void isValidResponse(BasicOCSPResp ocspResp, X509Certificate issuerCert,
263263
if (responderCert.getExtensionValue(OCSPObjectIdentifiers.id_pkix_ocsp_nocheck.getId()) == null) {
264264
CRL crl;
265265
try {
266-
// TODO should also check for Authority Information Access according to RFC6960 4.2.2.2.1. "Revocation Checking of an Authorized Responder"
267-
// TODO should also respect onlineCheckingAllowed property?
266+
// TODO DEVSIX-5210 Implement a check heck for Authority Information Access according to
267+
// RFC6960 4.2.2.2.1. "Revocation Checking of an Authorized Responder"
268268
crl = CertificateUtil.getCRL(responderCert);
269269
} catch (Exception ignored) {
270270
crl = (CRL) null;
@@ -279,8 +279,8 @@ public void isValidResponse(BasicOCSPResp ocspResp, X509Certificate issuerCert,
279279
} else {
280280
Logger logger = LoggerFactory.getLogger(OCSPVerifier.class);
281281
logger.error("Authorized OCSP responder certificate revocation status cannot be checked");
282-
// TODO throw exception starting from iText version 7.2, but only after OCSPVerifier would allow explicit setting revocation check end points/provide revocation data
283-
// throw new VerificationException(issuerCert, "Authorized OCSP responder certificate revocation status cannot be checked.");
282+
// TODO DEVSIX-5207 throw exception starting from iText version 7.2, but only after OCSPVerifier
283+
// would allow explicit setting revocation check end points/provide revocation data
284284
}
285285
}
286286

0 commit comments

Comments
 (0)