Make fill opaque if it is parsed from invalid url

DEVSIX-3365

Author: Dmitry Radchuk

svg/src/main/java/com/itextpdf/svg/renderers/impl/AbstractSvgNodeRenderer.java

@@ -470,22 +470,38 @@ private TransparentColor getColorFromAttributeValue(SvgDrawContext context, Stri
             return null;
         }
         String tokenValue = token.getValue();
-        if (tokenValue.startsWith("url(#") && tokenValue.endsWith(")")) {
-            Color resolvedColor = null;
-            float resolvedOpacity = 1;
-            final String normalizedName = tokenValue.substring(5, tokenValue.length() - 1).trim();
-            final ISvgNodeRenderer colorRenderer = context.getNamedObject(normalizedName);
-            if (colorRenderer instanceof ISvgPaintServer) {
-                if (colorRenderer.getParent() == null) {
-                    colorRenderer.setParent(this);
+        boolean isUrlInvalid = false;
+        if (tokenValue.startsWith("url(") && tokenValue.endsWith(")")) {
+            String normalizedName = tokenValue.substring(4, tokenValue.length() - 1).trim();
+            normalizedName = CssUtils.extractUnquotedString(normalizedName);
+            if (normalizedName.startsWith("#")) {
+                Color resolvedColor = null;
+                float resolvedOpacity = 1;
+                normalizedName = normalizedName.substring(1);
+                final ISvgNodeRenderer colorRenderer = context.getNamedObject(normalizedName);
+                if (colorRenderer instanceof ISvgPaintServer) {
+                    if (colorRenderer.getParent() == null) {
+                        colorRenderer.setParent(this);
+                    }
+                    resolvedColor = ((ISvgPaintServer) colorRenderer).createColor(
+                            context, getObjectBoundingBox(context), objectBoundingBoxMargin, parentOpacity);
                 }
-                resolvedColor = ((ISvgPaintServer) colorRenderer).createColor(
-                        context, getObjectBoundingBox(context), objectBoundingBoxMargin, parentOpacity);
-            }
-            if (resolvedColor != null) {
-                return new TransparentColor(resolvedColor, resolvedOpacity);
+                if (resolvedColor != null) {
+                    return new TransparentColor(resolvedColor, resolvedOpacity);
+                }
+                if (colorRenderer == null) {
+                    isUrlInvalid = true;
+                }
+            } else {
+                //we don't support those, but we need to make fill transparent anyway in such a case
+                isUrlInvalid = true;
+                //try to get next token to work the same as for the local url values
             }
             token = tokenizer.getNextValidToken();
+        } else if (tokenValue.startsWith("url(") && !tokenValue.contains(" ")) {
+            //for cases like url\([\w\d]+ browser treats them as urls, but url\([\w\d]+\s[\w\d]+ are not
+            isUrlInvalid = true;
+            token = tokenizer.getNextValidToken();
         }
         // may become null after function parsing and reading the 2nd token
         if (token != null) {
@@ -498,6 +514,9 @@ private TransparentColor getColorFromAttributeValue(SvgDrawContext context, Stri
                 return new TransparentColor(result.getColor(), result.getOpacity() * parentOpacity);
             }
         }
+        if (isUrlInvalid) {
+            return new TransparentColor(ColorConstants.BLACK, 0.0F);
+        }
         return null;
     }
 

svg/src/test/java/com/itextpdf/svg/renderers/FillTest.java

@@ -22,6 +22,7 @@ This file is part of the iText (R) project.
  */
 package com.itextpdf.svg.renderers;
 
+import com.itextpdf.styledxmlparser.logs.StyledXmlParserLogMessageConstant;
 import com.itextpdf.svg.exceptions.SvgProcessingException;
 import com.itextpdf.svg.logs.SvgLogMessageConstant;
 import com.itextpdf.test.ITextTest;
@@ -119,7 +120,9 @@ public void pathHorizontalLineFillTest() throws IOException, InterruptedExceptio
     }
 
     @Test
-    //TODO update cmp file after DEVSIX-3365 will be fixed
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = StyledXmlParserLogMessageConstant.URL_IS_NOT_CLOSED_IN_CSS_EXPRESSION)
+    })
     public void invalidUrlFillTest() throws IOException, InterruptedException {
         convertAndCompare(SOURCE_FOLDER, DESTINATION_FOLDER, "invalidUrlFillTest");
     }
@@ -134,7 +137,6 @@ public void textFillFallbackTest() throws IOException, InterruptedException {
     }
 
     @Test
-    //TODO DEVSIX-8821: update after supported
     public void fillLinkToNonExistingGradientTest() throws IOException, InterruptedException {
         convertAndCompareSinglePage(SOURCE_FOLDER, DESTINATION_FOLDER, "fillLinkToNonExistingGradient");
     }