Restrict the scope of methods for internal usage

Author: Snipx

io/src/main/java/com/itextpdf/io/source/OutputStream.java

@@ -24,6 +24,14 @@ public OutputStream(java.io.OutputStream outputStream) {
         this.outputStream = outputStream;
     }
 
+    /**
+     * Do not use this constructor. This is only for internal usage.
+     */
+    protected OutputStream() {
+        super();
+        this.outputStream = new ByteArrayOutputStream();
+    }
+
     @Override
     public void write(int b) throws java.io.IOException {
         outputStream.write(b);

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java

@@ -524,22 +524,6 @@ public PageSize getDefaultPageSize() {
         return defaultPageSize;
     }
 
-    public byte[] getSerializedBytes() {
-        try {
-            ByteArrayOutputStream bos = new ByteArrayOutputStream();
-            ObjectOutputStream oos = null;
-            oos = new ObjectOutputStream(bos);
-            oos.writeObject(this);
-            oos.flush();
-            oos.close();
-            bos.close();
-            return bos.toByteArray();
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
-        return null;
-    }
-
     /**
      * Sets default page size.
      *
@@ -1500,4 +1484,18 @@ private void ensureTreeRootAddedToNames(PdfObject treeRoot, PdfName treeType) {
         }
         names.put(treeType, treeRoot);
     }
+
+    private byte[] getSerializedBytes() {
+        try {
+            ByteArrayOutputStream bos = new ByteArrayOutputStream();
+            ObjectOutputStream oos = new ObjectOutputStream(bos);
+            oos.writeObject(this);
+            oos.flush();
+            oos.close();
+            bos.close();
+            return bos.toByteArray();
+        } catch (IOException e) {
+            throw new PdfException(e);
+        }
+    }
 }

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfOutputStream.java

@@ -1,14 +1,12 @@
 package com.itextpdf.kernel.pdf;
 
-import com.itextpdf.io.source.ByteUtils;
-import com.itextpdf.kernel.PdfException;
 import com.itextpdf.io.source.ByteArrayOutputStream;
+import com.itextpdf.io.source.ByteUtils;
 import com.itextpdf.io.source.OutputStream;
+import com.itextpdf.kernel.PdfException;
 import com.itextpdf.kernel.crypto.OutputStreamEncryption;
 import com.itextpdf.kernel.pdf.filters.FlateDecodeFilter;
 
-import java.io.FileNotFoundException;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.Serializable;
 import java.security.cert.Certificate;
@@ -130,7 +128,10 @@ public class PdfOutputStream extends OutputStream<PdfOutputStream> implements Se
      */
     protected PdfEncryption crypto;
 
-    protected PdfOutputStream() {
+    /**
+     * Do not use this constructor. This is only for internal usage.
+     */
+    private PdfOutputStream() {
         super();
     }
 

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfWriter.java

@@ -4,9 +4,12 @@
 import com.itextpdf.io.source.ByteUtils;
 import com.itextpdf.kernel.PdfException;
 
-import java.io.*;
+import java.io.BufferedOutputStream;
 import java.io.ByteArrayOutputStream;
-import java.io.OutputStream;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.Serializable;
 import java.security.MessageDigest;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -375,9 +378,10 @@ protected int getCopyObjectKey(PdfObject object) {
         return result;
     }
 
-    //method invoking while deserialization
-    private void readObject(java.io.ObjectInputStream in)
-            throws java.io.IOException, ClassNotFoundException {
+    /**
+     * This method is invoked while deserialization
+     */
+    private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException {
         in.defaultReadObject();
         this.outputStream = new BufferedOutputStream(new ByteArrayOutputStream());
         content = new PdfOutputStream(new ByteArrayOutputStream());
@@ -406,9 +410,10 @@ private PdfObject smartCopyObject(PdfObject object) {
         return null;
     }
 
-    //method invoking while serialization
-    private void writeObject(java.io.ObjectOutputStream out)
-            throws java.io.IOException {
+    /**
+     * This method is invoked while serialization
+     */
+    private void writeObject(java.io.ObjectOutputStream out) throws java.io.IOException {
         content.flush();
         buffer = getByteArrayOutputStream().toByteArray();
         out.defaultWriteObject();