fix issue in pdfTokenizer, if minus char '-' is found after '.' in a real number then omitt everything after the '.' char. following the adobe reader rule

DEVSIX-2674

Author: Federico Frascarelli

io/src/main/java/com/itextpdf/io/source/PdfTokenizer.java

@@ -454,12 +454,31 @@ public boolean nextToken() throws java.io.IOException {
                         // as we need to know that fact only in case if there are any minuses.
                         ch = file.read();
                     }
-                    while (ch != -1 && ((ch >= '0' && ch <= '9') || ch == '.')) {
-                        if (ch == '.')
-                            isReal = true;
+                    while (ch >= '0' && ch <= '9') {
                         outBuf.append(ch);
                         ch = file.read();
                     }
+
+                    if ( ch == '.'){
+                        isReal = true;
+                        outBuf.append(ch);
+                        ch = file.read();
+
+                        //verify if there is minus after '.'
+                        //In that case just ignore minus chars and everything after as Adobe Reader does
+                        int numberOfMinusesAfterDot = 0;
+                        if (ch == '-') {
+                            numberOfMinusesAfterDot++;
+                            ch = file.read();
+                        }
+                        while (ch >= '0' && ch <= '9') {
+                            if (numberOfMinusesAfterDot == 0) {
+                                outBuf.append(ch);
+                            }
+                            ch = file.read();
+                        }
+                    }
+
                     if (numberOfMinuses > 1 && !isReal) {
                         // Numbers of integer type and with more than one minus before them
                         // are interpreted by Acrobat as zero.

kernel/src/test/java/com/itextpdf/kernel/pdf/PdfDictionaryTokenizerTest.java

@@ -0,0 +1,148 @@
+/*
+    This file is part of the iText (R) project.
+    Copyright (c) 1998-2019 iText Group NV
+    Authors: iText Software.
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU Affero General Public License version 3
+    as published by the Free Software Foundation with the addition of the
+    following permission added to Section 15 as permitted in Section 7(a):
+    FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+    ITEXT GROUP. ITEXT GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+    OF THIRD PARTY RIGHTS
+
+    This program is distributed in the hope that it will be useful, but
+    WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+    or FITNESS FOR A PARTICULAR PURPOSE.
+    See the GNU Affero General Public License for more details.
+    You should have received a copy of the GNU Affero General Public License
+    along with this program; if not, see http://www.gnu.org/licenses or write to
+    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+    Boston, MA, 02110-1301 USA, or download the license from the following URL:
+    http://itextpdf.com/terms-of-use/
+
+    The interactive user interfaces in modified source and object code versions
+    of this program must display Appropriate Legal Notices, as required under
+    Section 5 of the GNU Affero General Public License.
+
+    In accordance with Section 7(b) of the GNU Affero General Public License,
+    a covered work must retain the producer line in every PDF that is created
+    or manipulated using iText.
+
+    You can be released from the requirements of the license by purchasing
+    a commercial license. Buying such a license is mandatory as soon as you
+    develop commercial activities involving the iText software without
+    disclosing the source code of your own applications.
+    These activities include: offering paid services to customers as an ASP,
+    serving PDFs on the fly in a web application, shipping iText with a closed
+    source product.
+
+    For more information, please contact iText Software Corp. at this
+    address: [email protected]
+ */
+package com.itextpdf.kernel.pdf;
+
+import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.annotations.type.IntegrationTest;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.xml.sax.SAXException;
+
+import javax.xml.parsers.ParserConfigurationException;
+import java.io.IOException;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertTrue;
+
+@Category(IntegrationTest.class)
+public class PdfDictionaryTokenizerTest extends ExtendedITextTest {
+
+    public static final String sourceFolder = "./src/test/resources/com/itextpdf/kernel/pdf/PdfDictionaryTokenizerTest/";
+    public static final String destinationFolder = "./target/test/com/itextpdf/kernel/pdf/PdfDictionaryTokenizerTest/";
+
+    @BeforeClass
+    public static void beforeClass() {
+        createOrClearDestinationFolder(destinationFolder);
+    }
+
+    @Test
+    public void readerTurnsCorrectlyNotWellFormattedValueInDictionary_01() throws IOException, InterruptedException, ParserConfigurationException, SAXException {
+
+        String inPath = sourceFolder + "documentWithMalformedNumberOnDictionary.pdf";
+        String EXPECTED="-12.";
+
+        /*
+        The following is the content included in the pdf file
+
+        <</Ascent 800
+        /CapHeight 700
+        /Descent -200
+        /Flags 32
+        /FontBBox[-631 -462 1632 1230]
+        /FontFamily(FreeSans)
+        /FontFile2 8 0 R
+        /FontName/XVVAXW+FreeSans
+        /FontWeight 400
+        /ItalicAngle -12.-23
+        /StemV 80
+        /Type/FontDescriptor>>
+        */
+
+        // ItalicAngle -12.-23 turns into -12.
+
+        String result = getItalicAngleValue(inPath);
+        Assert.assertEquals(EXPECTED, result);
+    }
+
+    @Test
+    public void readerTurnsCorrectlyNotWellFormattedValueInDictionary_02() throws IOException, InterruptedException, ParserConfigurationException, SAXException {
+
+        String inPath = sourceFolder + "documentWithMalformedNumberOnDictionary2.pdf";
+        String EXPECTED="-12.";
+
+        /*
+        The following is the content included in the pdf file
+
+        <</Ascent 800
+        /CapHeight 700
+        /Descent -200
+        /Flags 32
+        /FontBBox[-631 -462 1632 1230]
+        /FontFamily(FreeSans)
+        /FontFile2 8 0 R
+        /FontName/XVVAXW+FreeSans
+        /FontWeight 400
+        /StemV 80
+        /Type/FontDescriptor
+        /ItalicAngle -12.-23>>
+        */
+
+        // ItalicAngle -12.-23 turns into -12.
+
+        String result = getItalicAngleValue(inPath);
+        Assert.assertEquals(EXPECTED, result);
+    }
+
+    private String getItalicAngleValue(String inPath) throws IOException {
+        String result = "";
+        PdfReader pdfR = new PdfReader(inPath);
+        PdfDocument attachmentPDF  = new PdfDocument(pdfR);
+        int max = attachmentPDF.getNumberOfPdfObjects();
+        for (int i=0;i<max;i++){
+            PdfObject obj = attachmentPDF.getPdfObject(i);
+            if (obj!=null ){
+                PdfDictionary pdfDict = (PdfDictionary) obj;
+                PdfObject x = pdfDict.get(PdfName.Type);
+                if(x!=null && x.equals(PdfName.FontDescriptor)){
+                    PdfObject italicAngle = pdfDict.get(PdfName.ItalicAngle);
+                    result = italicAngle.toString();
+                }
+            }
+        }
+        attachmentPDF.close();
+        return result;
+    }
+}