Skip to content

Commit 609079c

Browse files
committed
Update CONTRIBUTING.md with latest information and links
DEVSIX-4793
1 parent d4c46c7 commit 609079c

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ Before you submit your pull request consider the following guidelines:
6868
* Verify that your proposed change hasn't already been addressed in the develop branch.
6969
* Don't send a separate pull request for every single file you change.
7070
* Please sign the [iText Contributor License Agreement (iCLA)](#cla) before sending pull
71-
requests for any change of more than 20 significant lines of code (we're not counting curly braces and other syntactical sugar).
72-
We cannot accept code without this agreement.
71+
requests. We cannot accept code without this agreement.
7372
* Fork the iText repository on GitHub.
7473
* Clone your iText fork to your local machine.
7574
* Make your changes, **including appropriate test cases**.
@@ -100,8 +99,7 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
10099

101100
* We develop in Java first, and then port to .NET, so code submissions in Java are preferred.
102101
Nevertheless this shouldn't stop you from making a good pull request to the .NET port.
103-
* All Java code **must** be Java 7. Sorry, no lambda expressions or other Java 8 language features.
104-
* All features or bug fixes **must be tested** by one or more [unit tests][unit-testing].
102+
* All features or bug fixes **must be tested** by one or more unit tests.
105103
* All public API methods **must be documented** with JavaDoc. To see how we document our APIs, please check
106104
out the existing [javadocs][javadocs].
107105
* We follow the rules contained in
@@ -151,8 +149,7 @@ reference JIRA or GitHub issues that this commit **Closes**.
151149

152150
## <a name="cla">Signing the iCLA</a>
153151

154-
Please sign the **iText Contributor License Agreement (iCLA)** before sending pull requests. For any larger code
155-
changes (more than 20 lines of significant code) to be accepted, the iCLA must be signed. It's a quick process, we promise!
152+
Please sign the [**iText Contributor License Agreement (iCLA)**][cla] before sending pull requests. For any code changes to be accepted, the iCLA must be signed. It's a quick process, we promise!
156153

157154
We'll need you to [(digitally) sign and then email, fax or mail the form][cla].
158155

@@ -165,18 +162,17 @@ We use the [Stack Exchange][stackoverflow] network for free support and [GitHub]
165162
* StackExchange: [http://stackexchange.com/legal](http://stackexchange.com/legal)
166163
* Github: [https://help.github.com/articles/github-terms-of-service/](https://help.github.com/articles/github-terms-of-service/)
167164

168-
[cla]: http://itextpdf.com/policy
165+
[cla]: https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement
169166
[coc]: CODE_OF_CONDUCT.md
170167
[github]: https://github.com/itext/itext7
171-
[java-style-guide]: http://www.oracle.com/technetwork/java/codeconvtoc-136057.html
172-
[javadocs]: http://itextpdf.com/api
168+
[java-style-guide]: https://www.oracle.com/technetwork/java/codeconvtoc-136057.html
169+
[javadocs]: https://itextpdf.com/api
173170
[pull]: https://github.com/itext/itext7/pulls
174171
[sscce]: http://sscce.org/
175-
[stackoverflow]: http://stackoverflow.com/questions/tagged/itext7
176-
[good-questions]: http://stackoverflow.com/help/how-to-ask
177-
[mcve]: http://stackoverflow.com/help/mcve
178-
[support]: http://itextpdf.com/support
179-
[unit-testing]: http://junit.org/
172+
[stackoverflow]: https://stackoverflow.com/questions/tagged/itext7
173+
[good-questions]: https://stackoverflow.com/help/how-to-ask
174+
[mcve]: https://stackoverflow.com/help/mcve
175+
[support]: https://itextpdf.com/support
180176
[git-commit]: https://chris.beams.io/posts/git-commit/
181177
[git-commit-separate]: https://chris.beams.io/posts/git-commit/#separate
182178
[git-commit-limit-50]: https://chris.beams.io/posts/git-commit/#limit-50

0 commit comments

Comments
 (0)