Improve memory limits handeling

guustysebie · guustysebie · commit 61ad96245e03 · 2024-05-30T14:47:36.000Z
DEVSIX-8336
diff --git a/kernel/src/main/java/com/itextpdf/kernel/colors/WebColors.java b/kernel/src/main/java/com/itextpdf/kernel/colors/WebColors.java
@@ -248,7 +248,7 @@ public static float[] getCMYKArray(String name) {
                     color[4] = getAlphaChannelValue(tok.nextToken());
                 }
             }
-        } catch (Exception exc) {
+        } catch (Exception e) {
             // Will just return null in this case
             color = null;
         }
@@ -309,7 +309,7 @@ public static float[] getRGBAColor(String name) {
                 color[1] = (float) (intColor[1] / RGB_MAX_VAL);
                 color[2] = (float) (intColor[2] / RGB_MAX_VAL);
             }
-        } catch (Exception exc) {
+        } catch (Exception e) {
             // Will just return null in this case
             color = null;
         }
diff --git a/kernel/src/main/java/com/itextpdf/kernel/crypto/securityhandler/EncryptionUtils.java b/kernel/src/main/java/com/itextpdf/kernel/crypto/securityhandler/EncryptionUtils.java
@@ -105,8 +105,8 @@ static byte[] fetchEnvelopedData(Key certificateKey, Certificate certificate, St
         IX509CertificateHolder certHolder;
         try {
             certHolder = BOUNCY_CASTLE_FACTORY.createX509CertificateHolder(certificate.getEncoded());
-        } catch (Exception f) {
-            throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, f);
+        } catch (Exception e) {
+            throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, e);
         }
         if (externalDecryptionProcess == null) {
             for (int i = 0; i < recipients.size(); i++) {
@@ -125,12 +125,12 @@ static byte[] fetchEnvelopedData(Key certificateKey, Certificate certificate, St
                             foundRecipient = true;
                         }
                     }
-                } catch (Exception f) {
+                } catch (Exception e) {
                     // First check if the feature is supported, it will throw if not
                     // Exact algorithm doesn't matter currently
                     BouncyCastleFactoryCreator.getFactory().isEncryptionFeatureSupported(0, true);
                     // Throw the original exception if the feature is supported
-                    throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, f);
+                    throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, e);
                 }
             }
         } else {
diff --git a/kernel/src/main/java/com/itextpdf/kernel/font/PdfType3Font.java b/kernel/src/main/java/com/itextpdf/kernel/font/PdfType3Font.java
@@ -460,7 +460,7 @@ private void addGlyphsFromCharProcs(PdfDictionary charProcsDic, int[] widths) {
         }
         Map<Integer, Integer> unicodeToCode = null;
         if (getToUnicode() != null) {
-            try { unicodeToCode = getToUnicode().createReverseMapping(); } catch (Exception ignored) {}
+            try { unicodeToCode = getToUnicode().createReverseMapping(); } catch (Exception e) {/*ignored*/}
         }
 
         for (PdfName glyphName : charProcsDic.keySet()) {
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/OcgPropertiesCopier.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/OcgPropertiesCopier.java
@@ -67,8 +67,8 @@ public static void copyOCGProperties(PdfDocument fromDocument, PdfDocument toDoc
 
             OcgPropertiesCopier.copyDDictionary(fromOcgsToCopy, fromOcProperties.getAsDictionary(PdfName.D),
                     toOcProperties, toDocument);
-        } catch (Exception ex) {
-            LOGGER.error(MessageFormatUtil.format(IoLogMessageConstant.OCG_COPYING_ERROR, ex.toString()));
+        } catch (Exception e) {
+            LOGGER.error(MessageFormatUtil.format(IoLogMessageConstant.OCG_COPYING_ERROR, e.toString()));
         }
     }
 
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java
@@ -41,6 +41,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.events.PdfDocumentEvent;
 import com.itextpdf.kernel.exceptions.BadPasswordException;
 import com.itextpdf.kernel.exceptions.KernelExceptionMessageConstant;
+import com.itextpdf.kernel.exceptions.MemoryLimitsAwareException;
 import com.itextpdf.kernel.exceptions.PdfException;
 import com.itextpdf.kernel.font.PdfFont;
 import com.itextpdf.kernel.font.PdfFontFactory;
@@ -1344,11 +1345,11 @@ public List<PdfPage> copyPagesTo(List<Integer> pagesToCopy, PdfDocument toDocume
                         insertBeforePage += increasingPagesRange.size();
                     }
                     toDocument.getTagStructureContext().normalizeDocumentRootTag();
-                } catch (Exception ex) {
+                } catch (Exception e) {
                     throw new PdfException(
                             KernelExceptionMessageConstant.
                                     TAG_STRUCTURE_COPYING_FAILED_IT_MIGHT_BE_CORRUPTED_IN_ONE_OF_THE_DOCUMENTS,
-                            ex);
+                            e);
                 }
                 if (copier instanceof IPdfPageFormCopier) {
                     ((IPdfPageFormCopier) copier).recreateAcroformToProcessCopiedFields(toDocument);
@@ -2385,11 +2386,13 @@ protected void tryInitTagStructure(PdfDictionary str) {
         try {
             structTreeRoot = new PdfStructTreeRoot(str, this);
             structParentIndex = getStructTreeRoot().getParentTreeNextKey();
-        } catch (Exception ex) {
+        } catch (MemoryLimitsAwareException e){
+            throw e;
+        } catch (Exception e) {
             structTreeRoot = null;
             structParentIndex = -1;
             Logger logger = LoggerFactory.getLogger(PdfDocument.class);
-            logger.error(IoLogMessageConstant.TAG_STRUCTURE_INIT_FAILED, ex);
+            logger.error(IoLogMessageConstant.TAG_STRUCTURE_INIT_FAILED, e);
         }
     }
 
@@ -2422,9 +2425,11 @@ private void tryFlushTagStructure(boolean isAppendMode) {
             if (!isAppendMode || structTreeRoot.getPdfObject().isModified()) {
                 structTreeRoot.flush();
             }
-        } catch (Exception ex) {
+        } catch (MemoryLimitsAwareException e){
+            throw e;
+        } catch (Exception e) { 
             throw new PdfException(KernelExceptionMessageConstant.TAG_STRUCTURE_FLUSHING_FAILED_IT_MIGHT_BE_CORRUPTED,
-                    ex);
+                    e);
         }
     }
 
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfPage.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfPage.java
@@ -1257,9 +1257,9 @@ void tryFlushPageTags() {
                 getDocument().getTagStructureContext().flushPageTags(this);
             }
             getDocument().getStructTreeRoot().savePageStructParentIndexIfNeeded(this);
-        } catch (Exception ex) {
+        } catch (Exception e) {
             throw new PdfException(
-                    KernelExceptionMessageConstant.TAG_STRUCTURE_FLUSHING_FAILED_IT_MIGHT_BE_CORRUPTED, ex);
+                    KernelExceptionMessageConstant.TAG_STRUCTURE_FLUSHING_FAILED_IT_MIGHT_BE_CORRUPTED, e);
         }
     }
 
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfReader.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/PdfReader.java
@@ -428,7 +428,8 @@ public byte[] readStreamBytesRaw(PdfStream stream) throws IOException {
         } finally {
             try {
                 file.close();
-            } catch (Exception ignored) {
+            } catch (Exception e) {
+                // ignored
             }
         }
         return bytes;
@@ -1017,7 +1018,7 @@ protected void readXref() throws IOException {
                  | MemoryLimitsAwareException
                  | InvalidXRefPrevException exceptionWhileReadingXrefStream) {
             throw exceptionWhileReadingXrefStream;
-        } catch (Exception ignored) {
+        } catch (Exception e) {
             // Do nothing.
         }
         // clear xref because of possible issues at reading xref stream.
@@ -1363,6 +1364,8 @@ private boolean isCurrentObjectATrailer() {
         try {
             final PdfDictionary dic = (PdfDictionary) readObject(false);
             return dic.get(PdfName.Root, false) != null;
+        } catch (MemoryLimitsAwareException e){
+            throw e;
         } catch (Exception e) {
             return false;
         }
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/canvas/PdfCanvas.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/canvas/PdfCanvas.java
@@ -36,6 +36,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.colors.DeviceGray;
 import com.itextpdf.kernel.colors.PatternColor;
 import com.itextpdf.kernel.exceptions.KernelExceptionMessageConstant;
+import com.itextpdf.kernel.exceptions.MemoryLimitsAwareException;
 import com.itextpdf.kernel.exceptions.PdfException;
 import com.itextpdf.kernel.font.PdfFont;
 import com.itextpdf.kernel.font.PdfType0Font;
@@ -2400,8 +2401,10 @@ private PdfStream ensureStreamDataIsReadyToBeProcessed(PdfStream stream) {
             if (stream.getOutputStream() == null || stream.containsKey(PdfName.Filter)) {
                 try {
                     stream.setData(stream.getBytes());
-                } catch (Exception ex) {
-                    // ignore
+                } catch (MemoryLimitsAwareException e){
+                    throw e;
+                } catch (Exception e) {
+                    // ignored
                 }
             }
         }
diff --git a/kernel/src/main/java/com/itextpdf/kernel/pdf/tagging/StandardNamespaces.java b/kernel/src/main/java/com/itextpdf/kernel/pdf/tagging/StandardNamespaces.java
@@ -201,7 +201,7 @@ public static boolean isHnRole(String role) {
         if (role.startsWith("H") && role.length() > 1 && role.charAt(1) != '0') {
             try {
                 return Integer.parseInt(role.substring(1, role.length())) > 0;
-            } catch (Exception ex) {
+            } catch (Exception e) {
                 // ignored
             }
         }
diff --git a/kernel/src/main/java/com/itextpdf/kernel/utils/CompareTool.java b/kernel/src/main/java/com/itextpdf/kernel/utils/CompareTool.java
@@ -802,7 +802,7 @@ public String compareXmp(String outPdf, String cmpPdf, boolean ignoreDateAndProd
             if (!compareXmls(cmpBytes, outBytes)) {
                 return "The XMP packages different!";
             }
-        } catch (Exception ex) {
+        } catch (Exception e) {
             return "XMP parsing failure!";
         }
         return null;
diff --git a/kernel/src/test/java/com/itextpdf/kernel/colors/WebColorsTest.java b/kernel/src/test/java/com/itextpdf/kernel/colors/WebColorsTest.java
@@ -198,6 +198,15 @@ public void getCMYKColorWithExceptionDuringParsing() {
         Assert.assertNull(resultCmyk);
     }
 
+
+    @Test
+    public void getRGBAColorWithExceptionDuringParsing() {
+        float[] resultCmyk = WebColors.getRGBAColor(null);
+        Assert.assertNull(resultCmyk);
+    }
+
+
+
     @Test
     public void getCMYKColorTest() {
         //corresponding color name = "violet"
diff --git a/kernel/src/test/java/com/itextpdf/kernel/crypto/securityhandler/EncryptionUtilsTest.java b/kernel/src/test/java/com/itextpdf/kernel/crypto/securityhandler/EncryptionUtilsTest.java
@@ -0,0 +1,19 @@
+package com.itextpdf.kernel.crypto.securityhandler;
+
+import com.itextpdf.kernel.exceptions.PdfException;
+import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.annotations.type.UnitTest;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category(UnitTest.class)
+public class EncryptionUtilsTest extends ExtendedITextTest {
+
+    @Test
+    public void fetchEnvelopedDataThrows() {
+        Assert.assertThrows(Exception.class, () -> EncryptionUtils.fetchEnvelopedData(null, null, null, null, null));
+    }
+
+}
diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfReaderTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfReaderTest.java
@@ -2816,6 +2816,25 @@ public void newPdfReaderConstructorPropertiesTest() throws IOException {
         Assert.assertEquals(PdfObject.STREAM, pdfDoc.getPdfObject(5).getType());
     }
 
+    @Test
+    public void initTagTreeStructureThrowsOOMIsCatched() throws IOException {
+        File file = new File(SOURCE_FOLDER+ "big_table_lot_of_mcrs.pdf");
+        MemoryLimitsAwareHandler memoryLimitsAwareHandler = new MemoryLimitsAwareHandler() {
+            @Override
+            public boolean isMemoryLimitsAwarenessRequiredOnDecompression(PdfArray filters) {
+                return true;
+            }
+        };
+        memoryLimitsAwareHandler.setMaxSizeOfDecompressedPdfStreamsSum(100000);
+
+        Assert.assertThrows(MemoryLimitsAwareException.class, () -> {
+            try (final PdfReader reader = new PdfReader(file,
+                    new ReaderProperties().setMemoryLimitsAwareHandler(memoryLimitsAwareHandler));
+                    final PdfDocument document = new PdfDocument(reader);) {
+            }
+        });
+    }
+
     private static PdfDictionary getTestPdfDictionary() {
         HashMap<PdfName, PdfObject> tmpMap = new HashMap<PdfName, PdfObject>();
         tmpMap.put(new PdfName("b"), new PdfName("c"));
diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfWriterTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfWriterTest.java
@@ -535,7 +535,8 @@ public void closeStream1() throws IOException {
         try {
             fos.write(1);
             Assert.fail("Exception expected");
-        } catch (Exception ignored) {
+        } catch (Exception e) {
+            //ignored
         }
     }
 
diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfXrefTableTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/PdfXrefTableTest.java
@@ -24,6 +24,7 @@ This file is part of the iText (R) project.
 
 import com.itextpdf.io.logs.IoLogMessageConstant;
 import com.itextpdf.kernel.exceptions.KernelExceptionMessageConstant;
+import com.itextpdf.kernel.exceptions.MemoryLimitsAwareException;
 import com.itextpdf.kernel.exceptions.PdfException;
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.AssertUtil;
@@ -63,7 +64,22 @@ public static void afterClass() {
     })
     public void openInvalidDocWithHugeRefTest() {
         String inputFile = SOURCE_FOLDER + "invalidDocWithHugeRef.pdf";
-        AssertUtil.doesNotThrow(() -> new PdfDocument(new PdfReader(inputFile)));
+        MemoryLimitsAwareHandler memoryLimitsAwareHandler = new MemoryLimitsAwareHandler(){
+            @Override
+            public void checkIfXrefStructureExceedsTheLimit(int requestedCapacity) {
+            }
+        };
+        AssertUtil.doesNotThrow(() -> new PdfDocument(new PdfReader(inputFile, new ReaderProperties().setMemoryLimitsAwareHandler(memoryLimitsAwareHandler))));
+    }
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = IoLogMessageConstant.XREF_ERROR_WHILE_READING_TABLE_WILL_BE_REBUILT, logLevel = LogLevelConstants.ERROR)
+    })
+    public void openInvalidDocWithHugeRefTestDefaultMemoryLimitAwareHandler() {
+        String inputFile = SOURCE_FOLDER + "invalidDocWithHugeRef.pdf";
+        Assert.assertThrows(MemoryLimitsAwareException.class,() ->
+                new PdfDocument(new PdfReader(inputFile)));
     }
 
     @Test
diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/canvas/PdfCanvasTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/canvas/PdfCanvasTest.java
@@ -31,13 +31,15 @@ This file is part of the iText (R) project.
 import com.itextpdf.io.util.UrlUtil;
 import com.itextpdf.kernel.colors.ColorConstants;
 import com.itextpdf.kernel.exceptions.KernelExceptionMessageConstant;
+import com.itextpdf.kernel.exceptions.MemoryLimitsAwareException;
 import com.itextpdf.kernel.exceptions.PdfException;
 import com.itextpdf.kernel.font.PdfFontFactory;
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.kernel.pdf.*;
 import com.itextpdf.kernel.pdf.canvas.wmf.WmfImageData;
 import com.itextpdf.kernel.pdf.extgstate.PdfExtGState;
 import com.itextpdf.kernel.utils.CompareTool;
+import com.itextpdf.test.AssertUtil;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
 
@@ -1104,6 +1106,49 @@ public void canvasInitializationStampingExistingStream() throws IOException, Int
         Assert.assertNull(new CompareTool().compareByContent(destFile, cmpFile, DESTINATION_FOLDER, "diff_"));
     }
 
+    @Test
+    public  void canvasStreamFlushedNoException(){
+        PdfDocument doc =new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
+        PdfStream stream = new PdfStream(){
+            private boolean isFlushed = false;
+            @Override
+            public boolean isFlushed() {
+                System.out.println("isFlushed: " + isFlushed);
+                if (isFlushed){
+                    return true;
+                }
+                isFlushed = true;
+                return false;
+            }
+        };
+        stream.put(PdfName.Filter, new PdfName("FlateDecode"));
+        AssertUtil.doesNotThrow(()->{
+            new PdfCanvas(stream, new PdfResources(),doc );
+        });
+    }
+
+    @Test
+    public void canvasInitializationStampingExistingStreamMemoryLimitAware() throws IOException, InterruptedException {
+        String srcFile = SOURCE_FOLDER + "pageWithContent.pdf";
+
+        ReaderProperties properties = new ReaderProperties();
+        MemoryLimitsAwareHandler handler = new MemoryLimitsAwareHandler(){
+            @Override
+            public boolean isMemoryLimitsAwarenessRequiredOnDecompression(PdfArray filters) {
+                return true;
+            };
+        };
+        handler.setMaxSizeOfSingleDecompressedPdfStream(1);
+        properties.setMemoryLimitsAwareHandler(handler);
+
+        PdfDocument document = new PdfDocument(new PdfReader(srcFile, properties));
+
+        PdfPage page = document.getPage(1);
+        Assert.assertThrows(MemoryLimitsAwareException.class, () ->{
+            new PdfCanvas(page.getLastContentStream(), page.getResources(), page.getDocument());
+        });
+    }
+
     @Test
     public void canvasStampingJustCopiedStreamWithCompression() throws IOException, InterruptedException {
         String srcFile = SOURCE_FOLDER + "pageWithContent.pdf";
diff --git a/kernel/src/test/java/com/itextpdf/kernel/pdf/tagging/StandardNamespacesTest.java b/kernel/src/test/java/com/itextpdf/kernel/pdf/tagging/StandardNamespacesTest.java
@@ -0,0 +1,22 @@
+package com.itextpdf.kernel.pdf.tagging;
+
+import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.annotations.type.UnitTest;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import static org.junit.Assert.*;
+
+@Category(UnitTest.class)
+public class StandardNamespacesTest extends ExtendedITextTest {
+
+    @Test
+    public void testHn01() {
+        assertTrue(StandardNamespaces.isHnRole("H1"));
+    }
+
+    @Test
+    public void testHn02() {
+        assertFalse(StandardNamespaces.isHnRole("H1,2"));
+    }
+}
diff --git a/kernel/src/test/java/com/itextpdf/kernel/utils/CompareToolTest.java b/kernel/src/test/java/com/itextpdf/kernel/utils/CompareToolTest.java
diff --git a/kernel/src/test/resources/com/itextpdf/kernel/pdf/PdfReaderTest/big_table_lot_of_mcrs.pdf b/kernel/src/test/resources/com/itextpdf/kernel/pdf/PdfReaderTest/big_table_lot_of_mcrs.pdf

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ public static float[] getCMYKArray(String name) {`
`248`	`248`	`color[4] = getAlphaChannelValue(tok.nextToken());`
`249`	`249`	`}`
`250`	`250`	`}`
`251`		`- } catch (Exception exc) {`
	`251`	`+ } catch (Exception e) {`
`252`	`252`	`// Will just return null in this case`
`253`	`253`	`color = null;`
`254`	`254`	`}`
`@@ -309,7 +309,7 @@ public static float[] getRGBAColor(String name) {`
`309`	`309`	`color[1] = (float) (intColor[1] / RGB_MAX_VAL);`
`310`	`310`	`color[2] = (float) (intColor[2] / RGB_MAX_VAL);`
`311`	`311`	`}`
`312`		`- } catch (Exception exc) {`
	`312`	`+ } catch (Exception e) {`
`313`	`313`	`// Will just return null in this case`
`314`	`314`	`color = null;`
`315`	`315`	`}`
Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,8 @@ static byte[] fetchEnvelopedData(Key certificateKey, Certificate certificate, St`
`105`	`105`	`IX509CertificateHolder certHolder;`
`106`	`106`	`try {`
`107`	`107`	`certHolder = BOUNCY_CASTLE_FACTORY.createX509CertificateHolder(certificate.getEncoded());`
`108`		`- } catch (Exception f) {`
`109`		`- throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, f);`
	`108`	`+ } catch (Exception e) {`
	`109`	`+ throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, e);`
`110`	`110`	`}`
`111`	`111`	`if (externalDecryptionProcess == null) {`
`112`	`112`	`for (int i = 0; i < recipients.size(); i++) {`
`@@ -125,12 +125,12 @@ static byte[] fetchEnvelopedData(Key certificateKey, Certificate certificate, St`
`125`	`125`	`foundRecipient = true;`
`126`	`126`	`}`
`127`	`127`	`}`
`128`		`- } catch (Exception f) {`
	`128`	`+ } catch (Exception e) {`
`129`	`129`	`// First check if the feature is supported, it will throw if not`
`130`	`130`	`// Exact algorithm doesn't matter currently`
`131`	`131`	`BouncyCastleFactoryCreator.getFactory().isEncryptionFeatureSupported(0, true);`
`132`	`132`	`// Throw the original exception if the feature is supported`
`133`		`- throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, f);`
	`133`	`+ throw new PdfException(KernelExceptionMessageConstant.PDF_DECRYPTION, e);`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`	`} else {`
Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@ private void addGlyphsFromCharProcs(PdfDictionary charProcsDic, int[] widths) {`
`460`	`460`	`}`
`461`	`461`	`Map<Integer, Integer> unicodeToCode = null;`
`462`	`462`	`if (getToUnicode() != null) {`
`463`		`- try { unicodeToCode = getToUnicode().createReverseMapping(); } catch (Exception ignored) {}`
	`463`	`+ try { unicodeToCode = getToUnicode().createReverseMapping(); } catch (Exception e) {/ignored/}`
`464`	`464`	`}`
`465`	`465`
`466`	`466`	`for (PdfName glyphName : charProcsDic.keySet()) {`
Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ public static void copyOCGProperties(PdfDocument fromDocument, PdfDocument toDoc`
`67`	`67`
`68`	`68`	`OcgPropertiesCopier.copyDDictionary(fromOcgsToCopy, fromOcProperties.getAsDictionary(PdfName.D),`
`69`	`69`	`toOcProperties, toDocument);`
`70`		`- } catch (Exception ex) {`
`71`		`- LOGGER.error(MessageFormatUtil.format(IoLogMessageConstant.OCG_COPYING_ERROR, ex.toString()));`
	`70`	`+ } catch (Exception e) {`
	`71`	`+ LOGGER.error(MessageFormatUtil.format(IoLogMessageConstant.OCG_COPYING_ERROR, e.toString()));`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -1257,9 +1257,9 @@ void tryFlushPageTags() {`
`1257`	`1257`	`getDocument().getTagStructureContext().flushPageTags(this);`
`1258`	`1258`	`}`
`1259`	`1259`	`getDocument().getStructTreeRoot().savePageStructParentIndexIfNeeded(this);`
`1260`		`- } catch (Exception ex) {`
	`1260`	`+ } catch (Exception e) {`
`1261`	`1261`	`throw new PdfException(`
`1262`		`- KernelExceptionMessageConstant.TAG_STRUCTURE_FLUSHING_FAILED_IT_MIGHT_BE_CORRUPTED, ex);`
	`1262`	`+ KernelExceptionMessageConstant.TAG_STRUCTURE_FLUSHING_FAILED_IT_MIGHT_BE_CORRUPTED, e);`
`1263`	`1263`	`}`
`1264`	`1264`	`}`
`1265`	`1265`
Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ public static boolean isHnRole(String role) {`
`201`	`201`	`if (role.startsWith("H") && role.length() > 1 && role.charAt(1) != '0') {`
`202`	`202`	`try {`
`203`	`203`	`return Integer.parseInt(role.substring(1, role.length())) > 0;`
`204`		`- } catch (Exception ex) {`
	`204`	`+ } catch (Exception e) {`
`205`	`205`	`// ignored`
`206`	`206`	`}`
`207`	`207`	`}`
Original file line number	Diff line number	Diff line change
`@@ -802,7 +802,7 @@ public String compareXmp(String outPdf, String cmpPdf, boolean ignoreDateAndProd`
`802`	`802`	`if (!compareXmls(cmpBytes, outBytes)) {`
`803`	`803`	`return "The XMP packages different!";`
`804`	`804`	`}`
`805`		`- } catch (Exception ex) {`
	`805`	`+ } catch (Exception e) {`
`806`	`806`	`return "XMP parsing failure!";`
`807`	`807`	`}`
`808`	`808`	`return null;`