Reinitialize form field appearance stream object on every field regeneration

First, appearance stream objects might be shared between different forms fields or other entities, if they are identical, so on regeneration we should not affect those other entities.

Second, the resources of the streams and other entries in stream dictionaries are not shared between regenerations. It seems that this makes sense, because resources are completely rebuilt every time, and all other important entries in the appearance stream are updated on regeneration as well.

DEVSIX-2374

Author: yulian-gaponenko

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -2026,13 +2026,7 @@ public boolean regenerateField() {
                     bBox = new PdfArray(rect);
                 }
                 //Create appearance
-                AppearanceXObject appearance = null;
-                if (asNormal != null) {
-                    appearance = new AppearanceXObject(asNormal);
-                    appearance.setBBox(new PdfArray(new float[]{0, 0, bBox.toRectangle().getWidth(), bBox.toRectangle().getHeight()}));
-                } else {
-                    appearance = new AppearanceXObject(new Rectangle(0, 0, bBox.toRectangle().getWidth(), bBox.toRectangle().getHeight()));
-                }
+                AppearanceXObject appearance = new AppearanceXObject(new Rectangle(0, 0, bBox.toRectangle().getWidth(), bBox.toRectangle().getHeight()));
                 appearance.addFontFromDR(localFontName, localFont);
                 appearance.put(PdfName.Matrix, matrix);
                 //Create text appearance

forms/src/test/java/com/itextpdf/forms/PdfFormCopyTest.java

@@ -277,6 +277,37 @@ public void copyMultipleSubfieldsTest03() throws IOException, InterruptedExcepti
         Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyMultipleSubfieldsTest03.pdf", destinationFolder, "diff_"));
     }
 
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 12)
+    })
+    public void copyMultipleSubfieldsSmartModeTest01() throws IOException, InterruptedException {
+        String srcFilename = sourceFolder + "copyMultipleSubfieldsSmartModeTest01.pdf";
+        String destFilename = destinationFolder + "copyMultipleSubfieldsSmartModeTest01.pdf";
+
+        PdfDocument srcDoc = new PdfDocument(new PdfReader(srcFilename));
+        PdfDocument destDoc = new PdfDocument(new PdfWriter(destFilename).setSmartMode(true));
+
+        PdfPageFormCopier pdfPageFormCopier = new PdfPageFormCopier();
+        // copying the same page from the same document twice
+        for (int i = 0; i < 4; ++i) {
+            srcDoc.copyPagesTo(1, 1, destDoc, pdfPageFormCopier);
+        }
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(destDoc, false);
+
+        acroForm.getField("text_1").setValue("Text 1!");
+        acroForm.getField("text_2").setValue("Text 2!");
+        acroForm.getField("text.3").setValue("Text 3!");
+        acroForm.getField("text.4").setValue("Text 4!");
+
+        destDoc.close();
+        srcDoc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyMultipleSubfieldsSmartModeTest01.pdf", destinationFolder, "diff_"));
+    }
+
     @Test
     @LogMessages(messages = {
             @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 13)

forms/src/test/java/com/itextpdf/forms/PdfFormFieldTest.java

@@ -647,4 +647,29 @@ public void multilineFormFieldNewLineTest() throws IOException, InterruptedExcep
             Assert.fail(errorMessage);
         }
     }
+
+    @Test
+    public void fillFormWithSameEmptyObjsForAppearance() throws IOException, InterruptedException {
+        String outPdf = destinationFolder + "fillFormWithSameEmptyObjsForAppearance.pdf";
+        String cmpPdf = sourceFolder + "cmp_fillFormWithSameEmptyObjsForAppearance.pdf";
+
+        PdfWriter writer = new PdfWriter(outPdf);
+        PdfReader reader = new PdfReader(sourceFolder + "fillFormWithSameEmptyObjsForAppearance.pdf");
+        PdfDocument pdfDoc = new PdfDocument(reader, writer);
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(pdfDoc, false);
+
+        acroForm.getField("text_1").setValue("Text 1!");
+        acroForm.getField("text_2").setValue("Text 2!");
+        acroForm.getField("text.3").setValue("Text 3!");
+        acroForm.getField("text.4").setValue("Text 4!");
+
+        pdfDoc.close();
+
+        CompareTool compareTool = new CompareTool();
+        String errorMessage = compareTool.compareByContent(outPdf, cmpPdf, destinationFolder, "diff_");
+        if (errorMessage != null) {
+            Assert.fail(errorMessage);
+        }
+    }
 }