Skip to content

Commit 7ee4b0b

Browse files
committed
Minor changes in #equals for PDF primitive objects.
DEVSIX-851
1 parent 58eaa3c commit 7ee4b0b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfBoolean.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ protected void copyContent(PdfObject from, PdfDocument document) {
156156
@Override
157157
public boolean equals(Object obj) {
158158
return this == obj ||
159-
!(obj == null || getClass() != obj.getClass()) && value == ((PdfBoolean) obj).value;
159+
obj != null && getClass() == obj.getClass() && value == ((PdfBoolean) obj).value;
160160
}
161161

162162
@Override

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfLiteral.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ protected void generateContent() {
105105
@Override
106106
public boolean equals(Object o) {
107107
return this == o ||
108-
!(o == null || getClass() != o.getClass()) && Arrays.equals(content, ((PdfLiteral) o).content);
108+
o != null && getClass() == o.getClass() && Arrays.equals(content, ((PdfLiteral) o).content);
109109
}
110110

111111
@Override

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfNull.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ protected void copyContent(PdfObject from, PdfDocument document) {
147147

148148
@Override
149149
public boolean equals(Object obj) {
150-
return this == obj || !(obj == null || getClass() != obj.getClass());
150+
return this == obj || obj != null && getClass() == obj.getClass();
151151
}
152152

153153
@Override

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfNumber.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ public String toString() {
191191
@Override
192192
public boolean equals(Object o) {
193193
return this == o ||
194-
!(o == null || getClass() != o.getClass()) && Double.compare(((PdfNumber) o).value, value) == 0;
194+
o != null && getClass() == o.getClass() && Double.compare(((PdfNumber) o).value, value) == 0;
195195
}
196196

197197
@Override

0 commit comments

Comments
 (0)