Improve large tables processing. Add tests.

Process large tables on different areas the same way as usual tables.
Process large tables with custom width.
Prohibit adding new content to completed large table.
Remove last flushed row group from completed table. Fix a test.

DEVSIX-1646

Author: ars18wrw

kernel/src/main/java/com/itextpdf/kernel/PdfException.java

@@ -67,6 +67,7 @@ public class PdfException extends RuntimeException {
     public static final String BadCertificateAndKey = "Bad public key certificate and/or private key.";
     public static final String BadUserPassword = "Bad user password. Password is not provided or wrong password provided. Correct password should be passed to PdfReader constructor with properties. See ReaderProperties#setPassword() method.";
 
+    public static final String CannotAddCellToCompletedLargeTable = "The large table was completed. It's prohibited to use it anymore. Created different Table instance instead.";
     public static final String CannotAddKidToTheFlushedElement = "Cannot add kid to the flushed element.";
     public static final String CannotAddNonDictionaryExtGStateToResources1 = "Cannot add graphic state to resources. The PdfObject type is {0}, but should be PdfDictionary.";
     public static final String CannotAddNonDictionaryPatternToResources1 = "Cannot add pattern to resources. The PdfObject type is {0}, but should be PdfDictionary or PdfStream.";

layout/src/main/java/com/itextpdf/layout/element/Table.java

@@ -43,6 +43,7 @@ This file is part of the iText (R) project.
  */
 package com.itextpdf.layout.element;
 
+import com.itextpdf.kernel.PdfException;
 import com.itextpdf.kernel.pdf.PdfName;
 import com.itextpdf.kernel.pdf.tagutils.AccessibilityProperties;
 import com.itextpdf.layout.Document;
@@ -579,6 +580,9 @@ public Table startNewRow() {
      * @return this element
      */
     public Table addCell(Cell cell) {
+        if (isComplete && null != lastAddedRow) {
+            throw new PdfException(PdfException.CannotAddCellToCompletedLargeTable);
+        }
         // Try to find first empty slot in table.
         // We shall not use colspan or rowspan, 1x1 will be enough.
         while (true) {
@@ -707,7 +711,16 @@ public IRenderer getRenderer() {
         }
         // In case of large tables, we only add to the renderer the cells from complete row groups,
         // for incomplete ones we may have problem with partial rendering because of cross-dependency.
-        lastAddedRowGroups = isComplete ? null : getRowGroups();
+        if (isComplete) {
+            // if table was large we need to remove the last flushed group of rows, so we need to update lastAddedRowGroups
+            if (null != lastAddedRow && 0 != rows.size()) {
+                List<RowRange> allRows = new ArrayList<>();
+                allRows.add(new RowRange(rowWindowStart, rowWindowStart + rows.size() - 1));
+                lastAddedRowGroups = allRows;
+            }
+        } else {
+            lastAddedRowGroups = getRowGroups();
+        }
         if (isComplete) {
             return new TableRenderer(this, new RowRange(rowWindowStart, rowWindowStart + rows.size() - 1));
         } else {

layout/src/main/java/com/itextpdf/layout/renderer/AbstractRenderer.java

@@ -1302,11 +1302,11 @@ void updateMinHeight(UnitValue updatedMinHeight) {
         setProperty(Property.MIN_HEIGHT, updatedMinHeight);
     }
 
-    protected Float retrieveUnitValue(float basePercentValue, int property) {
+    protected Float retrieveUnitValue(float baseValue, int property) {
         UnitValue value = this.<UnitValue>getProperty(property);
         if (value != null) {
             if (value.getUnitType() == UnitValue.PERCENT) {
-                return value.getValue() * basePercentValue / 100;
+                return baseValue * value.getValue() / 100;
             } else {
                 assert value.getUnitType() == UnitValue.POINT;
                 return value.getValue();

layout/src/main/java/com/itextpdf/layout/renderer/AccessibleAttributesApplier.java

@@ -57,12 +57,13 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.tagutils.AccessibilityProperties;
 import com.itextpdf.kernel.pdf.tagutils.IAccessibleElement;
 import com.itextpdf.kernel.pdf.tagutils.TagTreePointer;
+import com.itextpdf.layout.element.Cell;
+import com.itextpdf.layout.element.Table;
 import com.itextpdf.layout.property.Background;
 import com.itextpdf.layout.property.HorizontalAlignment;
 import com.itextpdf.layout.property.ListNumberingType;
 import com.itextpdf.layout.property.Property;
 import com.itextpdf.layout.border.Border;
-import com.itextpdf.layout.element.Cell;
 import com.itextpdf.layout.property.TextAlignment;
 import com.itextpdf.layout.property.TransparentColor;
 import com.itextpdf.layout.property.Underline;
@@ -252,9 +253,12 @@ private static void applyBlockLevelLayoutAttributes(PdfName role, AbstractRender
         }
 
         if (role.equals(PdfName.TH) || role.equals(PdfName.TD) || role.equals(PdfName.Table)) {
-            UnitValue width = renderer.<UnitValue>getProperty(Property.WIDTH);
-            if (width != null && width.isPointValue()) {
-                attributes.put(PdfName.Width, new PdfNumber(width.getValue()));
+            // For large tables the width can be changed from flush to flush so the Width attribute shouldn't be applied
+            if (renderer instanceof TableRenderer && ((Table) renderer.getModelElement()).isComplete()) {
+                UnitValue width = renderer.<UnitValue>getProperty(Property.WIDTH);
+                if (width != null && width.isPointValue()) {
+                    attributes.put(PdfName.Width, new PdfNumber(width.getValue()));
+                }
             }
 
             Float height = renderer.getPropertyAsFloat(Property.HEIGHT);

layout/src/main/java/com/itextpdf/layout/renderer/TableWidths.java

@@ -462,7 +462,7 @@ float[] fixedLayout() {
         CellRenderer[] firtsRow;
         if (tableRenderer.headerRenderer != null && tableRenderer.headerRenderer.rows.size() > 0) {
             firtsRow = tableRenderer.headerRenderer.rows.get(0);
-        } else if (tableRenderer.rows.size() > 0) {
+        } else if (tableRenderer.rows.size() > 0 && getTable().isComplete() && 0 == getTable().getLastRowBottomBorder().size()) {
             firtsRow = tableRenderer.rows.get(0);
         } else {
             //most likely it is large table
@@ -536,6 +536,11 @@ private void calculateTableWidth(float availableWidth, boolean calculateTableMax
                 .<String>getProperty(Property.TABLE_LAYOUT, "auto").toLowerCase());
         UnitValue width = tableRenderer.<UnitValue>getProperty(Property.WIDTH);
         if (fixedTableLayout && width != null && width.getValue() >= 0) {
+            if (0 != getTable().getLastRowBottomBorder().size()) {
+                width = getTable().getWidth();
+            } else if (!getTable().isComplete() && null != getTable().getWidth() && getTable().getWidth().isPercentValue()) {
+                getTable().setWidth(tableRenderer.retrieveUnitValue(availableWidth, Property.WIDTH));
+            }
             fixedTableWidth = true;
             tableWidth = (float) retrieveTableWidth(width, availableWidth);
             layoutMinWidth = width.isPercentValue() ? 0 : tableWidth;