Made PdfDocument.getSerializedBytes() log errors via SLF4J.

Changed CompareTool.compareByCatalog() exception logic.

Author: IdamkinI

io/src/main/java/com/itextpdf/io/LogMessageConstant.java

@@ -54,6 +54,11 @@ public class LogMessageConstant {
      */
     public static final String DOCUMENT_ALREADY_HAS_FIELD = "The document already has field {0}. Annotations of the fields with this name will be added to the existing one as children. If you want to have separate fields, please, rename them manually before copying.";
 
+    /**
+     * Log message.
+     */
+    public static final String DOCUMENT_SERIALIZATION_EXCEPTION_RAISED = "Unhandled exception while serialization";
+
     /**
      * Log message.
      */

kernel/src/main/java/com/itextpdf/kernel/pdf/PdfDocument.java

@@ -76,6 +76,9 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class PdfDocument implements IEventDispatcher, Closeable, Serializable {
 
     private static final long serialVersionUID = -7041578979319799646L;
@@ -1570,21 +1573,20 @@ private byte[] getSerializedBytes() {
             oos.flush();
             return bos.toByteArray();
         } catch (Exception e) {
-            e.printStackTrace();
+            Logger logger = LoggerFactory.getLogger(PdfDocument.class);
+            logger.warn(LogMessageConstant.DOCUMENT_SERIALIZATION_EXCEPTION_RAISED, e);
             return null;
         } finally {
             if (oos != null) {
                 try {
                     oos.close();
-                } catch (IOException e) {
-                    e.printStackTrace();
+                } catch (IOException ignored) {
                 }
             }
             if (bos != null) {
                 try {
                     bos.close();
-                } catch (IOException e) {
-                    e.printStackTrace();
+                } catch (IOException ignored) {
                 }
             }
         }

kernel/src/main/java/com/itextpdf/kernel/utils/CompareTool.java

@@ -107,18 +107,14 @@ public CompareTool() {
         compareExec = System.getProperty("compareExec");
     }
 
-    public CompareResult compareByCatalog(PdfDocument outDocument, PdfDocument cmpDocument) {
+    public CompareResult compareByCatalog(PdfDocument outDocument, PdfDocument cmpDocument) throws IOException {
         CompareResult compareResult = null;
-        try {
-            compareResult = new CompareResult(compareByContentErrorsLimit);
-            ObjectPath catalogPath = new ObjectPath(cmpDocument.getCatalog().getPdfObject().getIndirectReference(),
-                    outDocument.getCatalog().getPdfObject().getIndirectReference());
-            Set<PdfName> ignoredCatalogEntries = new LinkedHashSet<>(Arrays.asList(PdfName.Metadata, PdfName.AcroForm));
-            compareDictionariesExtended(outDocument.getCatalog().getPdfObject(), cmpDocument.getCatalog().getPdfObject(),
-                    catalogPath, compareResult, ignoredCatalogEntries);
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+        compareResult = new CompareResult(compareByContentErrorsLimit);
+        ObjectPath catalogPath = new ObjectPath(cmpDocument.getCatalog().getPdfObject().getIndirectReference(),
+                outDocument.getCatalog().getPdfObject().getIndirectReference());
+        Set<PdfName> ignoredCatalogEntries = new LinkedHashSet<>(Arrays.asList(PdfName.Metadata, PdfName.AcroForm));
+        compareDictionariesExtended(outDocument.getCatalog().getPdfObject(), cmpDocument.getCatalog().getPdfObject(),
+                catalogPath, compareResult, ignoredCatalogEntries);
         return compareResult;
     }