Avoid using Assert.assertSame for enums and primitive types

There is a difference in how Java and .NET implement this assertion
and it does not make a lot of sense for primitives or enums anyway

DEVSIX-3585

Author: Snipx

kernel/src/test/java/com/itextpdf/kernel/pdf/PdfTokenizerTest.java

@@ -231,104 +231,104 @@ public void primitivesTest() throws Exception {
         PdfTokenizer tok = new PdfTokenizer(new RandomAccessFileOrArray(factory.createSource(data.getBytes(StandardCharsets.ISO_8859_1))));
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.StartDic);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.StartDic);
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         PdfName name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Size", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         PdfNumber num = new PdfNumber(tok.getByteContent());
         Assert.assertEquals("70.", num.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Value ", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         num = new PdfNumber(tok.getByteContent());
         Assert.assertNotSame("0.1", num.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Root", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Ref);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Ref);
         PdfIndirectReference ref = new PdfIndirectReference(null, tok.getObjNr(), tok.getGenNr());
         Assert.assertEquals("46 0 R", ref.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Info", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Ref);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Ref);
         ref = new PdfIndirectReference(null, tok.getObjNr(), tok.getGenNr());
         Assert.assertEquals("44 0 R", ref.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("ID", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.StartArray);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.StartArray);
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.String);
-        Assert.assertSame(tok.isHexString(), true);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.String);
+        Assert.assertTrue(tok.isHexString());
         PdfString str = new PdfString(tok.getByteContent(), tok.isHexString());
         Assert.assertEquals("some hex string ", str.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.String);
-        Assert.assertSame(tok.isHexString(), false);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.String);
+        Assert.assertFalse(tok.isHexString());
         str = new PdfString(tok.getByteContent(), tok.isHexString());
         Assert.assertEquals("some simple string ", str.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.String);
-        Assert.assertSame(tok.isHexString(), true);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.String);
+        Assert.assertTrue(tok.isHexString());
         str = new PdfString(tok.getByteContent(), tok.isHexString());
         Assert.assertEquals("\u008C%G\u00D5\u008DK\u00D2\u00C6\u00F3\u00D3+\u0083\u000B\u00E3%\u009D ", str.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         num = new PdfNumber(tok.getByteContent());
         Assert.assertEquals("-70.1", num.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         num = new PdfNumber(tok.getByteContent());
         Assert.assertEquals("-0.2", num.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.EndArray);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.EndArray);
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Name1", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         num = new PdfNumber(tok.getByteContent());
         Assert.assertEquals("0", num.toString());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Name);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Name);
         name = new PdfName(tok.getByteContent());
         Assert.assertEquals("Prev", name.getValue());
 
         tok.nextValidToken();
-        Assert.assertSame(tok.getTokenType(), PdfTokenizer.TokenType.Number);
+        Assert.assertEquals(tok.getTokenType(), PdfTokenizer.TokenType.Number);
         num = new PdfNumber(tok.getByteContent());
         Assert.assertEquals("-116.23", num.toString());
     }