Wrap negative offsets in datamatrix

Add tests for IndexOutOfBounds
Update width&height samples in javadocs.

DEVSIX-1845

Author: pavel-alay

barcodes/src/main/java/com/itextpdf/barcodes/BarcodeDataMatrix.java

@@ -402,24 +402,25 @@ public int getHeight() {
     }
 
     /**
-     * Sets the height of the barcode. If the height is zero it will be calculated. This height doesn't include the whitespace border, if any.
+     * Sets the height of the barcode. If the height is zero it will be calculated.
+     * This height doesn't include the whitespace border, if any.
      *
-     * The allowed dimensions are (height, width):<p>
+     * The allowed dimensions are (width, height):<p>
      * 10, 10<br>
      * 12, 12<br>
-     * 8, 18<br>
+     * 18, 8<br>
      * 14, 14<br>
-     * 8, 32<br>
+     * 32, 8<br>
      * 16, 16<br>
-     * 12, 26<br>
+     * 26, 12<br>
      * 18, 18<br>
      * 20, 20<br>
-     * 12, 36<br>
+     * 36, 12<br>
      * 22, 22<br>
-     * 16, 36<br>
+     * 36, 16<br>
      * 24, 24<br>
      * 26, 26<br>
-     * 16, 48<br>
+     * 48, 16<br>
      * 32, 32<br>
      * 36, 36<br>
      * 40, 40<br>
@@ -453,24 +454,25 @@ public int getWidth() {
     }
 
     /**
-     * Sets the width of the barcode. If the width is zero it will be calculated. This width doesn't include the whitespace border, if any.
+     * Sets the width of the barcode. If the width is zero it will be calculated.
+     * This width doesn't include the whitespace border, if any.
      *
-     * The allowed dimensions are (height, width):<p>
+     * The allowed dimensions are (width, height):<p>
      * 10, 10<br>
      * 12, 12<br>
-     * 8, 18<br>
+     * 18, 8<br>
      * 14, 14<br>
-     * 8, 32<br>
+     * 32, 8<br>
      * 16, 16<br>
-     * 12, 26<br>
+     * 26, 12<br>
      * 18, 18<br>
      * 20, 20<br>
-     * 12, 36<br>
+     * 36, 12<br>
      * 22, 22<br>
-     * 16, 36<br>
+     * 36, 16<br>
      * 24, 24<br>
      * 26, 26<br>
-     * 16, 48<br>
+     * 48, 16<br>
      * 32, 32<br>
      * 36, 36<br>
      * 40, 40<br>
@@ -1072,7 +1074,7 @@ private int C40OrTextEncodation(byte[] text, int textOffset, int textLength, byt
                         if (j == 1)
                             dataOffsetNew = requiredCapacityForASCII;
                     }
-                    addLatch = unlatch < 0 ? true : (dataOffset - requiredCapacityForASCII != unlatch);
+                    addLatch = (unlatch < 0) || ((dataOffset - requiredCapacityForASCII) != unlatch);
                     if (requiredCapacityForC40orText % 3 == 0 &&
                             requiredCapacityForC40orText / 3 * 2 + (addLatch ? 2 : 0) < requiredCapacityForASCII) {
                         usingASCII = false;
@@ -1086,15 +1088,17 @@ private int C40OrTextEncodation(byte[] text, int textOffset, int textLength, byt
                         i--;
                 }
             }
-        } else if (symbolIndex != -1)
+        } else if (symbolIndex != -1) {
             usingASCII = true;
-        if (usingASCII)
+        }
+        if (dataOffset < 0) {
+            return -1;
+        }
+        if (usingASCII) {
             return asciiEncodation(text, textOffset, 1, data, dataOffset, dataLength, prevEnc == mode ? 1 : -1, DM_ASCII, origDataOffset);
+        }
         if (addLatch) {
-            if (c40)
-                data[dataOffset + ptrOut++] = LATCH_C40;
-            else
-                data[dataOffset + ptrOut++] = LATCH_TEXT;
+            data[dataOffset + ptrOut++] = c40 ? LATCH_C40 : LATCH_TEXT;
         }
         int[] enc = new int[textLength * 4 + 10];
         encPtr = 0;
@@ -1396,5 +1400,4 @@ else if (eci < 16383) {
         }
         return -1;
     }
-
 }

barcodes/src/test/java/com/itextpdf/barcodes/BarcodeDataMatrixTest.java

@@ -52,16 +52,15 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
-
-import java.io.IOException;
-
 import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.junit.rules.ExpectedException;
 
+import java.io.IOException;
+
 @Category(IntegrationTest.class)
 public class BarcodeDataMatrixTest extends ExtendedITextTest {
 
@@ -195,4 +194,31 @@ public void barcode07Test() {
         int result = bc.setCode(aCode);
         Assert.assertEquals(result, BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG);
     }
+
+    @Test
+    public void barcode08Test() {
+        BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+        barcodeDataMatrix.setWidth(18);
+        barcodeDataMatrix.setHeight(18);
+        int result = barcodeDataMatrix.setCode("AbcdFFghijklmnopqrstuWXSQ");
+        Assert.assertEquals(BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG, result);
+    }
+
+    @Test
+    public void barcode09Test() {
+        BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+        barcodeDataMatrix.setWidth(17);
+        barcodeDataMatrix.setHeight(17);
+        int result = barcodeDataMatrix.setCode("AbcdFFghijklmnopqrstuWXSQ");
+        Assert.assertEquals(BarcodeDataMatrix.DM_ERROR_INVALID_SQUARE, result);
+    }
+
+    @Test
+    public void barcode10Test() {
+        BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+        barcodeDataMatrix.setWidth(26);
+        barcodeDataMatrix.setHeight(12);
+        int result = barcodeDataMatrix.setCode("AbcdFFghijklmnopqrstuWXSQ");
+        Assert.assertEquals(BarcodeDataMatrix.DM_ERROR_TEXT_TOO_BIG, result);
+    }
 }