Fix sonarqube issues for new_lcns_base branch

DEVSIX-5570

Author: Eugene Bochilo

barcodes/src/main/java/com/itextpdf/barcodes/BarcodeCodabar.java

@@ -178,8 +178,8 @@ public static byte[] getBarsCodabar(String text) {
         for (int k = 0; k < len; ++k) {
             int idx = CHARS.indexOf(text.charAt(k));
             if (idx >= START_STOP_IDX && k > 0 && k < len - 1) {
-                throw new IllegalArgumentException(
-                        BarcodeExceptionMessageConstant.IN_CODABAR_START_STOP_CHARACTERS_ARE_ONLY_ALLOWED_AT_THE_EXTREMES);
+                throw new IllegalArgumentException(BarcodeExceptionMessageConstant.
+                        IN_CODABAR_START_STOP_CHARACTERS_ARE_ONLY_ALLOWED_AT_THE_EXTREMES);
             }
             if (idx < 0) {
                 throw new IllegalArgumentException(

commons/src/main/java/com/itextpdf/commons/actions/AbstractContextBasedEventHandler.java

@@ -37,7 +37,7 @@ public abstract class AbstractContextBasedEventHandler implements IBaseEventHand
      *
      * @param onUnknownContext is a fallback for events within unknown context
      */
-    public AbstractContextBasedEventHandler(IContext onUnknownContext) {
+    protected AbstractContextBasedEventHandler(IContext onUnknownContext) {
         super();
         this.defaultContext = onUnknownContext;
     }

commons/src/main/java/com/itextpdf/commons/actions/AbstractContextBasedITextEvent.java

@@ -38,7 +38,7 @@ public abstract class AbstractContextBasedITextEvent extends AbstractProductITex
      * @param productData is a description of the product which has generated an event
      * @param metaInfo is an auxiliary meta info
      */
-    public AbstractContextBasedITextEvent(ProductData productData, IMetaInfo metaInfo) {
+    protected AbstractContextBasedITextEvent(ProductData productData, IMetaInfo metaInfo) {
         super(productData);
         this.metaInfo = metaInfo;
     }

commons/src/main/java/com/itextpdf/commons/actions/AbstractEventWrapper.java

@@ -37,7 +37,7 @@ public abstract class AbstractEventWrapper extends AbstractProductProcessITextEv
      * @param event is a {@link AbstractProductProcessITextEvent} to wrap
      * @param confirmationType event confirmation type
      */
-    public AbstractEventWrapper(AbstractProductProcessITextEvent event, EventConfirmationType confirmationType) {
+    protected AbstractEventWrapper(AbstractProductProcessITextEvent event, EventConfirmationType confirmationType) {
         super(event.getSequenceId(), event.getProductData(), event.getMetaInfo(), confirmationType);
         this.event = event;
     }
@@ -50,7 +50,8 @@ public AbstractEventWrapper(AbstractProductProcessITextEvent event, EventConfirm
      * @param event is a {@link AbstractProductProcessITextEvent} to wrap
      * @param confirmationType event confirmation type
      */
-    public AbstractEventWrapper(SequenceId updatedSequenceId, AbstractProductProcessITextEvent event, EventConfirmationType confirmationType) {
+    protected AbstractEventWrapper(SequenceId updatedSequenceId,
+                                   AbstractProductProcessITextEvent event, EventConfirmationType confirmationType) {
         super(updatedSequenceId, event.getProductData(), event.getMetaInfo(), confirmationType);
         this.event = event;
     }

commons/src/main/java/com/itextpdf/commons/actions/AbstractITextEvent.java

@@ -40,7 +40,7 @@ public abstract class AbstractITextEvent implements IBaseEvent {
     /**
      * Creates an instance of abstract iText event. Only for internal usage.
      */
-    public AbstractITextEvent() {
+    protected AbstractITextEvent() {
         boolean isUnknown = true;
         for (String namespace : INTERNAL_PACKAGES.keySet()) {
             if (this.getClass().getName().startsWith(namespace)) {

commons/src/main/java/com/itextpdf/commons/actions/AbstractProductITextEvent.java

@@ -37,7 +37,7 @@ public abstract class AbstractProductITextEvent extends AbstractITextEvent {
      *
      * @param productData is a description of the product which has generated an event
      */
-    public AbstractProductITextEvent(ProductData productData) {
+    protected AbstractProductITextEvent(ProductData productData) {
         super();
         if (productData == null) {
             // IllegalStateException is thrown because AbstractProductITextEvent for internal usage

commons/src/main/java/com/itextpdf/commons/actions/AbstractProductProcessITextEvent.java

@@ -45,7 +45,7 @@ public abstract class AbstractProductProcessITextEvent extends AbstractContextBa
      * @param confirmationType defines when the event should be confirmed to notify that the
      *                         associated process has finished successfully
      */
-    public AbstractProductProcessITextEvent(SequenceId sequenceId, ProductData productData, IMetaInfo metaInfo,
+    protected AbstractProductProcessITextEvent(SequenceId sequenceId, ProductData productData, IMetaInfo metaInfo,
             EventConfirmationType confirmationType) {
         super(productData, metaInfo);
 
@@ -61,7 +61,7 @@ public AbstractProductProcessITextEvent(SequenceId sequenceId, ProductData produ
      * @param confirmationType defines when the event should be confirmed to notify that the
      *                         associated process has finished successfully
      */
-    public AbstractProductProcessITextEvent(ProductData productData, IMetaInfo metaInfo,
+    protected AbstractProductProcessITextEvent(ProductData productData, IMetaInfo metaInfo,
             EventConfirmationType confirmationType) {
         this(null, productData, metaInfo, confirmationType);
     }

commons/src/main/java/com/itextpdf/commons/actions/AbstractStatisticsEvent.java

@@ -38,7 +38,7 @@ public abstract class AbstractStatisticsEvent extends AbstractProductITextEvent
     private static final Logger LOGGER = LoggerFactory.getLogger(AbstractStatisticsEvent.class);
 
     /**
-     * @see AbstractProductITextEvent#AbstractProductITextEvent(ProductData).
+     * @see AbstractProductITextEvent#AbstractProductITextEvent(ProductData)
      */
     protected AbstractStatisticsEvent(ProductData productData) {
         super(productData);

commons/src/main/java/com/itextpdf/commons/actions/EventManager.java

@@ -76,7 +76,8 @@ public void onEvent(IBaseEvent event) {
 
         if (caughtExceptions.size() == 1) {
             throw caughtExceptions.get(0);
-        } else if (! caughtExceptions.isEmpty()) {
+        }
+        if (!caughtExceptions.isEmpty()) {
             throw new AggregatedException(AggregatedException.ERROR_DURING_EVENT_PROCESSING, caughtExceptions);
         }
     }

commons/src/main/java/com/itextpdf/commons/actions/IBaseEvent.java

@@ -25,7 +25,7 @@ This file is part of the iText (R) project.
 /**
  * Base marker interface for any generated event of any source.
  *
- * TODO: DEVSIX-5311 rename it IEvent when the oldest mechanism is deleted
+ * <p>TODO: DEVSIX-5311 rename it IEvent when the oldest mechanism is deleted
  */
 public interface IBaseEvent {
 }