If one glyph is substituted to many glyphs, actual text should be distributed

DEVSIX-4529

Author: ars18wrw

io/src/main/java/com/itextpdf/io/font/otf/GlyphLine.java

@@ -300,6 +300,7 @@ public void substituteOneToOne(OpenTypeFontTableReader tableReader, int substitu
     public void substituteOneToMany(OpenTypeFontTableReader tableReader, int[] substGlyphIds) {
         //sequence length shall be at least 1
         int substCode = substGlyphIds[0];
+        Glyph oldGlyph = glyphs.get(idx);
         Glyph glyph = tableReader.getGlyph(substCode);
         glyphs.set(idx, glyph);
 
@@ -311,6 +312,14 @@ public void substituteOneToMany(OpenTypeFontTableReader tableReader, int[] subst
                 additionalGlyphs.add(glyph);
             }
             addAllGlyphs(idx + 1, additionalGlyphs);
+            if (null != actualText) {
+                if (null == actualText.get(idx)) {
+                    actualText.set(idx, new ActualText(oldGlyph.getUnicodeString()));
+                }
+                for (int i = 0; i < additionalGlyphs.size(); i++) {
+                    this.actualText.set(idx + 1 + i, actualText.get(idx));
+                }
+            }
             idx += substGlyphIds.length - 1;
             end += substGlyphIds.length - 1;
         }

io/src/test/java/com/itextpdf/io/font/otf/GlyphLineTest.java

@@ -42,10 +42,13 @@ This file is part of the iText (R) project.
  */
 package com.itextpdf.io.font.otf;
 
+import com.itextpdf.io.font.PdfEncodings;
 import com.itextpdf.io.font.TrueTypeFont;
 import com.itextpdf.io.util.StreamUtil;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.UnitTest;
+
+import java.io.FileNotFoundException;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
@@ -192,4 +195,59 @@ public void testContentReplacingWithNullActualText() throws IOException {
         // Test that no exception has been thrown. Also check the content.
         Assert.assertEquals("Belarus", lineToBeReplaced.toString());
     }
+
+    @Test
+    public void testActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany01() throws IOException {
+        String expectedActualTextForFirstGlyph = "0";
+        String expectedActualTextForSecondGlyph = "A";
+
+        byte[] ttf = StreamUtil.inputStreamToArray(new FileInputStream("./src/test/resources/com/itextpdf/io/font/otf/FreeSans.ttf"));
+        TrueTypeFont font = new TrueTypeFont(ttf);
+
+        // no actual text for the second glyph is set - it should be created during substitution
+        GlyphLine line = new GlyphLine(constructGlyphListFromString("AA", font));
+        line.setActualText(0, 1, expectedActualTextForFirstGlyph);
+        line.idx = 1;
+
+        line.substituteOneToMany(font.getGsubTable(), new int[] {39, 40});
+
+        Assert.assertNotNull(line.actualText);
+        Assert.assertEquals(3, line.actualText.size());
+        Assert.assertSame(line.actualText.get(1), line.actualText.get(2));
+        Assert.assertEquals(expectedActualTextForSecondGlyph, line.actualText.get(1).value);
+        // check that it hasn't been corrupted
+        Assert.assertEquals(expectedActualTextForFirstGlyph, line.actualText.get(0).value);
+    }
+
+    @Test
+    public void testActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany02() throws IOException {
+        String expectedActualTextForFirstGlyph = "A";
+
+        byte[] ttf = StreamUtil.inputStreamToArray(new FileInputStream("./src/test/resources/com/itextpdf/io/font/otf/FreeSans.ttf"));
+        TrueTypeFont font = new TrueTypeFont(ttf);
+
+        GlyphLine line = new GlyphLine(constructGlyphListFromString("A", font));
+        line.setActualText(0, 1, expectedActualTextForFirstGlyph);
+
+        line.substituteOneToMany(font.getGsubTable(), new int[] {39, 40});
+
+        Assert.assertNotNull(line.actualText);
+        Assert.assertEquals(2, line.actualText.size());
+        Assert.assertSame(line.actualText.get(0), line.actualText.get(1));
+        Assert.assertEquals(expectedActualTextForFirstGlyph, line.actualText.get(0).value);
+    }
+
+    @Test
+    public void testActualTextForSubstitutedGlyphProcessingInSubstituteOneToMany03() throws IOException {
+        byte[] ttf = StreamUtil.inputStreamToArray(new FileInputStream("./src/test/resources/com/itextpdf/io/font/otf/FreeSans.ttf"));
+        TrueTypeFont font = new TrueTypeFont(ttf);
+
+        // no actual text is set
+        GlyphLine line = new GlyphLine(constructGlyphListFromString("A", font));
+
+        line.substituteOneToMany(font.getGsubTable(), new int[] {39, 40});
+
+        Assert.assertNull(line.actualText);
+    }
 }
+

io/src/test/resources/com/itextpdf/io/font/otf/NOTICE.txt

@@ -0,0 +1,3 @@
+This software uses the following test resources under the following licenses:
+| FreeSans | GPL | https://www.gnu.org/licenses |
+| FreeSansBold | GPL | https://www.gnu.org/licenses |