Refactor log messages with non-initialized occupied area

The message has been changed to a generic one and explanations are
added in-place whenever needed

DEVSIX-1381

Author: Snipx

io/src/main/java/com/itextpdf/io/LogMessageConstant.java

@@ -89,7 +89,7 @@ public final class LogMessageConstant {
     public static final String PDF_READER_CLOSING_FAILED = "PdfReader closing failed due to the error occurred!";
     public static final String PDF_WRITER_CLOSING_FAILED = "PdfWriter closing failed due to the error occurred!";
     public static final String POPUP_ENTRY_IS_NOT_POPUP_ANNOTATION = "Popup entry in the markup annotations refers not to the annotation with Popup subtype.";
-    public static final String OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED = "Occupied area hasn't been initialized. Drawing won't be performed";
+    public static final String OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED = "Occupied area has not been initialized. {0}";
     public static final String OCSP_STATUS_IS_REVOKED = "OCSP status is revoked.";
     public static final String OCSP_STATUS_IS_UNKNOWN = "OCSP status is unknown.";
     public static final String ONE_OF_GROUPED_SOURCES_CLOSING_FAILED = "Closing of one of the grouped sources failed.";

layout/src/main/java/com/itextpdf/layout/renderer/AbstractRenderer.java

@@ -1073,7 +1073,7 @@ protected void alignChildHorizontally(IRenderer childRenderer, Rectangle current
                 }
             } catch (NullPointerException npe) {
                 Logger logger = LoggerFactory.getLogger(AbstractRenderer.class);
-                logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+                logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Some of the children might not end up aligned horizontally."));
             }
         }
     }

layout/src/main/java/com/itextpdf/layout/renderer/BlockRenderer.java

@@ -472,7 +472,7 @@ protected AbstractRenderer createOverflowRenderer(int layoutResult) {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(BlockRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }
 

layout/src/main/java/com/itextpdf/layout/renderer/ImageRenderer.java

@@ -70,6 +70,7 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.text.MessageFormat;
 import java.util.List;
 
 public class ImageRenderer extends AbstractRenderer implements ILeafElementRenderer {
@@ -264,7 +265,7 @@ public LayoutResult layout(LayoutContext layoutContext) {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(ImageRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }
         applyMargins(occupiedArea.getBBox(), false);

layout/src/main/java/com/itextpdf/layout/renderer/LinkRenderer.java

@@ -48,6 +48,8 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.text.MessageFormat;
+
 public class LinkRenderer extends TextRenderer {
 
     /**
@@ -73,7 +75,7 @@ public LinkRenderer(Link linkElement, String text) {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(LinkRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }
         super.draw(drawContext);

layout/src/main/java/com/itextpdf/layout/renderer/ListItemRenderer.java

@@ -58,6 +58,8 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.text.MessageFormat;
+
 public class ListItemRenderer extends DivRenderer {
 
     protected IRenderer symbolRenderer;
@@ -96,7 +98,7 @@ public LayoutResult layout(LayoutContext layoutContext) {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(ListItemRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }
         boolean isTagged = drawContext.isTaggingEnabled() && getModelElement() instanceof IAccessibleElement;

layout/src/main/java/com/itextpdf/layout/renderer/TabRenderer.java

@@ -55,6 +55,8 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.text.MessageFormat;
+
 public class TabRenderer extends AbstractRenderer {
     /**
      * Creates a TabRenderer from its corresponding layout object
@@ -80,7 +82,7 @@ public LayoutResult layout(LayoutContext layoutContext) {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(TabRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }
         ILineDrawer leader = this.<ILineDrawer>getProperty(Property.TAB_LEADER);

layout/src/main/java/com/itextpdf/layout/renderer/TextRenderer.java

@@ -87,6 +87,7 @@ This file is part of the iText (R) project.
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.text.MessageFormat;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -547,7 +548,7 @@ public void applyOtf() {
     public void draw(DrawContext drawContext) {
         if (occupiedArea == null) {
             Logger logger = LoggerFactory.getLogger(TextRenderer.class);
-            logger.error(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED);
+            logger.error(MessageFormat.format(LogMessageConstant.OCCUPIED_AREA_HAS_NOT_BEEN_INITIALIZED, "Drawing won't be performed."));
             return;
         }