Skip to content

Commit b7e566d

Browse files
author
glenn.volckaert
committed
Improve code quality
DEVSIX-7046
1 parent 0b0cb4c commit b7e566d

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

kernel/src/main/java/com/itextpdf/kernel/font/PdfType0Font.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,13 @@ public class PdfType0Font extends PdfFont {
224224
subset = false;
225225
}
226226

227+
/**
228+
* Get Unicode mapping name from ordering.
229+
* @param ordering the text ordering to base to unicode mapping on
230+
* @param horizontal identifies whether the encoding is horizontal or vertical
231+
*
232+
* @return Unicode mapping name
233+
*/
227234
public static String getUniMapFromOrdering(String ordering, boolean horizontal) {
228235
String result = null;
229236
switch (ordering) {
@@ -254,7 +261,9 @@ public static String getUniMapFromOrdering(String ordering, boolean horizontal)
254261
/**
255262
* Get Unicode mapping name from ordering.
256263
* @param ordering the text ordering to base to unicode mapping on
264+
*
257265
* @return Unicode mapping name
266+
*
258267
* @deprecated Replaced by {@link #getUniMapFromOrdering(String, boolean)}
259268
* for proper handling of IDENTITY_V encoding.
260269
*/

kernel/src/test/java/com/itextpdf/kernel/pdf/canvas/parser/TextRenderInfoTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ This file is part of the iText (R) project.
4242
*/
4343
package com.itextpdf.kernel.pdf.canvas.parser;
4444

45-
import com.itextpdf.io.logs.IoLogMessageConstant;
4645
import com.itextpdf.kernel.geom.LineSegment;
4746
import com.itextpdf.kernel.geom.Vector;
4847
import com.itextpdf.kernel.pdf.PdfDocument;
@@ -53,18 +52,16 @@ This file is part of the iText (R) project.
5352
import com.itextpdf.kernel.pdf.canvas.parser.listener.ITextExtractionStrategy;
5453
import com.itextpdf.kernel.pdf.canvas.parser.listener.SimpleTextExtractionStrategy;
5554
import com.itextpdf.test.ExtendedITextTest;
56-
import com.itextpdf.test.annotations.LogMessage;
57-
import com.itextpdf.test.annotations.LogMessages;
5855
import com.itextpdf.test.annotations.type.IntegrationTest;
59-
import org.junit.Assert;
60-
import org.junit.Test;
61-
import org.junit.experimental.categories.Category;
6256

6357
import java.util.ArrayList;
6458
import java.util.Collections;
6559
import java.util.LinkedHashSet;
6660
import java.util.List;
6761
import java.util.Set;
62+
import org.junit.Assert;
63+
import org.junit.Test;
64+
import org.junit.experimental.categories.Category;
6865

6966
@Category(IntegrationTest.class)
7067
public class TextRenderInfoTest extends ExtendedITextTest {
@@ -85,7 +82,6 @@ public void testCharacterRenderInfos() throws Exception {
8582
* Japanese. TextRenderInfo threw an AIOOBE for some characters.
8683
*/
8784
@Test
88-
//@LogMessages(messages = {@LogMessage(messageTemplate = IoLogMessageConstant.COULD_NOT_FIND_GLYPH_WITH_CODE, count = 2)})
8985
public void testUnicodeEmptyString() throws Exception {
9086
StringBuilder sb = new StringBuilder();
9187
String inFile = "japanese_text.pdf";

0 commit comments

Comments
 (0)