Refactor the NPE handling

Samuel Huylebroeck · Samuel Huylebroeck · commit c7a7c9618266 · 2016-09-12T11:31:38.000+02:00
SUP-1555, DEVSIX-832
diff --git a/forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java b/forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java
@@ -1800,9 +1800,8 @@ public boolean regenerateField() {
                     }
                     //Copy Bounding box
                     bBox = new PdfArray(rect);
-                }
-                //Avoid NPE when handling corrupt pdfs
-                if(matrix == null){
+                }else{
+                    //Avoid NPE when handling corrupt pdfs
                     formFieldLogger.error(LogMessageConstant.INCORRECT_PAGEROTATION);
                     matrix = new PdfArray(new double[]{1,0,0,1,0,0});
                 }

Original file line number	Diff line number	Diff line change
`@@ -1800,9 +1800,8 @@ public boolean regenerateField() {`
`1800`	`1800`	`}`
`1801`	`1801`	`//Copy Bounding box`
`1802`	`1802`	`bBox = new PdfArray(rect);`
`1803`		`- }`
`1804`		`- //Avoid NPE when handling corrupt pdfs`
`1805`		`- if(matrix == null){`
	`1803`	`+ }else{`
	`1804`	`+ //Avoid NPE when handling corrupt pdfs`
`1806`	`1805`	`formFieldLogger.error(LogMessageConstant.INCORRECT_PAGEROTATION);`
`1807`	`1806`	`matrix = new PdfArray(new double[]{1,0,0,1,0,0});`
`1808`	`1807`	`}`