[RELEASE] iText 7 Core - 7.1.4

https://github.com/itext/itext7/releases/tag/7.1.4

* release/7.1.4:
  [RELEASE] 7.1.4-SNAPSHOT -> 7.1.4
  Update too old cmp file for full compression test
  Remove relativePath from svg pom
  Fix copying fields during multiple page copying
  Create a copy for form field with name contains dot symbol
  Add test. DEVSIX-2187
  Add some new SVG tests.
  Squash multiple spaces into one if necessary.
  Update the path-processing algo.
  Add a new SVG test that demonstrates some Path-related issues.
  Update some method names in accordance with the naming convention.
  Add PdfDocument#findFont() for already added PdfFonts
  Create a unique name for each OCProperties. Update some cmps.
  SXP: Free resources after reading them
  add test for DEVSIX-2156
  Revert [a69a813] "Fix bug in CompareTool when pdfstream from output file has filter different from cmp file"
  Reformat CompareTool javadocs, add details about diffPrefix arg to all overloads
  Add new overload for CompareTool#compareByContent which generates diff preffix based off output file name
  Fix bug in CompareTool when pdfstream from output file has filter different from cmp file
  Fix some minor min/max width algo issues. Update some cmps.
  Add missing copyright headers
  Path parsing updates
  Do not substitute a symbol with itself during line transformations.
  Add implementation for Path operators v and h. RND-1108
  Make method public for pdfHtml
  Fix PdfSweep failure on documents with ligatures
  Removing relativePath from pom file QA-529
  Fix up for styled-xml-parser and svg resources in pom
  Fix typo in gsParam
  Add -dSAFER to gsParams
  Simplify POM files for styled-xml-parser and svg, so they use the values set in the root POM
  Add missing copyright headers
  Add styled-xml-parser and svg to pom.xml
  Add 'svg/' from commit '65c48971f2a171497d73e2a4ed883333a0f34b73'
  ...
  Add 'styled-xml-parser/' from commit 'b35a24b753cb7932156925141a7e7d658db4eee7'
  ...
  Add new unit fontselector tests for open sans font-family.
  Add new font selector unit tests for standard fonts. Update cmps.
  Fix issues with additional separator in ResourceResolver
  Update the javadoc and some ticket-references.
  Handle the default font-family correctly.
  Unify the font selector algorithm with the browser's one.
  Refactor the FontSelector algo.
  Add missing copyright headers
  Ignore memory hungry hyphen tests (layout)
  Allow additional x509 extensions to be critical, as discussed in Ticket SUP-2885. Add test and refactor for PR-27. DEVSIX-1982
  Fix version replacement in CompareTool
  Fix bug
  Properly check to remove root outline. DEVSIX-2046
  Deprecate FileUtil#getParentDirectory(String file)
  DESIX-2049 move functionality from svg class to io FileUtil
  Update new lines in pom.xml
  Add missing copyright headers
  Move to DocumentCloneTest class in samples-internal project
  Reflect the test method name
  Remove versionInfo NPE when deserialize lower version of PdfDocument
  [RELEASE] Merge master into develop
  [RELEASE] 7.1.3-SNAPSHOT -> 7.1.4-SNAPSHOT
  Sort dependencies in pom.xml
  Add test. DEVSIX-1669
  add test for DEVSIX-2046

Author: iText-CI

barcodes/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.3</version>
+    <version>7.1.4</version>
   </parent>
   <artifactId>barcodes</artifactId>
   <name>iText 7 - barcodes</name>

font-asian/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.3</version>
+    <version>7.1.4</version>
   </parent>
   <artifactId>font-asian</artifactId>
   <name>iText 7 - Asian fonts</name>

forms/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.3</version>
+    <version>7.1.4</version>
   </parent>
   <artifactId>forms</artifactId>
   <name>iText 7 - forms</name>

forms/src/main/java/com/itextpdf/forms/PdfPageFormCopier.java

@@ -44,13 +44,18 @@ This file is part of the iText (R) project.
 
 import com.itextpdf.forms.fields.PdfFormField;
 import com.itextpdf.forms.fields.PdfTextFormField;
+import com.itextpdf.io.LogMessageConstant;
 import com.itextpdf.kernel.colors.DeviceRgb;
 import com.itextpdf.kernel.pdf.PdfDocument;
 import com.itextpdf.kernel.pdf.PdfReader;
 import com.itextpdf.kernel.pdf.PdfWriter;
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
+import com.itextpdf.test.annotations.LogMessage;
+import com.itextpdf.test.annotations.LogMessages;
 import com.itextpdf.test.annotations.type.IntegrationTest;
+
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import org.junit.Assert;
 import org.junit.BeforeClass;
@@ -201,4 +206,28 @@ private static void fillTextFieldsThenFlattenThenCompare(String testName) throws
 
         Assert.assertNull(new CompareTool().compareByContent(dest, cmp, destinationFolder, "diff_"));
     }
+
+    @Test
+    @LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 3)})
+    //Logging is expected since there are duplicate field names
+    //isReadOnly should be true after DEVSIX-2156
+    public void flattenReadOnly() throws IOException{
+        PdfWriter writer = new PdfWriter(new ByteArrayOutputStream());
+        PdfDocument pdfDoc = new PdfDocument(writer);
+        PdfReader reader = new PdfReader(sourceFolder + "readOnlyForm.pdf");
+        PdfDocument pdfInnerDoc = new PdfDocument(reader);
+        pdfInnerDoc.copyPagesTo(1, pdfInnerDoc.getNumberOfPages(), pdfDoc, new PdfPageFormCopier());
+        pdfInnerDoc.close();
+        reader = new PdfReader(sourceFolder + "readOnlyForm.pdf");
+        pdfInnerDoc = new PdfDocument(reader);
+        pdfInnerDoc.copyPagesTo(1, pdfInnerDoc.getNumberOfPages(), pdfDoc, new PdfPageFormCopier());
+        pdfInnerDoc.close();
+        PdfAcroForm form = PdfAcroForm.getAcroForm(pdfDoc, false);
+        boolean isReadOnly = true;
+        for (PdfFormField field : form.getFormFields().values()){
+            isReadOnly = (isReadOnly && field.isReadOnly());
+        }
+        pdfDoc.close();
+        Assert.assertFalse(isReadOnly);
+    }
 }

forms/src/test/java/com/itextpdf/forms/FormFieldFlatteningTest.java

@@ -192,6 +192,91 @@ public void copyFieldsTest05() throws IOException, InterruptedException {
         Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyFields05.pdf", destinationFolder, "diff_"));
     }
 
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 12)
+    })
+    public void copyMultipleSubfieldsTest01() throws IOException, InterruptedException {
+        String srcFilename = sourceFolder + "copyMultipleSubfieldsTest01.pdf";
+        String destFilename = destinationFolder + "copyMultipleSubfieldsTest01.pdf";
+
+        PdfDocument srcDoc = new PdfDocument(new PdfReader(srcFilename));
+        PdfDocument destDoc = new PdfDocument(new PdfWriter(destFilename));
+
+        PdfPageFormCopier pdfPageFormCopier = new PdfPageFormCopier();
+        // copying the same page from the same document twice
+        for (int i = 0; i < 4; ++i) {
+            srcDoc.copyPagesTo(1, 1, destDoc, pdfPageFormCopier);
+        }
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(destDoc, false);
+
+        acroForm.getField("text_1").setValue("Text 1!");
+        acroForm.getField("text_2").setValue("Text 2!");
+        acroForm.getField("text.3").setValue("Text 3!");
+        acroForm.getField("text.4").setValue("Text 4!");
+
+        destDoc.close();
+        srcDoc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyMultipleSubfieldsTest01.pdf", destinationFolder, "diff_"));
+    }
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 2)
+    })
+    public void copyMultipleSubfieldsTest02() throws IOException, InterruptedException {
+        String srcFilename = sourceFolder + "copyMultipleSubfieldsTest02.pdf";
+        String destFilename = destinationFolder + "copyMultipleSubfieldsTest02.pdf";
+
+        PdfDocument srcDoc = new PdfDocument(new PdfReader(srcFilename));
+        PdfDocument destDoc = new PdfDocument(new PdfWriter(destFilename));
+
+        PdfPageFormCopier pdfPageFormCopier = new PdfPageFormCopier();
+        // copying the same page from the same document twice
+        for (int i = 0; i < 3; ++i) {
+            srcDoc.copyPagesTo(1, 1, destDoc, pdfPageFormCopier);
+        }
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(destDoc, false);
+
+        acroForm.getField("text.3").setValue("Text 3!");
+
+        destDoc.close();
+        srcDoc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyMultipleSubfieldsTest02.pdf", destinationFolder, "diff_"));
+    }
+
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 2)
+    })
+    public void copyMultipleSubfieldsTest03() throws IOException, InterruptedException {
+        String srcFilename = sourceFolder + "copyMultipleSubfieldsTest03.pdf";
+        String destFilename = destinationFolder + "copyMultipleSubfieldsTest03.pdf";
+
+        PdfDocument srcDoc = new PdfDocument(new PdfReader(srcFilename));
+        PdfDocument destDoc = new PdfDocument(new PdfWriter(destFilename));
+
+        PdfPageFormCopier pdfPageFormCopier = new PdfPageFormCopier();
+        // copying the same page from the same document twice
+        for (int i = 0; i < 3; ++i) {
+            srcDoc.copyPagesTo(1, 1, destDoc, pdfPageFormCopier);
+        }
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(destDoc, false);
+
+        acroForm.getField("text_1").setValue("Text 1!");
+
+        destDoc.close();
+        srcDoc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyMultipleSubfieldsTest03.pdf", destinationFolder, "diff_"));
+    }
+
     @Test
     @LogMessages(messages = {
             @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 13)
@@ -356,12 +441,38 @@ public void copyFieldsTest12() throws IOException, InterruptedException {
         Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyFields12.pdf", destinationFolder, "diff_"));
     }
 
+    @Test
+    @LogMessages(messages = {
+            @LogMessage(messageTemplate = LogMessageConstant.DOCUMENT_ALREADY_HAS_FIELD, count = 1)
+    })
+    public void copyFieldsTest13() throws IOException, InterruptedException {
+        String srcFilename = sourceFolder + "copyFields13.pdf";
+        String destFilename = destinationFolder + "copyFields13.pdf";
+
+        PdfDocument srcDoc = new PdfDocument(new PdfReader(srcFilename));
+        PdfDocument destDoc = new PdfDocument(new PdfWriter(destFilename));
+
+        PdfPageFormCopier pdfPageFormCopier = new PdfPageFormCopier();
+
+        for (int i = 0; i < 1; ++i) {
+            srcDoc.copyPagesTo(1, 1, destDoc, pdfPageFormCopier);
+        }
+
+        PdfAcroForm acroForm = PdfAcroForm.getAcroForm(destDoc, false);
+
+        acroForm.getField("text").setValue("Text!");
+
+        destDoc.close();
+        srcDoc.close();
+
+        Assert.assertNull(new CompareTool().compareByContent(destFilename, sourceFolder + "cmp_copyFields13.pdf", destinationFolder, "diff_"));
+    }
 
 
     @Test
     public void copyPagesWithInheritedResources() throws IOException, InterruptedException {
-        String sourceFile = sourceFolder +"AnnotationSampleStandard.pdf";
-        String destFile =   destinationFolder + "AnnotationSampleStandard_copy.pdf";
+        String sourceFile = sourceFolder + "AnnotationSampleStandard.pdf";
+        String destFile = destinationFolder + "AnnotationSampleStandard_copy.pdf";
         PdfDocument source = new PdfDocument(new PdfReader(sourceFile));
         PdfDocument target = new PdfDocument(new PdfWriter(destFile));
         target.initializeOutlines();