Code refactoring for renderers

Fix formatting issues, remove unused objects, rearrange imports

Author: AnhelinaM

forms/src/main/java/com/itextpdf/forms/form/renderer/AbstractFormFieldRenderer.java

@@ -261,7 +261,7 @@ protected String getModelId() {
     /**
      * Checks if the renderer fits a certain width and height.
      *
-     * @param availableWidth  the available width
+     * @param availableWidth the available width
      * @param availableHeight the available height
      *
      * @return true, if the renderer fits.
@@ -338,14 +338,14 @@ protected void writeAcroFormFieldLangAttribute(PdfDocument pdfDoc) {
 
 
     private void processLangAttribute() {
-         IPropertyContainer propertyContainer = flatRenderer.getModelElement();
-         String lang = getLang();
-         if (propertyContainer instanceof IAccessibleElement && lang != null) {
-             AccessibilityProperties properties = ((IAccessibleElement) propertyContainer)
-             .getAccessibilityProperties();
-             if (properties.getLanguage() == null) {
-                 properties.setLanguage(lang);
-             }
-         }
+        IPropertyContainer propertyContainer = flatRenderer.getModelElement();
+        String lang = getLang();
+        if (propertyContainer instanceof IAccessibleElement && lang != null) {
+            AccessibilityProperties properties = ((IAccessibleElement) propertyContainer)
+                    .getAccessibilityProperties();
+            if (properties.getLanguage() == null) {
+                properties.setLanguage(lang);
+            }
+        }
     }
 }

forms/src/main/java/com/itextpdf/forms/form/renderer/AbstractOneLineTextFieldRenderer.java

@@ -24,7 +24,6 @@ This file is part of the iText (R) project.
 
 import com.itextpdf.forms.form.element.IFormField;
 import com.itextpdf.kernel.geom.Rectangle;
-import com.itextpdf.layout.renderer.BlockRenderer;
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.renderer.LineRenderer;
 
@@ -48,7 +47,7 @@ public abstract class AbstractOneLineTextFieldRenderer extends AbstractTextField
      * Crops the content lines.
      *
      * @param lines a list of lines
-     * @param bBox  the bounding box
+     * @param bBox the bounding box
      */
     void cropContentLines(List<LineRenderer> lines, Rectangle bBox) {
         adjustNumberOfContentLines(lines, bBox, 1);
@@ -75,8 +74,8 @@ private void updateParagraphHeight() {
     /**
      * Sets the content height.
      *
-     * @param flatRenderer  the flat renderer
-     * @param height        the height
+     * @param flatRenderer the flat renderer
+     * @param height the height
      */
     void setContentHeight(IRenderer flatRenderer, float height) {
         Rectangle bBox = flatRenderer.getOccupiedArea().getBBox();

forms/src/main/java/com/itextpdf/forms/form/renderer/AbstractSelectFieldRenderer.java

@@ -236,7 +236,7 @@ protected String getModelId() {
      * to the form field builder.
      *
      * @param builder {@link ChoiceFormFieldBuilder} to set options to
-     * @param field   {@link AbstractSelectField} to retrieve the options from
+     * @param field {@link AbstractSelectField} to retrieve the options from
      */
     protected void setupBuilderValues(ChoiceFormFieldBuilder builder, AbstractSelectField field) {
         List<SelectFieldItem> options = field.getOptions();
@@ -272,8 +272,9 @@ protected void setupBuilderValues(ChoiceFormFieldBuilder builder, AbstractSelect
      * Returns final height of the select field.
      *
      * @param availableHeight available height of the layout area
-     * @param actualHeight    actual occupied height of the select field
+     * @param actualHeight actual occupied height of the select field
      * @param isClippedHeight indicates whether the layout area's height is clipped or not
+     *
      * @return final height of the select field.
      */
     protected float getFinalSelectFieldHeight(float availableHeight, float actualHeight, boolean isClippedHeight) {
@@ -291,6 +292,7 @@ protected float getFinalSelectFieldHeight(float availableHeight, float actualHei
      * Gets the conformance. If the conformance is not set, the conformance of the document is used.
      *
      * @param document the document
+     *
      * @return the conformance or null if the conformance is not set.
      */
     protected PdfConformance getConformance(PdfDocument document) {
@@ -308,6 +310,7 @@ protected PdfConformance getConformance(PdfDocument document) {
      * Gets options that are marked as selected from the select field options subtree.
      *
      * @param optionsSubTree options subtree to get selected options
+     *
      * @return selected options list.
      */
     protected List<IRenderer> getOptionsMarkedSelected(IRenderer optionsSubTree) {

forms/src/main/java/com/itextpdf/forms/form/renderer/AbstractTextFieldRenderer.java

@@ -71,6 +71,7 @@ public abstract class AbstractTextFieldRenderer extends AbstractFormFieldRendere
      * Creates a paragraph renderer.
      *
      * @param defaultValue the default value
+     *
      * @return the renderer
      */
     IRenderer createParagraphRenderer(String defaultValue) {
@@ -195,8 +196,8 @@ float updateHtmlColsSizeBasedWidth(float width) {
      * Adjust number of content lines.
      *
      * @param lines the lines that need to be rendered
-     * @param bBox  the bounding box
-     * @param rows  the desired number of lines
+     * @param bBox the bounding box
+     * @param rows the desired number of lines
      */
     void adjustNumberOfContentLines(List<LineRenderer> lines, Rectangle bBox, int rows) {
         if (lines.size() != rows) {
@@ -208,8 +209,8 @@ void adjustNumberOfContentLines(List<LineRenderer> lines, Rectangle bBox, int ro
     /**
      * Adjust number of content lines.
      *
-     * @param lines  the lines that need to be rendered
-     * @param bBox   the bounding box
+     * @param lines the lines that need to be rendered
+     * @param bBox the bounding box
      * @param height the desired height of content
      */
     void adjustNumberOfContentLines(List<LineRenderer> lines, Rectangle bBox, float height) {
@@ -238,7 +239,7 @@ float getLowestChildBottom(IRenderer renderer, float value) {
     }
 
     private static void adjustNumberOfContentLines(List<LineRenderer> lines, Rectangle bBox,
-            int linesNumber, float height) {
+                                                   int linesNumber, float height) {
         bBox.moveUp(bBox.getHeight() - height);
         bBox.setHeight(height);
         if (lines.size() > linesNumber) {

forms/src/main/java/com/itextpdf/forms/form/renderer/ButtonRenderer.java

@@ -54,13 +54,12 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.renderer.LineRenderer;
 import com.itextpdf.layout.renderer.ParagraphRenderer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.List;
 import java.util.Map;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 /**
  * The {@link AbstractTextFieldRenderer} implementation for buttons.
  */
@@ -281,7 +280,7 @@ protected void applyAcroField(DrawContext drawContext) {
         button.setFontSize(fontSizeValue);
         button.getFirstFormAnnotation().setBackgroundColor(backgroundColor);
         applyDefaultFieldProperties(button);
-        applyAccessibilityProperties(button,doc);
+        applyAccessibilityProperties(button, doc);
         button.getFirstFormAnnotation().setFormFieldElement((Button) modelElement);
         button.enableFieldRegeneration();
         PdfAcroForm forms = PdfFormCreator.getAcroForm(doc, true);

forms/src/main/java/com/itextpdf/forms/form/renderer/CheckBoxRenderer.java

@@ -185,10 +185,10 @@ protected void adjustFieldLayout(LayoutContext layoutContext) {
      * Checkboxes don't support setting of paddings as they are always centered.
      * So that this method returns the rectangle as is.
      *
-     * @param rect     a rectangle paddings will be applied on.
+     * @param rect a rectangle paddings will be applied on.
      * @param paddings the paddings to be applied on the given rectangle
-     * @param reverse  indicates whether paddings will be applied
-     *                 inside (in case of false) or outside (in case of true) the rectangle.
+     * @param reverse indicates whether paddings will be applied
+     * inside (in case of false) or outside (in case of true) the rectangle.
      *
      * @return The rectangle NOT modified by the paddings.
      */
@@ -207,7 +207,7 @@ public IRenderer createFlatRenderer() {
         final UnitValue heightUV = getPropertyAsUnitValue(Property.HEIGHT);
         final UnitValue widthUV = getPropertyAsUnitValue(Property.WIDTH);
 
-        // if it is a percentage value, we need to calculate the actual value but we
+        // if it is a percentage value, we need to calculate the actual value, but we
         // don't have the parent's width yet, so we will take the default value
         float height = DEFAULT_SIZE;
         if (heightUV != null && heightUV.isPointValue()) {

forms/src/main/java/com/itextpdf/forms/form/renderer/FormFieldValueNonTrimmingTextRenderer.java

@@ -32,7 +32,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.layout.TextLayoutResult;
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.renderer.TextRenderer;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -42,7 +41,7 @@ This file is part of the iText (R) project.
  */
 
 class FormFieldValueNonTrimmingTextRenderer extends TextRenderer {
-    // Determines whether we want to trim leading space. In particular we don't want to trim
+    // Determines whether we want to trim leading space. In particular, we don't want to trim
     // the very first leading spaces of the text value. When text overflows to the next lines,
     // whether we should trim the text depends on why the overflow happened
     private boolean callTrimFirst = false;
@@ -64,16 +63,16 @@ public LayoutResult layout(LayoutContext layoutContext) {
                 !((TextLayoutResult) baseLayoutResult).isSplitForcedByNewline()) {
             // In case the overflow to the next line happened naturally (without a forced line break),
             // we don't want to preserve the extra spaces at the beginning of the next line
-            ((FormFieldValueNonTrimmingTextRenderer) baseLayoutResult.getOverflowRenderer()).setCallTrimFirst(true);
+            ((FormFieldValueNonTrimmingTextRenderer) baseLayoutResult.getOverflowRenderer()).setCallTrimFirst();
         }
         return baseLayoutResult;
     }
 
     @Override
     public void trimFirst() {
-       if (callTrimFirst) {
-           super.trimFirst();
-       }
+        if (callTrimFirst) {
+            super.trimFirst();
+        }
     }
 
     /**
@@ -85,12 +84,12 @@ protected TextRenderer createCopy(GlyphLine gl, PdfFont font) {
             Logger logger = LoggerFactory.getLogger(FormFieldValueNonTrimmingTextRenderer.class);
             logger.error(MessageFormatUtil.format(IoLogMessageConstant.CREATE_COPY_SHOULD_BE_OVERRIDDEN));
         }
-        FormFieldValueNonTrimmingTextRenderer copy = new FormFieldValueNonTrimmingTextRenderer((Text)this.modelElement);
+        FormFieldValueNonTrimmingTextRenderer copy = new FormFieldValueNonTrimmingTextRenderer((Text) this.modelElement);
         copy.setProcessedGlyphLineAndFont(gl, font);
         return copy;
     }
 
-    private void setCallTrimFirst(boolean callTrimFirst) {
-        this.callTrimFirst = callTrimFirst;
+    private void setCallTrimFirst() {
+        this.callTrimFirst = true;
     }
 }

forms/src/main/java/com/itextpdf/forms/form/renderer/InputFieldRenderer.java

@@ -50,14 +50,13 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.renderer.LineRenderer;
 import com.itextpdf.layout.renderer.ParagraphRenderer;
-
-import java.util.List;
-import java.util.Map;
-
 import com.itextpdf.layout.tagging.IAccessibleElement;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.util.List;
+import java.util.Map;
+
 /**
  * The {@link AbstractOneLineTextFieldRenderer} implementation for input fields.
  */
@@ -244,12 +243,12 @@ protected void applyAcroField(DrawContext drawContext) {
             inputField.setComb(true);
             inputField.setMaxLen(getMaxLen());
         }
-        final int rotation = ((InputField)modelElement).getRotation();
+        final int rotation = ((InputField) modelElement).getRotation();
         if (rotation != 0) {
             inputField.getFirstFormAnnotation().setRotation(rotation);
         }
         applyDefaultFieldProperties(inputField);
-        applyAccessibilityProperties(inputField,doc);
+        applyAccessibilityProperties(inputField, doc);
         inputField.getFirstFormAnnotation().setFormFieldElement((InputField) modelElement);
         inputField.enableFieldRegeneration();
         PdfFormCreator.getAcroForm(doc, true).addField(inputField, page);
@@ -292,7 +291,7 @@ protected boolean setMinMaxWidthBasedOnFixedWidth(MinMaxWidth minMaxWidth) {
             setProperty(Property.WIDTH, null);
             Float width = retrieveWidth(0);
             if (width != null) {
-                // the field can be shrinked if necessary so only max width is set here
+                // the field can be shrunk if necessary so only max width is set here
                 minMaxWidth.setChildrenMaxWidth((float) width);
                 result = true;
             }
@@ -341,6 +340,7 @@ private int getMaxLen() {
      * Obfuscates the content of a password input field.
      *
      * @param text the password
+     *
      * @return a string consisting of '*' characters.
      */
     private String obfuscatePassword(String text) {

forms/src/main/java/com/itextpdf/forms/form/renderer/RadioRenderer.java

@@ -114,6 +114,7 @@ public void drawBackground(DrawContext drawContext) {
      * @param rect {@inheritDoc}
      * @param borders {@inheritDoc}
      * @param reverse {@inheritDoc}
+     *
      * @return {@inheritDoc}
      */
     @Override
@@ -306,14 +307,14 @@ public void drawBorder(DrawContext drawContext) {
                 final boolean isTaggingEnabled = drawContext.isTaggingEnabled();
                 final PdfCanvas canvas = drawContext.getCanvas();
 
-                if (isTaggingEnabled){
+                if (isTaggingEnabled) {
                     canvas.openTag(new CanvasArtifact());
                 }
                 canvas.setStrokeColor(border.getColor())
                         .setLineWidth(borderWidth)
                         .circle(cx, cy, r)
                         .stroke();
-                if (isTaggingEnabled){
+                if (isTaggingEnabled) {
                     canvas.closeTag();
                 }
             }
@@ -349,13 +350,13 @@ public void drawBackground(DrawContext drawContext) {
                 final boolean isTaggingEnabled = drawContext.isTaggingEnabled();
                 final PdfCanvas canvas = drawContext.getCanvas();
 
-                if (isTaggingEnabled){
+                if (isTaggingEnabled) {
                     canvas.openTag(new CanvasArtifact());
                 }
                 canvas.setFillColor(backgroundColor)
                         .circle(cx, cy, r)
                         .fill();
-                if (isTaggingEnabled){
+                if (isTaggingEnabled) {
                     canvas.closeTag();
                 }
             }

forms/src/main/java/com/itextpdf/forms/form/renderer/SelectFieldComboBoxRenderer.java

@@ -55,12 +55,12 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.renderer.DrawContext;
 import com.itextpdf.layout.renderer.IRenderer;
 import com.itextpdf.layout.tagging.IAccessibleElement;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * The {@link SelectFieldComboBoxRenderer} implementation for select field renderer.
@@ -121,7 +121,7 @@ protected void applyAcroField(DrawContext drawContext) {
                 .setConformance(getConformance(doc));
 
         applyMargins(area, false);
-        final Map<Integer, Object> properties =  FormFieldRendererUtil.removeProperties(this.modelElement);
+        final Map<Integer, Object> properties = FormFieldRendererUtil.removeProperties(this.modelElement);
 
         modelElement.setProperty(Property.FONT_PROVIDER, this.<FontProvider>getProperty(Property.FONT_PROVIDER));
         modelElement.setProperty(Property.RENDERING_MODE, this.<RenderingMode>getProperty(Property.RENDERING_MODE));