Skip to content

Commit d3b3998

Browse files
yulian-gaponenkoUbuntu
yulian-gaponenko
authored and
Ubuntu
committed
Rename #createDocument to #createDummyDocument in RendererUnitTest
DEVSIX-3958
1 parent 147f3f6 commit d3b3998

File tree

3 files changed

+28
-59
lines changed

3 files changed

+28
-59
lines changed

‎layout/src/test/java/com/itextpdf/layout/renderer/LineRendererUnitTest.java

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public class LineRendererUnitTest extends RendererUnitTest {
8484

8585
@Test
8686
public void adjustChildPositionsAfterReorderingSimpleTest01() {
87-
Document dummyDocument = createDocument();
87+
Document dummyDocument = createDummyDocument();
8888
IRenderer dummy1 = createLayoutedTextRenderer("Hello", dummyDocument);
8989
IRenderer dummy2 = createLayoutedTextRenderer("world", dummyDocument);
9090
IRenderer dummyImage = createLayoutedImageRenderer(100, 100, dummyDocument);
@@ -101,7 +101,7 @@ public void adjustChildPositionsAfterReorderingSimpleTest01() {
101101
@LogMessages(messages = {
102102
@LogMessage(messageTemplate = LogMessageConstant.PROPERTY_IN_PERCENTS_NOT_SUPPORTED, count = 4)})
103103
public void adjustChildPositionsAfterReorderingTestWithPercentMargins01() {
104-
Document dummyDocument = createDocument();
104+
Document dummyDocument = createDummyDocument();
105105
IRenderer dummy1 = createLayoutedTextRenderer("Hello", dummyDocument);
106106
dummy1.setProperty(Property.MARGIN_LEFT, UnitValue.createPercentValue(10));
107107
dummy1.setProperty(Property.MARGIN_RIGHT, UnitValue.createPercentValue(10));
@@ -118,7 +118,7 @@ public void adjustChildPositionsAfterReorderingTestWithPercentMargins01() {
118118

119119
@Test
120120
public void adjustChildPositionsAfterReorderingTestWithFloats01() {
121-
Document dummyDocument = createDocument();
121+
Document dummyDocument = createDummyDocument();
122122
IRenderer dummy1 = createLayoutedTextRenderer("Hello", dummyDocument);
123123
IRenderer dummy2 = createLayoutedTextRenderer("world", dummyDocument);
124124
IRenderer dummyImage = createLayoutedImageRenderer(100, 100, dummyDocument);
@@ -136,7 +136,7 @@ public void adjustChildPositionsAfterReorderingTestWithFloats01() {
136136
@Test
137137
@LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.INLINE_BLOCK_ELEMENT_WILL_BE_CLIPPED)})
138138
public void inlineBlockWithBigMinWidth01() {
139-
Document dummyDocument = createDocument();
139+
Document dummyDocument = createDummyDocument();
140140
LineRenderer lineRenderer = (LineRenderer) new LineRenderer().setParent(dummyDocument.getRenderer());
141141
Div div = new Div().setMinWidth(2000).setHeight(100);
142142
DivRenderer inlineBlockRenderer = (DivRenderer) div.createRendererSubTree();
@@ -150,7 +150,7 @@ public void inlineBlockWithBigMinWidth01() {
150150

151151
@Test
152152
public void adjustChildrenYLineTextChildHtmlModeTest() {
153-
Document document = createDocument();
153+
Document document = createDummyDocument();
154154

155155
LineRenderer lineRenderer = new LineRenderer();
156156
lineRenderer.setParent(document.getRenderer());
@@ -172,7 +172,7 @@ public void adjustChildrenYLineTextChildHtmlModeTest() {
172172

173173
@Test
174174
public void adjustChildrenYLineImageChildHtmlModeTest() {
175-
Document document = createDocument();
175+
Document document = createDummyDocument();
176176

177177
LineRenderer lineRenderer = new LineRenderer();
178178
lineRenderer.setParent(document.getRenderer());
@@ -231,7 +231,7 @@ public void hasChildRendererInHtmlModeNoChildrenTest() {
231231

232232
@Test
233233
public void lineRendererLayoutInHtmlModeWithLineHeightAndNoChildrenTest() {
234-
Document document = createDocument();
234+
Document document = createDummyDocument();
235235

236236
LineRenderer lineRenderer = new LineRenderer();
237237
lineRenderer.setParent(document.getRenderer());
@@ -246,7 +246,7 @@ public void lineRendererLayoutInHtmlModeWithLineHeightAndNoChildrenTest() {
246246

247247
@Test
248248
public void lineRendererLayoutInHtmlModeWithLineHeightAndChildrenInDefaultModeTest() {
249-
Document document = createDocument();
249+
Document document = createDummyDocument();
250250

251251
LineRenderer lineRenderer = new LineRenderer();
252252
lineRenderer.setParent(document.getRenderer());
@@ -270,7 +270,7 @@ public void lineRendererLayoutInHtmlModeWithLineHeightAndChildrenInDefaultModeTe
270270

271271
@Test
272272
public void lineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlModeTest() {
273-
Document document = createDocument();
273+
Document document = createDummyDocument();
274274

275275
LineRenderer lineRenderer = new LineRenderer();
276276
lineRenderer.setParent(document.getRenderer());
@@ -294,7 +294,7 @@ public void lineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlModeTest() {
294294
@Test
295295
public void lineRendererLayoutInHtmlModeWithLineHeightPropertyNotSet() throws IOException {
296296
LineRenderer lineRenderer = new LineRenderer();
297-
lineRenderer.setParent(createDocument().getRenderer());
297+
lineRenderer.setParent(createDummyDocument().getRenderer());
298298
lineRenderer.setProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
299299

300300
// Set fonts with different ascent/descent to line and text
@@ -316,9 +316,6 @@ public void lineRendererLayoutInHtmlModeWithLineHeightPropertyNotSet() throws IO
316316

317317
@Test
318318
public void minMaxWidthEqualsActualMarginsBordersPaddings() {
319-
PdfDocument pdfDocument = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
320-
Document document = new Document(pdfDocument);
321-
322319
Text ranText = new Text("ran");
323320
ranText.setProperty(Property.MARGIN_LEFT, new UnitValue(UnitValue.POINT, 8f));
324321

@@ -341,7 +338,7 @@ public void minMaxWidthEqualsActualMarginsBordersPaddings() {
341338
new Rectangle(AbstractRenderer.INF, AbstractRenderer.INF));
342339

343340
LineRenderer lineRenderer = new LineRenderer();
344-
lineRenderer.setParent(document.getRenderer());
341+
lineRenderer.setParent(createDummyDocument().getRenderer());
345342
lineRenderer.addChild(ran);
346343
lineRenderer.addChild(dom);
347344

@@ -353,7 +350,7 @@ public void minMaxWidthEqualsActualMarginsBordersPaddings() {
353350

354351
@Test
355352
public void splitLineIntoGlyphsSimpleTest() {
356-
Document dummyDocument = createDocument();
353+
Document dummyDocument = createDummyDocument();
357354
TextRenderer dummy1 = createLayoutedTextRenderer("hello", dummyDocument);
358355
TextRenderer dummy2 = createLayoutedTextRenderer("world", dummyDocument);
359356
TextRenderer dummy3 = createLayoutedTextRenderer("!!!", dummyDocument);
@@ -386,7 +383,7 @@ public void splitLineIntoGlyphsSimpleTest() {
386383

387384
@Test
388385
public void splitLineIntoGlyphsWithLineBreakTest() {
389-
Document dummyDocument = createDocument();
386+
Document dummyDocument = createDummyDocument();
390387
TextRenderer dummy1 = createLayoutedTextRenderer("hello", dummyDocument);
391388
TextRenderer dummy2 = createLayoutedTextRenderer("world", dummyDocument);
392389
dummy2.line.set(2, new Glyph('\n', 0, '\n'));
@@ -419,7 +416,7 @@ public void splitLineIntoGlyphsWithLineBreakTest() {
419416

420417
@Test
421418
public void reorderSimpleTest() {
422-
Document dummyDocument = createDocument();
419+
Document dummyDocument = createDummyDocument();
423420
IRenderer dummy1 = createLayoutedTextRenderer("hello", dummyDocument);
424421
IRenderer dummy2 = createLayoutedTextRenderer("world", dummyDocument);
425422
IRenderer dummy3 = createLayoutedTextRenderer("!!!", dummyDocument);

‎layout/src/test/java/com/itextpdf/layout/renderer/RendererUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ This file is part of the iText (R) project.
5757
public abstract class RendererUnitTest extends ExtendedITextTest {
5858

5959
// This also can be converted to a @Rule to have it all at hand in the future
60-
protected static Document createDocument() {
60+
protected static Document createDummyDocument() {
6161
return new Document(new PdfDocument(new PdfWriter(new ByteArrayOutputStream())));
6262
}
6363

‎layout/src/test/java/com/itextpdf/layout/renderer/TextRendererTest.java

Lines changed: 13 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ This file is part of the iText (R) project.
6161
import com.itextpdf.layout.layout.LayoutResult;
6262
import com.itextpdf.layout.layout.TextLayoutResult;
6363
import com.itextpdf.layout.minmaxwidth.MinMaxWidth;
64+
import com.itextpdf.layout.property.FloatPropertyValue;
6465
import com.itextpdf.layout.property.OverflowPropertyValue;
6566
import com.itextpdf.layout.property.OverflowWrapPropertyValue;
6667
import com.itextpdf.layout.property.Property;
@@ -203,7 +204,7 @@ public void setFontAsText() {
203204

204205
@Test
205206
public void getDescentTest() {
206-
Document doc = createDocument();
207+
Document doc = createDummyDocument();
207208
TextRenderer textRenderer = createLayoutedTextRenderer("hello", doc);
208209
textRenderer.setProperty(Property.PADDING_TOP, UnitValue.createPointValue(20f));
209210
textRenderer.setProperty(Property.MARGIN_TOP, UnitValue.createPointValue(20f));
@@ -212,7 +213,7 @@ public void getDescentTest() {
212213

213214
@Test
214215
public void getOccupiedAreaBBoxTest() {
215-
Document doc = createDocument();
216+
Document doc = createDummyDocument();
216217
TextRenderer textRenderer = createLayoutedTextRenderer("hello", doc);
217218
textRenderer.setProperty(Property.PADDING_TOP, UnitValue.createPointValue(20f));
218219
textRenderer.setProperty(Property.MARGIN_TOP, UnitValue.createPointValue(20f));
@@ -224,7 +225,7 @@ public void getOccupiedAreaBBoxTest() {
224225

225226
@Test
226227
public void getInnerAreaBBoxTest() {
227-
Document doc = createDocument();
228+
Document doc = createDummyDocument();
228229
TextRenderer textRenderer = createLayoutedTextRenderer("hello", doc);
229230
textRenderer.setProperty(Property.PADDING_TOP, UnitValue.createPointValue(20f));
230231
textRenderer.setProperty(Property.MARGIN_TOP, UnitValue.createPointValue(20f));
@@ -284,19 +285,14 @@ public void cyrillicCharacterDoesntBelongToSpecificScripts() {
284285
// u0433 Cyrillic Small Letter U
285286
Assert.assertFalse(TextRenderer.codePointIsOfSpecialScript(1091));
286287
}
287-
288+
288289
@Test
289290
public void overflowWrapAnywhereProperty() {
290-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
291-
pdfDoc.addNewPage();
292-
Document doc = new Document(pdfDoc);
293-
RootRenderer documentRenderer = doc.getRenderer();
294-
295291
Text text = new Text("wow");
296292
text.setProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
297293

298294
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
299-
textRenderer.setParent(documentRenderer);
295+
textRenderer.setParent(createDummyDocument().getRenderer());
300296

301297
MinMaxWidth minMaxWidth = textRenderer.getMinMaxWidth();
302298

@@ -305,17 +301,13 @@ public void overflowWrapAnywhereProperty() {
305301

306302
@Test
307303
public void overflowWrapBreakWordProperty() {
308-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
309-
pdfDoc.addNewPage();
310-
Document doc = new Document(pdfDoc);
311-
RootRenderer documentRenderer = doc.getRenderer();
312-
313304
Text text = new Text("wooow");
314305

315306
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
316-
textRenderer.setParent(documentRenderer);
307+
RootRenderer parentRenderer = createDummyDocument().getRenderer();
308+
textRenderer.setParent(parentRenderer);
317309
// overflow is set here to mock LineRenderer#layout behavior
318-
documentRenderer.setProperty(Property.OVERFLOW_X, OverflowPropertyValue.VISIBLE);
310+
parentRenderer.setProperty(Property.OVERFLOW_X, OverflowPropertyValue.VISIBLE);
319311

320312
float fullWordWidth = textRenderer.getMinMaxWidth().getMaxWidth();
321313

@@ -332,16 +324,11 @@ public void overflowWrapBreakWordProperty() {
332324

333325
@Test
334326
public void overflowWrapAnywhereBoldSimulationMaxWidth() {
335-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
336-
pdfDoc.addNewPage();
337-
Document doc = new Document(pdfDoc);
338-
RootRenderer documentRenderer = doc.getRenderer();
339-
340327
Text text = new Text("wow");
341328
text.setBold();
342329

343330
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
344-
textRenderer.setParent(documentRenderer);
331+
textRenderer.setParent(createDummyDocument().getRenderer());
345332

346333
float maxWidthNoOverflowWrap = textRenderer.getMinMaxWidth().getMaxWidth();
347334

@@ -353,16 +340,11 @@ public void overflowWrapAnywhereBoldSimulationMaxWidth() {
353340

354341
@Test
355342
public void overflowWrapAnywhereItalicSimulationMaxWidth() {
356-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
357-
pdfDoc.addNewPage();
358-
Document doc = new Document(pdfDoc);
359-
RootRenderer documentRenderer = doc.getRenderer();
360-
361343
Text text = new Text("wow");
362344
text.setItalic();
363345

364346
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
365-
textRenderer.setParent(documentRenderer);
347+
textRenderer.setParent(createDummyDocument().getRenderer());
366348

367349
float maxWidthNoOverflowWrap = textRenderer.getMinMaxWidth().getMaxWidth();
368350

@@ -374,16 +356,11 @@ public void overflowWrapAnywhereItalicSimulationMaxWidth() {
374356

375357
@Test
376358
public void overflowWrapAnywhereBoldSimulationMinWidth() {
377-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
378-
pdfDoc.addNewPage();
379-
Document doc = new Document(pdfDoc);
380-
RootRenderer documentRenderer = doc.getRenderer();
381-
382359
Text text = new Text("wow");
383360
text.setProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
384361

385362
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
386-
textRenderer.setParent(documentRenderer);
363+
textRenderer.setParent(createDummyDocument().getRenderer());
387364

388365
float minWidthNoBoldSimulation = textRenderer.getMinMaxWidth().getMinWidth();
389366

@@ -395,16 +372,11 @@ public void overflowWrapAnywhereBoldSimulationMinWidth() {
395372

396373
@Test
397374
public void overflowWrapAnywhereItalicSimulationMinWidth() {
398-
PdfDocument pdfDoc = new PdfDocument(new PdfWriter(new ByteArrayOutputStream()));
399-
pdfDoc.addNewPage();
400-
Document doc = new Document(pdfDoc);
401-
RootRenderer documentRenderer = doc.getRenderer();
402-
403375
Text text = new Text("wow");
404376
text.setProperty(Property.OVERFLOW_WRAP, OverflowWrapPropertyValue.ANYWHERE);
405377

406378
TextRenderer textRenderer = (TextRenderer) text.getRenderer();
407-
textRenderer.setParent(documentRenderer);
379+
textRenderer.setParent(createDummyDocument().getRenderer());
408380

409381
float minWidthNoItalicSimulation = textRenderer.getMinMaxWidth().getMinWidth();
410382

0 commit comments

Comments
 (0)