Catch failed newline glyph retrieval

Handle missing newline through FontEncoding
add test for type 3 font

DEVSIX-2393

Author: Samuel Huylebroeck

forms/src/test/java/com/itextpdf/forms/PdfFormFieldTest.java

@@ -777,8 +777,6 @@ private void fillAcroForm(PdfDocument pdfDocument, String text){
     }
 
     @Test
-    //DEVSIX-2393
-    //TODO change cmp file after fix
     public void multilineFormFieldNewLineTest() throws IOException, InterruptedException {
         String testName = "multilineFormFieldNewLineTest";
         String outPdf = destinationFolder + testName + ".pdf";
@@ -803,6 +801,30 @@ public void multilineFormFieldNewLineTest() throws IOException, InterruptedExcep
         }
     }
 
+    @Test
+    public void multilineFormFieldNewLineFontType3Test() throws IOException, InterruptedException {
+        String testName = "multilineFormFieldNewLineFontType3Test";
+
+        String outPdf = destinationFolder + testName + ".pdf";
+        String cmpPdf = sourceFolder + "cmp_"+ testName + ".pdf";
+        String srcPdf = sourceFolder + testName + ".pdf";
+
+        PdfWriter writer = new PdfWriter(outPdf);
+        PdfReader reader = new PdfReader(srcPdf);
+        PdfDocument pdfDoc = new PdfDocument(reader, writer);
+
+        PdfAcroForm form = PdfAcroForm.getAcroForm(pdfDoc, true);
+        PdfTextFormField info = (PdfTextFormField) form.getField("info");
+        info.setValue("A\n\nE");
+       
+        pdfDoc.close();
+        CompareTool compareTool = new CompareTool();
+        String errorMessage = compareTool.compareByContent(outPdf, cmpPdf, destinationFolder, "diff_");
+        if (errorMessage != null) {
+            Assert.fail(errorMessage);
+        }
+    }
+
     @Test
     public void fillFormWithSameEmptyObjsForAppearance() throws IOException, InterruptedException {
         String outPdf = destinationFolder + "fillFormWithSameEmptyObjsForAppearance.pdf";

forms/src/test/resources/com/itextpdf/forms/PdfFormFieldTest/cmp_multilineFormFieldNewLineFontType3Test.pdf

@@ -218,7 +218,7 @@ public int convertToByte(int unicode) {
      * @return {@code true} if {@code ch} could be encoded.
      */
     public boolean canEncode(int unicode) {
-        return unicodeToCode.containsKey(unicode) || TextUtil.isNonPrintable(unicode);
+        return unicodeToCode.containsKey(unicode) || TextUtil.isNonPrintable(unicode) || TextUtil.isNewLine(unicode);
     }
 
     /**

forms/src/test/resources/com/itextpdf/forms/PdfFormFieldTest/cmp_multilineFormFieldNewLineTest.pdf

@@ -221,8 +221,35 @@ public static String charToString(char ch) {
         return String.valueOf(ch);
     }
 
+    /**
+     * Check if a glyph is a newline by checking if it's unicode value is a newline
+     *
+     * @param glyph glyph to check
+     * @return True if the glyph represents a newline, false otherwise
+     */
     public static boolean isNewLine(Glyph glyph) {
         int unicode = glyph.getUnicode();
+        return isNewLine(unicode);
+    }
+
+    /**
+     * Check if a character is a newline by checking if it's integer value is a newline in unicode
+     *
+     * @param c character to check
+     * @return True if the character represents a newline, false otherwise
+     */
+    public static boolean isNewLine(char c) {
+        int unicode = (int) c;
+        return isNewLine(unicode);
+    }
+
+    /**
+     * Check if a character is a newline by checking if it's integer value is a newline in unicode
+     *
+     * @param unicode unicode value to check
+     * @return True if the character represents a newline, false otherwise
+     */
+    public static boolean isNewLine(int unicode) {
         return unicode == '\n' || unicode == '\r';
     }