Fix issue in font-face#font-family property with quotes.

Embed full font on any subset issues.
Improve behaviour in case equal font families, but different subfamilies

DEVSIX-1369

Author: pavel-alay

io/src/main/java/com/itextpdf/io/LogMessageConstant.java

@@ -71,6 +71,7 @@ public final class LogMessageConstant {
     public static final String FLUSHED_OBJECT_CONTAINS_REFERENCE_WHICH_NOT_REFER_TO_ANY_OBJECT = "Flushed object contains indirect reference which doesn't refer to any other object (e.g. this reference might be a free reference). Null object will be written instead.";
     public static final String FONT_HAS_INVALID_GLYPH = "Font {0} has invalid glyph: {1}";
     public static final String FONT_PROPERTY_MUST_BE_PDF_FONT_OBJECT = "The Font Property must be a PdfFont object";
+    public static final String FONT_SUBSET_ISSUE = "Font subset issue. Full font will be embedded.";
     public static final String FORBID_RELEASE_IS_SET = "ForbidRelease flag is set and release is called. Releasing will not be performed.";
     public static final String FORM_FIELD_WAS_FLUSHED = "A form field was flushed. There's no way to create this field in the AcroForm dictionary.";
     public static final String GRAPHICS_STATE_WAS_DELETED = "Graphics state is always deleted after event dispatching. If you want to preserve it in renderer info, use preserveGraphicsState method after receiving renderer info.";

kernel/src/main/java/com/itextpdf/kernel/font/PdfType0Font.java

@@ -849,10 +849,17 @@ private void flushFontData() {
                         new PdfName(MessageFormatUtil.format("{0}-{1}", fontName, cmapEncoding.getCmapName())));
                 fontDescriptor.put(PdfName.FontFile3, fontStream);
             } else {
-                byte[] ttfBytes;
+                byte[] ttfBytes = null;
                 if (subset || ttf.getDirectoryOffset() != 0) {
-                    ttfBytes = ttf.getSubset(new LinkedHashSet<>(longTag.keySet()), true);
-                } else {
+                    try {
+                        ttfBytes = ttf.getSubset(new LinkedHashSet<>(longTag.keySet()), true);
+                    } catch (com.itextpdf.io.IOException e) {
+                        Logger logger = LoggerFactory.getLogger(PdfType0Font.class);
+                        logger.warn(LogMessageConstant.FONT_SUBSET_ISSUE);
+                        ttfBytes = null;
+                    }
+                }
+                if (ttfBytes == null) {
                     ttfBytes = ttf.getFontStreamBytes();
                 }
                 fontStream = getPdfFontStream(ttfBytes, new int[]{ttfBytes.length});

layout/src/main/java/com/itextpdf/layout/font/FontFamilySplitter.java

@@ -56,11 +56,11 @@ public final class FontFamilySplitter {
     private static final Pattern FONT_FAMILY_PATTERN_QUOTED = Pattern.compile("^ *(('[\\w -]+')|(\"[\\w -]+\")) *$");
     private static final Pattern FONT_FAMILY_PATTERN_QUOTED_SELECT = Pattern.compile("[\\w-]+( +[\\w-]+)*");
 
-    public static List<String> splitFontFamily(String fontFamily) {
-        if (fontFamily == null) {
+    public static List<String> splitFontFamily(String fontFamilies) {
+        if (fontFamilies == null) {
             return null;
         }
-        String[] names = fontFamily.split(",");
+        String[] names = fontFamilies.split(",");
         List<String> result = new ArrayList<>(names.length);
         for (String name : names) {
             if (FONT_FAMILY_PATTERN.matcher(name).matches()) {
@@ -74,4 +74,12 @@ public static List<String> splitFontFamily(String fontFamily) {
         }
         return result;
     }
+
+    public static String removeQuotes(String fontFamily) {
+        Matcher selectMatcher = FONT_FAMILY_PATTERN_QUOTED_SELECT.matcher(fontFamily);
+        if (selectMatcher.find()) {
+            return selectMatcher.group();
+        }
+        return null;
+    }
 }

layout/src/main/java/com/itextpdf/layout/font/FontSelector.java

@@ -177,12 +177,24 @@ private static int characteristicsSimilarity(String fontName, FontCharacteristic
             FontProgramDescriptor descriptor = fontInfo.getDescriptor();
             // Note, aliases are custom behaviour, so in FontSelector will find only exact name,
             // it should not be any 'contains' with aliases.
-            if (fontName.equals(descriptor.getFullNameLowerCase()) || fontName.equals(descriptor.getFontNameLowerCase())
-                    || fontName.equals(fontInfo.getAlias())) {
-                score += 10;
-            } else if (descriptor.getFullNameLowerCase().contains(fontName) || descriptor.getFontNameLowerCase().contains(fontName)) {
+            boolean checkContains = true;
+            if (fontName.equals(descriptor.getFullNameLowerCase())) {
+                score += 4;
+                checkContains = false;
+            }
+            if (fontName.equals(descriptor.getFontNameLowerCase())) {
+                score += 4;
+                checkContains = false;
+            }
+            if (fontName.equals(fontInfo.getAlias())) {
+                score += 4;
+                checkContains = false;
+            }
+
+            if (checkContains) {
                 //yes, we will not find contains for each alias.
-                score += 7;
+                if (descriptor.getFullNameLowerCase().contains(fontName)) score += 3;
+                if (descriptor.getFontNameLowerCase().contains(fontName)) score += 3;
             }
 
             return score;